From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AB9FC11D07 for ; Thu, 20 Feb 2020 11:05:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 33033208C4 for ; Thu, 20 Feb 2020 11:05:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33033208C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B9CAD6B0005; Thu, 20 Feb 2020 06:05:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B4B156B0006; Thu, 20 Feb 2020 06:05:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A60526B0007; Thu, 20 Feb 2020 06:05:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0165.hostedemail.com [216.40.44.165]) by kanga.kvack.org (Postfix) with ESMTP id 8F2796B0005 for ; Thu, 20 Feb 2020 06:05:40 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 47990442B for ; Thu, 20 Feb 2020 11:05:40 +0000 (UTC) X-FDA: 76510224840.21.cart86_6ba5876967e50 X-HE-Tag: cart86_6ba5876967e50 X-Filterd-Recvd-Size: 1829 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Thu, 20 Feb 2020 11:05:39 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 99BD630E; Thu, 20 Feb 2020 03:05:38 -0800 (PST) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.196.71]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B4FCE3F6CF; Thu, 20 Feb 2020 03:05:37 -0800 (PST) Date: Thu, 20 Feb 2020 11:05:35 +0000 From: Catalin Marinas To: Nathan Chancellor Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Nick Desaulniers Subject: Re: [PATCH v2] mm: kmemleak: Use address-of operator on section symbols Message-ID: <20200220110535.GA103002@arrakis.emea.arm.com> References: <20200220051551.44000-1-natechancellor@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200220051551.44000-1-natechancellor@gmail.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 19, 2020 at 10:15:51PM -0700, Nathan Chancellor wrote: > Clang warns: > > These are not true arrays, they are linker defined symbols, which are > just addresses. Using the address of operator silences the warning and > does not change the resulting assembly with either clang/ld.lld or > gcc/ld (tested with diff + objdump -Dr). > > Link: https://github.com/ClangBuiltLinux/linux/issues/895 > Suggested-by: Nick Desaulniers > Signed-off-by: Nathan Chancellor Acked-by: Catalin Marinas