From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F5C0C11D00 for ; Thu, 20 Feb 2020 05:15:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B3E9D24654 for ; Thu, 20 Feb 2020 05:15:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xx3FHDhV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3E9D24654 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 611016B0007; Thu, 20 Feb 2020 00:15:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C2646B0008; Thu, 20 Feb 2020 00:15:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FEDE6B000A; Thu, 20 Feb 2020 00:15:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0205.hostedemail.com [216.40.44.205]) by kanga.kvack.org (Postfix) with ESMTP id 35B396B0007 for ; Thu, 20 Feb 2020 00:15:57 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 050608248D7C for ; Thu, 20 Feb 2020 05:15:57 +0000 (UTC) X-FDA: 76509343512.07.cry68_6e1c164409e18 X-HE-Tag: cry68_6e1c164409e18 X-Filterd-Recvd-Size: 4359 Received: from mail-oi1-f195.google.com (mail-oi1-f195.google.com [209.85.167.195]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Thu, 20 Feb 2020 05:15:56 +0000 (UTC) Received: by mail-oi1-f195.google.com with SMTP id b18so26367380oie.2 for ; Wed, 19 Feb 2020 21:15:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vI7Ptj3tyiI6Bv9R/KxNJDPiLdqKFuHEWY4U42IkyNA=; b=Xx3FHDhVfLZEkroQaeX3VQq7Ab3/xB9qwIFvpQHqKhD3YRtcbu7ME1pEiRTe5EglhA 9+xRZuuXJjIvODxi8ljQNn7EfcpMUj5s1dfUeCNazpZEKLitPFqVOWvn8gb6GaNcNSMu g45N4HO0etsz1s+K4dIUjwy1q0KsK+pjN5hhzgJMzouDldSUT8zIH0Mv6SGVuKy+hXII 0SQWGrJ1e8m7Umil/IQLznTX5AvEwi8psnserhQMK5JfVcI1rz0+ZQ3AplZtJWAaNmYk dslrthV9NHe+qRO0LuwDJnX0uxJu8quxpjs/lzi4DX7HO+I5z7m3UxYaKJjwTEFzC2vo PF5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=vI7Ptj3tyiI6Bv9R/KxNJDPiLdqKFuHEWY4U42IkyNA=; b=VUmPJxdTxPfBy3vNhIIS6+UdPoatN44F8by8d71SdR0fm4wvcpUYqV3uAhcOJVeWX7 y4Zfjhbl8APFX2dtW2yKrcP4nNb6/2P8Rfm4i5B77KhE56HkL7pSv1pIi8yYaq2KXMAy jkd83c4wWM61MCN5d/sN5hZ5hlhyWiTa7AbgCiEvGQRHzHYmJPOVrnKezGHypRt1bJQT FhgpEis4c5xLFTM0bnq++lsKCQ+kKhEtp1Zkl9DVk6teRZm2dub3Hxjw7pUtnIYhhCuh 9Tk7+8Bq+bfm8eGO2pOuPjJ/EnEpFRMs03s21+RGYytzkhPV47ESU7uytBxRf6XSs9jH JEJg== X-Gm-Message-State: APjAAAV+OgTYWwa7Y4QAId+bniA1IwFUUYoTYh79Ql/tSwOX/vvRNhX0 jYr/vBUSEfdwJR5xJtMKJNo= X-Google-Smtp-Source: APXvYqzLhYgiQPTpzyMusksg+32NvOyeip6pnteaQB8FdBhJwdu5dbcEm0EpZwfEdvYHwFQeEq5Pfw== X-Received: by 2002:aca:4b0f:: with SMTP id y15mr786374oia.153.1582175755792; Wed, 19 Feb 2020 21:15:55 -0800 (PST) Received: from localhost.localdomain ([2604:1380:4111:8b00::1]) by smtp.gmail.com with ESMTPSA id s12sm756411oic.31.2020.02.19.21.15.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Feb 2020 21:15:55 -0800 (PST) From: Nathan Chancellor To: Catalin Marinas , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com, Nathan Chancellor , Nick Desaulniers Subject: [PATCH v2] mm: kmemleak: Use address-of operator on section symbols Date: Wed, 19 Feb 2020 22:15:51 -0700 Message-Id: <20200220051551.44000-1-natechancellor@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Patchwork-Bot: notify Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Clang warns: These are not true arrays, they are linker defined symbols, which are just addresses. Using the address of operator silences the warning and does not change the resulting assembly with either clang/ld.lld or gcc/ld (tested with diff + objdump -Dr). Link: https://github.com/ClangBuiltLinux/linux/issues/895 Suggested-by: Nick Desaulniers Signed-off-by: Nathan Chancellor --- v1 -> v2: https://lore.kernel.org/lkml/20200219045423.54190-6-natechancel= lor@gmail.com/ * No longer a series because there is no prerequisite patch. * Use address-of operator instead of casting to unsigned long. mm/kmemleak.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/kmemleak.c b/mm/kmemleak.c index aa6832432d6a..788dc5509539 100644 --- a/mm/kmemleak.c +++ b/mm/kmemleak.c @@ -1952,7 +1952,7 @@ void __init kmemleak_init(void) create_object((unsigned long)__bss_start, __bss_stop - __bss_start, KMEMLEAK_GREY, GFP_ATOMIC); /* only register .data..ro_after_init if not within .data */ - if (__start_ro_after_init < _sdata || __end_ro_after_init > _edata) + if (&__start_ro_after_init < &_sdata || &__end_ro_after_init > &_edata) create_object((unsigned long)__start_ro_after_init, __end_ro_after_init - __start_ro_after_init, KMEMLEAK_GREY, GFP_ATOMIC); --=20 2.25.1