From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8996C34022 for ; Wed, 19 Feb 2020 21:37:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5E16B2465D for ; Wed, 19 Feb 2020 21:37:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="nm3BhC6k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E16B2465D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0AF136B007B; Wed, 19 Feb 2020 16:37:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0604B6B007D; Wed, 19 Feb 2020 16:37:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB8776B007E; Wed, 19 Feb 2020 16:37:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0104.hostedemail.com [216.40.44.104]) by kanga.kvack.org (Postfix) with ESMTP id D20796B007B for ; Wed, 19 Feb 2020 16:37:57 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9CE8840D7 for ; Wed, 19 Feb 2020 21:37:57 +0000 (UTC) X-FDA: 76508189394.17.mine89_285a37b6c2036 X-HE-Tag: mine89_285a37b6c2036 X-Filterd-Recvd-Size: 2047 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Wed, 19 Feb 2020 21:37:57 +0000 (UTC) Received: from X1 (nat-ab2241.sltdut.senawave.net [162.218.216.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1D35324654; Wed, 19 Feb 2020 21:37:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582148276; bh=LqBdh0ByniPKVAp/vH72blLOixC/W/Tawo3uAmF9q8Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nm3BhC6kYIQUThXMWGE8l1c3P0DgNzfePAltxMBUcgZQvPPHS7zH8mYo7UC8ktbIf j+8hMxChcBj4COThVBnScjWDc6pffG2ddU4W3GMUgYAnla4rJZSfgk7UhLno6vuxBU CbbgrdMA7xs3hYrLMtgt0ooeL7PREWmtxsK7z1jQ= Date: Wed, 19 Feb 2020 13:37:55 -0800 From: Andrew Morton To: glider@google.com Cc: walter-zh.wu@mediatek.com, dvyukov@google.com, gregkh@linuxfoundation.org, matthias.bgg@gmail.com, tglx@linutronix.de, jpoimboe@redhat.com, kstewart@linuxfoundation.org, linux-mm@kvack.org, penguin-kernel@i-love.sakura.ne.jp Subject: Re: [PATCH] lib/stackdepot: fix global out-of-bounds in stack_slabs Message-Id: <20200219133755.76ab3119665b654167af2ad1@linux-foundation.org> In-Reply-To: <20200218102950.260263-1-glider@google.com> References: <20200218102950.260263-1-glider@google.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 18 Feb 2020 11:29:50 +0100 glider@google.com wrote: > Walter Wu has reported a potential case in which init_stack_slab() is > called after stack_slabs[STACK_ALLOC_MAX_SLABS - 1] has already been > initialized. In that case init_stack_slab() will overwrite > stack_slabs[STACK_ALLOC_MAX_SLABS], which may result in a memory > corruption. I added cc:stable to this. Please let me know it that is undesirable.