From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C78ECC3404D for ; Wed, 19 Feb 2020 01:02:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7848F24655 for ; Wed, 19 Feb 2020 01:02:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N/mnf1Er" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7848F24655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 27ADE6B0006; Tue, 18 Feb 2020 20:02:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 22B196B0007; Tue, 18 Feb 2020 20:02:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16A376B0008; Tue, 18 Feb 2020 20:02:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0132.hostedemail.com [216.40.44.132]) by kanga.kvack.org (Postfix) with ESMTP id 005126B0006 for ; Tue, 18 Feb 2020 20:02:55 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B1BE8442A for ; Wed, 19 Feb 2020 01:02:55 +0000 (UTC) X-FDA: 76505077110.26.pies08_1987e07fd8624 X-HE-Tag: pies08_1987e07fd8624 X-Filterd-Recvd-Size: 4362 Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Wed, 19 Feb 2020 01:02:55 +0000 (UTC) Received: by mail-pj1-f68.google.com with SMTP id m13so1787561pjb.2 for ; Tue, 18 Feb 2020 17:02:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XjAe17WwACXa462Lft2fmmYSSdsBuO8CjnLHnDQfA9o=; b=N/mnf1Er4IIWBp/vNkC29mKZ4xdYtar5T1k0lCH0ra0Gvg4QEsfodG4yfbYjbIIVsA Ebxt5L+ceOQDzzgQ6ss86xHtREFi/atw695bOLYoGADEvvUHZWQrOn3GjpxgtI80l4nf dgcEwaDoUjgD8cKwpn2DT7SP55f/ZpeuEi9PesGyEYi75Cwkm8OrHffgemLfc21yIrJa aoXB10/qxrB2kTMZWy0pY/5Y9GD7DPniS0kC7A0ckCJxB0JvfOXv6RgEuMZymEVkCP3m VLplNEJHE/x8lhuA06ehV5xEjMvN7tIlS668+bwte2sjl1f4i9vAGiQlw7iV8BvcOPMa B0Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=XjAe17WwACXa462Lft2fmmYSSdsBuO8CjnLHnDQfA9o=; b=sqIyh/E+48cLbS2sRMIpCAK7HKSkR9YiOlxAd2aavybcYcOOZ0msJ4h4g1rEFSF3PG GG19UN6FiYX0osflMFCB3KHemQH0i5UutqdzjsnnPWeT7nbhVuIcsTpXuLEDP0BMslwJ VI2w7lIwX1TpL7t5lXBMdxAo3Ui4wDjjW2gQAO/U4BtHyJOx3JVZ/bRqLWkpW7+Nux4J BSQcPzSA8Q+5tWvHedCiGln5N/JvW8EuKxpgVjnUFJ/t+Bc+3c97zxWWevn732ytauQc ynz2MKrln73F/Uh1uDhfH+s6BpWn9r5YDK3BC4oj6UHJCHRykY4ZdZ/SqRuu+Cx+AKQ/ fFFw== X-Gm-Message-State: APjAAAWcAOPd2VunGzy/y5Q48USx8+ZbZ3oD0H/jtJhQXhryYE33odrv pGXDMz69/GK2oHOo6KqtM1k= X-Google-Smtp-Source: APXvYqw/93b9ec12Bht0Doaq2TFiyyatxu8H8/vw+iAKm+7XIR1dpiYwJce2oS3meL+K6eTrysEwfQ== X-Received: by 2002:a17:902:b110:: with SMTP id q16mr23061828plr.289.1582074174075; Tue, 18 Feb 2020 17:02:54 -0800 (PST) Received: from google.com ([2620:15c:211:1:3e01:2939:5992:52da]) by smtp.gmail.com with ESMTPSA id r9sm208768pfl.136.2020.02.18.17.02.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2020 17:02:52 -0800 (PST) Date: Tue, 18 Feb 2020 17:02:50 -0800 From: Minchan Kim To: Christoph Hellwig Cc: Andrew Morton , LKML , linux-mm , linux-api@vger.kernel.org, oleksandr@redhat.com, Suren Baghdasaryan , Tim Murray , Daniel Colascione , Sandeep Patil , Sonny Rao , Brian Geffon , Michal Hocko , Johannes Weiner , Shakeel Butt , John Dias , Joel Fernandes , sj38.park@gmail.com, alexander.h.duyck@linux.intel.com, Jann Horn , Christian Brauner Subject: Re: [PATCH v5 4/7] pid: export pidfd_get_pid Message-ID: <20200219010250.GB126504@google.com> References: <20200214170520.160271-1-minchan@kernel.org> <20200214170520.160271-5-minchan@kernel.org> <20200217075940.GA10342@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200217075940.GA10342@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Feb 16, 2020 at 11:59:40PM -0800, Christoph Hellwig wrote: > On Fri, Feb 14, 2020 at 09:05:17AM -0800, Minchan Kim wrote: > > process_madvise syscall needs pidfd_get_pid function to translate > > pidfd to pid so this patch exports the function. > > For that it should not need to exported, but then again the actual > patch doesn't export it anyway, so this is just a commit log issue. > > > extern struct pid *pidfd_pid(const struct file *file); > > +extern struct pid *pidfd_get_pid(unsigned int fd); > > ... and there is no need for the extern keyword on prototypes in > headers. Will fix new version. Thanks for the review!