From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8BDDC35254 for ; Mon, 17 Feb 2020 10:27:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 88C3A20725 for ; Mon, 17 Feb 2020 10:27:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="pTR/tzq9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88C3A20725 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 39FCC6B000C; Mon, 17 Feb 2020 05:27:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 377156B000D; Mon, 17 Feb 2020 05:27:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 266626B000E; Mon, 17 Feb 2020 05:27:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0077.hostedemail.com [216.40.44.77]) by kanga.kvack.org (Postfix) with ESMTP id 0FA7F6B000C for ; Mon, 17 Feb 2020 05:27:06 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id BE4BE2476 for ; Mon, 17 Feb 2020 10:27:05 +0000 (UTC) X-FDA: 76499241210.09.blade31_20c415e1fca34 X-HE-Tag: blade31_20c415e1fca34 X-Filterd-Recvd-Size: 4941 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Mon, 17 Feb 2020 10:27:05 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id d10so18225694ljl.9 for ; Mon, 17 Feb 2020 02:27:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZVl3yBWWm7MyQqJEcWXXzI1xt9p90ifeGv9DuPBNzAg=; b=pTR/tzq9m4PXx63b4TbTT6GWij0RLB4OJW9RvLUcWxI+tPq1LkgXzr414lQ6RNWJgS nb46suJtnt6XZcqKcVLGHopyrTNoC8KIXwASX7pHOIb8r+i7cGxE/grweun6/ZNlmXIk vgWhkzP7QlpVi/K3ZFTyrvhaUltEs906sU/6RvnNgxgVn4ganVg53mcd7y9geThqocag qGQTR/RBoGQTjXeaKkk6NobmH4sjudZsh/JlJjKxk/uBLiKWmo/5hZBIz2DwN15uUtfM dUPNoRV9dnigmvy63DE+Y8Fg07St2R8izgj1Jl2F582qcuRxr57Eif0X7V1oAmewYYrc NveQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZVl3yBWWm7MyQqJEcWXXzI1xt9p90ifeGv9DuPBNzAg=; b=W8ZZLQcz9IOpb16ZWJi0Xw9r9gF/EDtk9jJMn5i44QXv8QGQZROrV17xwsIKjxM5Gy tzHC29WXaY3uM0URBVOU+SGXibrFxIAJfCATi4hGSR1M5hs8KpUdNgmVWHHe8LfzjqBT yqw9RuG3ZpUzOOODbOqWrTQacV6wS1huRWE9IjI038QpfUpB2e/7qH/kUhHghCjh+87u 71KI+42ioNM6M9o0h+9VdgJjd9BR+hSaRMSnGfZpoFv4D8/1MqpxHy+1eawLluZi3QL3 PqgqNrpqzjHlJjyfJujxQnoEMmZWeVV5/Pc9TtZzciKp4YJ20BSv3UHjp8wSf4KCLBCG JKdQ== X-Gm-Message-State: APjAAAWpfz3z+7Q5+kWbu52Fxnz2H6ZQy72vmOdXhHEWXx1epPoo2EAw /eyf2MWEW0XvO2JOuuXVg96Iuw== X-Google-Smtp-Source: APXvYqy/hXXiB9yxXp02xHbKZSUay4iWke71ToKoCypS+ZInT1oZHxH8Fgns9tAwgIOlH7ZCC6nlpg== X-Received: by 2002:a2e:9d3:: with SMTP id 202mr9648045ljj.60.1581935223504; Mon, 17 Feb 2020 02:27:03 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id m24sm113416ljb.81.2020.02.17.02.27.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2020 02:27:02 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id 8820B100F93; Mon, 17 Feb 2020 13:27:27 +0300 (+03) Date: Mon, 17 Feb 2020 13:27:27 +0300 From: "Kirill A. Shutemov" To: Anshuman Khandual Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Sudeep Dutt , Ashutosh Dixit , Arnd Bergmann , Greg Kroah-Hartman , Thomas Gleixner , Kate Stewart , Allison Randal , Richard Fontana Subject: Re: [PATCH 4/5] mm/vma: Replace all remaining open encodings with vma_set_anonymous() Message-ID: <20200217102727.cmd74il6nxfgzvkh@box> References: <1581915833-21984-1-git-send-email-anshuman.khandual@arm.com> <1581915833-21984-5-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1581915833-21984-5-git-send-email-anshuman.khandual@arm.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 17, 2020 at 10:33:52AM +0530, Anshuman Khandual wrote: > This replaces all remaining open encodings with vma_set_anonymous(). > > Cc: Sudeep Dutt > Cc: Ashutosh Dixit > Cc: Arnd Bergmann > Cc: Greg Kroah-Hartman > Cc: Thomas Gleixner > Cc: Kate Stewart > Cc: Allison Randal > Cc: Richard Fontana > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > drivers/misc/mic/scif/scif_mmap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/misc/mic/scif/scif_mmap.c b/drivers/misc/mic/scif/scif_mmap.c > index a151d416f39c..1f0dec5df994 100644 > --- a/drivers/misc/mic/scif/scif_mmap.c > +++ b/drivers/misc/mic/scif/scif_mmap.c > @@ -580,7 +580,7 @@ static void scif_munmap(struct vm_area_struct *vma) > * The kernel probably zeroes these out but we still want > * to clean up our own mess just in case. > */ > - vma->vm_ops = NULL; > + vma_set_anonymous(vma); > vma->vm_private_data = NULL; > kref_put(&vmapvt->ref, vma_pvt_release); > scif_delete_vma(ep, vma); This is misleading. The VMA doesn't become anonymous here. This is undo of the previously overwritten vm_ops. I think we should leave it opencodded. -- Kirill A. Shutemov