From: David Miller <davem@davemloft.net>
To: jhubbard@nvidia.com
Cc: akpm@linux-foundation.org, santosh.shilimkar@oracle.com,
hans.westgaard.ry@oracle.com, leonro@mellanox.com,
kuba@kernel.org, netdev@vger.kernel.org,
rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] net/rds: Track user mapped pages through special API
Date: Sun, 16 Feb 2020 18:37:31 -0800 (PST) [thread overview]
Message-ID: <20200216.183731.2157450869886971370.davem@davemloft.net> (raw)
In-Reply-To: <20200212030355.1600749-2-jhubbard@nvidia.com>
From: John Hubbard <jhubbard@nvidia.com>
Date: Tue, 11 Feb 2020 19:03:55 -0800
> From: Leon Romanovsky <leonro@mellanox.com>
>
> Convert net/rds to use the newly introduces pin_user_pages() API,
> which properly sets FOLL_PIN. Setting FOLL_PIN is now required for
> code that requires tracking of pinned pages.
>
> Note that this effectively changes the code's behavior: it now
> ultimately calls set_page_dirty_lock(), instead of set_page_dirty().
> This is probably more accurate.
>
> As Christoph Hellwig put it, "set_page_dirty() is only safe if we are
> dealing with a file backed page where we have reference on the inode it
> hangs off." [1]
>
> [1] https://lore.kernel.org/r/20190723153640.GB720@lst.de
>
> Cc: Hans Westgaard Ry <hans.westgaard.ry@oracle.com>
> Cc: Santosh Shilimkar <santosh.shilimkar@oracle.com>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Applied, thank you.
prev parent reply other threads:[~2020-02-17 2:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-12 3:03 [PATCH 0/1] " John Hubbard
2020-02-12 3:03 ` [PATCH 1/1] " John Hubbard
2020-02-12 17:31 ` santosh.shilimkar
2020-02-12 17:51 ` Leon Romanovsky
2020-02-12 17:55 ` santosh.shilimkar
2020-02-17 2:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200216.183731.2157450869886971370.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=hans.westgaard.ry@oracle.com \
--cc=jhubbard@nvidia.com \
--cc=kuba@kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox