From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93EBBC35242 for ; Fri, 14 Feb 2020 20:48:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3C65F22314 for ; Fri, 14 Feb 2020 20:48:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NI93lBS7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3C65F22314 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E27CB6B067C; Fri, 14 Feb 2020 15:48:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DFEE96B067D; Fri, 14 Feb 2020 15:48:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA1C26B067E; Fri, 14 Feb 2020 15:48:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0008.hostedemail.com [216.40.44.8]) by kanga.kvack.org (Postfix) with ESMTP id B15536B067C for ; Fri, 14 Feb 2020 15:48:38 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 52485440B for ; Fri, 14 Feb 2020 20:48:38 +0000 (UTC) X-FDA: 76489921116.09.laugh23_2e432571d3d06 X-HE-Tag: laugh23_2e432571d3d06 X-Filterd-Recvd-Size: 3877 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by imf49.hostedemail.com (Postfix) with ESMTP for ; Fri, 14 Feb 2020 20:48:37 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id a9so12158691wmj.3 for ; Fri, 14 Feb 2020 12:48:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bs4/bf84KxBp5/3poh+gEqXOl2zy3ub1/mKAWorwRIA=; b=NI93lBS7foSOICH/i6FnoY1Z5JYyX+EOlYr53ZqS9bz7YRxq1HPVtoNdtH6fEOtdQy W2a8rnBp72IOANP6gV3abM2WRAaXb2rtkYd6apcvVhBix2UkkR6jOmqio6k3dvNrA2vM QP0X6kiWAWBrkhQBhPLaazQ4ewO0y1oSoUC8NVcoUY3nNSWU924P8WJBkky3HzTl+gZ0 aKttciIYEo1BLqZ9cdWC653TkY+Uk3MvquTu+dZ9NeAA8KcPGhbh3+t30jYAR7ELxI97 3t+rgkpzyrMOmt4fQiLVbwvOJ5HwqQQSueCw5gSTG5U6QSRmlx2CgL9Noctb4hbxEwuK QxEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bs4/bf84KxBp5/3poh+gEqXOl2zy3ub1/mKAWorwRIA=; b=fHsw+jNNn541lqGDLLkAHGo6lxemJcBE0h/UlNFZzG1B5Ev70y1JOPJ7G0Oz12lfNU Xgyi18dh8vnX9jwFwYveMdyFR5HazMSDjOsQvPLKwPufJNI6AZbPvi73k4d/stfXnz5J hHpuCjvAtgRYqwJoU2LR/8D4xpuqdn6iSYsDgoYPUHTtDggRltmiPa+NFKxqXNA7L+Ss GUejBPSY0zQ7b8IqgpB/d7Df8X7CW5ccf0aN3ohfLiHjq5yYXC+/gRECnyrvakBzjxp9 s2xaAOtBb1XXioOMqJpYRqD+Orym209sWp9jRiu7ToATOo+c4yVFzCVrLgB3iQJlof9h JK/A== X-Gm-Message-State: APjAAAWkeQiYdYTEQT3cARehenOsnjkPgBUavU1i6JXDQwkTwPCmQBAY 7UjwQee1ZN68tCpSnLADXw== X-Google-Smtp-Source: APXvYqxddI/rx1H/gt7+BYJb7sy1tT+1CI0Zml46G1dOyf9pi32VG/CVm3wL/lgpJ4KOEVBi2OQw8g== X-Received: by 2002:a1c:988c:: with SMTP id a134mr6194261wme.163.1581713316795; Fri, 14 Feb 2020 12:48:36 -0800 (PST) Received: from ninjahost.lan (host-2-102-13-223.as13285.net. [2.102.13.223]) by smtp.googlemail.com with ESMTPSA id y12sm8660782wmj.6.2020.02.14.12.48.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2020 12:48:36 -0800 (PST) From: Jules Irenge To: linux-kernel@vger.kernel.org Cc: boqun.feng@gmail.com, Jules Irenge , Andrew Morton , linux-mm@kvack.org (open list:MEMORY MANAGEMENT) Subject: [PATCH 05/30] mm/compaction: Add missing annotation for compact_lock_irqsave Date: Fri, 14 Feb 2020 20:47:16 +0000 Message-Id: <20200214204741.94112-6-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200214204741.94112-1-jbi.octave@gmail.com> References: <0/30> <20200214204741.94112-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.054282, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Sparse reports a warning at compact_lock_irqsave() warning: context imbalance in compact_lock_irqsave() - wrong count at exi= t The root cause is the missing annotation at compact_lock_irqsave() Add the missing __acquires(lock) annotation. Signed-off-by: Jules Irenge --- mm/compaction.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/compaction.c b/mm/compaction.c index 672d3c78c6ab..81190fe22200 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -481,6 +481,7 @@ static bool test_and_set_skip(struct compact_control = *cc, struct page *page, */ static bool compact_lock_irqsave(spinlock_t *lock, unsigned long *flags, struct compact_control *cc) + __acquires(lock) { /* Track if the lock is contended in async mode */ if (cc->mode =3D=3D MIGRATE_ASYNC && !cc->contended) { --=20 2.24.1