From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9DB0C35242 for ; Fri, 14 Feb 2020 20:48:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A07532465D for ; Fri, 14 Feb 2020 20:48:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LQmAqdXs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A07532465D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 23EC26B067A; Fri, 14 Feb 2020 15:48:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F0256B067B; Fri, 14 Feb 2020 15:48:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 105FD6B067C; Fri, 14 Feb 2020 15:48:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0077.hostedemail.com [216.40.44.77]) by kanga.kvack.org (Postfix) with ESMTP id EB2756B067A for ; Fri, 14 Feb 2020 15:48:33 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8A06E824556B for ; Fri, 14 Feb 2020 20:48:33 +0000 (UTC) X-FDA: 76489920906.09.farm45_2d962594fa602 X-HE-Tag: farm45_2d962594fa602 X-Filterd-Recvd-Size: 3981 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Fri, 14 Feb 2020 20:48:33 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id q9so11329822wmj.5 for ; Fri, 14 Feb 2020 12:48:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MxFia235IPfyDDQlAzkqDLsg9ubjwppF/aCVODUQpIw=; b=LQmAqdXsML9wsGoHcSXgEQKuW22UvhWB3+YmPOoYpcyRKxaOGFw0sRsTP9S1LqiUJs bdsMK4EoopXxGlZUwb5tH6yhMXvxDXEvIQq0P3OJ7pJ+VUOCLL6h8qqNmWZkkHV8jd2B 1PhOxvOSceedwzfZhc1p6KFkG61AKHWLd7YlXmPxB3eui8YNbKH7ZKysXnA3grvN2DPr 5xiZKGTjCF8BDVemAY801rVDRcQYRMPd0VTq94+/OgqF6v/MMx6sDmijersbj2IOL24G jX75Cehb1X7k4z/9fQm2tRVySdwmPUX3i1ViH0YaL7oGqVOinBrh+hxbU8SAhgKB/BSK EQng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MxFia235IPfyDDQlAzkqDLsg9ubjwppF/aCVODUQpIw=; b=gVNZCwP9s70AWAh/hQakDlW5VswNh+Mli5xczCoIBlixVOoCh3EhwslfVumnVoOujW IuEGfgLY0uqmaHC6jXR46orndCz5yTiJnLmOTuwfCCf2gprV+tuRLIL1qYrkvfBByao7 boOL6SnkjfAiSgSnDMLsQ87EaU3C8UrYIWubwP8Qb0w8VM1p2gq1s2A6Qqk5mIi7dlZC x7uFSElRFuUB/80keDcXC/NPceGI1tuY4C7xoRnp8t/yeI2Pb9MPlBk5fL6Ghl0wza1i iiv9w8IdGGiQPDS7v4bF2NtykCjFp2SRNh9jYzBjqFTirs10BK0cop32vQs9Cx175dNP XF0g== X-Gm-Message-State: APjAAAVXytUcp9gAAzFW1DoylfW1zdclpMo+ijPRoZHeBd+Su2weRoVY TUCCFipZn/js660eXExnCw== X-Google-Smtp-Source: APXvYqxF8g88uOOKmgJxcxdDJrerXQURWrjGk+r+5cHlvZaRVE7gv8/riqrZWRwVhUht96zKhugSAw== X-Received: by 2002:a7b:cbc8:: with SMTP id n8mr6474084wmi.35.1581713311936; Fri, 14 Feb 2020 12:48:31 -0800 (PST) Received: from ninjahost.lan (host-2-102-13-223.as13285.net. [2.102.13.223]) by smtp.googlemail.com with ESMTPSA id y12sm8660782wmj.6.2020.02.14.12.48.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2020 12:48:31 -0800 (PST) From: Jules Irenge To: linux-kernel@vger.kernel.org Cc: boqun.feng@gmail.com, Jules Irenge , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , cgroups@vger.kernel.org (open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)), linux-mm@kvack.org (open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)) Subject: [PATCH 03/30] mm/memcontrol: Add missing annotation for unlock_page_lru() Date: Fri, 14 Feb 2020 20:47:14 +0000 Message-Id: <20200214204741.94112-4-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200214204741.94112-1-jbi.octave@gmail.com> References: <0/30> <20200214204741.94112-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Sparse reports warning at unlock_page_lry() warning: context imbalance in unlock_page_lru() - unexpected unlock The root cause is the missing annotation at unlock_page_lru() Add the missing __releases(&pgdat->lru_lock) Signed-off-by: Jules Irenge --- mm/memcontrol.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 6f6dc8712e39..22ddd557a69b 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -2587,6 +2587,7 @@ static void lock_page_lru(struct page *page, int *i= solated) } =20 static void unlock_page_lru(struct page *page, int isolated) + __releases(&pgdat->lru_lock) { pg_data_t *pgdat =3D page_pgdat(page); =20 --=20 2.24.1