From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EC65C35242 for ; Fri, 14 Feb 2020 20:48:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EF98D22314 for ; Fri, 14 Feb 2020 20:48:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IH965hYm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF98D22314 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4129B6B0681; Fri, 14 Feb 2020 15:48:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C34A6B0682; Fri, 14 Feb 2020 15:48:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2DC076B0683; Fri, 14 Feb 2020 15:48:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0078.hostedemail.com [216.40.44.78]) by kanga.kvack.org (Postfix) with ESMTP id 156176B0681 for ; Fri, 14 Feb 2020 15:48:46 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B496A49961A for ; Fri, 14 Feb 2020 20:48:45 +0000 (UTC) X-FDA: 76489921410.10.birds00_2f5a98ccab35e X-HE-Tag: birds00_2f5a98ccab35e X-Filterd-Recvd-Size: 3935 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Fri, 14 Feb 2020 20:48:45 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id g3so12445886wrs.12 for ; Fri, 14 Feb 2020 12:48:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fYMUoir6P369DFUPvjd9IwSNVlH2uDcEsa0cDBpYLmc=; b=IH965hYmyOF45cvMjEbRiDZZHOfl7fOe2Zt2qY2QXjTrD5vr4E5o4ASz8NwEfLdoyf 8QJ2ggGHOVmUtDfg+vWAdH5Q2dGsRU1nSYUITlgpiO7Rh2xI/Qa6qPAriZdxx4Ed8lhP M62ffg9W1oDsfpS6MIGSI576dgmdWMpUEGvDIWrmdHObOhZiFkh0PNnuBdtD5l17XqZu Ut+cb9B8iSuqnnhoEYEkasVH9Vh4zT/JL3p9zadH9BwHaUTKi6F+SlpuvmmweEK8szLn ipvYMQPdKaczrekBAqMiz+3LYbwNKeIeRsrSTjbQvwT0dltW8NTNL6ZkifJDrLLE1gro J9WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fYMUoir6P369DFUPvjd9IwSNVlH2uDcEsa0cDBpYLmc=; b=ZItoeGI4xRve1qGUPYL47TbZQ8277h3tNWaplsauFTSdvxqODt8zJDPh2E8D3gl1OQ EEwohUVonrwwXPWM9zHOyHfdLYrEGsnXdplxWjSdHSToDxqcYcQfb45H0sIXMmhpcUna P4hay0wn8FD5mzsSQxnvBJFbFwMK+099ca2HJN0MTMCHg99t6tQ9F4/CsrzwVUkqupWF ffD43F2Dkj5dXs7rTiSZhqUeg4wTXnf1CEu8bOf7InXtVuqjqQv9fNO08QZ7bQzSBNZa EF6kT8UR2m/stgaYSoMIms5zdHVc0p0bF9j6r6LKAOreR4W7vG+wMLp/lJqY5R++slTG DUVg== X-Gm-Message-State: APjAAAV7vWnRd4QCE5KmSUT2O4hqn503L7zw9oYMx3FzBibDBW7R6uM6 p2QkY3EwXqsSi6xOcBXRig== X-Google-Smtp-Source: APXvYqw/O96To8bCrgkPpvj8JepZ3NSkL1ul2b+UKRpE5VHbikhxIVb/2uqKJmL9Jlv+6W9sjjD/Bw== X-Received: by 2002:a5d:4085:: with SMTP id o5mr5687888wrp.321.1581713324201; Fri, 14 Feb 2020 12:48:44 -0800 (PST) Received: from ninjahost.lan (host-2-102-13-223.as13285.net. [2.102.13.223]) by smtp.googlemail.com with ESMTPSA id y12sm8660782wmj.6.2020.02.14.12.48.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Feb 2020 12:48:43 -0800 (PST) From: Jules Irenge To: linux-kernel@vger.kernel.org Cc: boqun.feng@gmail.com, Jules Irenge , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , linux-mm@kvack.org (open list:SLAB ALLOCATOR) Subject: [PATCH 09/30] mm/slub: Add missing annotation for put_map() Date: Fri, 14 Feb 2020 20:47:20 +0000 Message-Id: <20200214204741.94112-10-jbi.octave@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200214204741.94112-1-jbi.octave@gmail.com> References: <0/30> <20200214204741.94112-1-jbi.octave@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Sparse reports a warning at put_map()() warning: context imbalance in put_map() - unexpected unlock The root cause is the missing annotation at put_map() Add the missing __releases(&object_map_lock) annotation Signed-off-by: Jules Irenge --- mm/slub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/slub.c b/mm/slub.c index 3c6d348afcf9..c273d0f32b8f 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -466,7 +466,7 @@ static unsigned long *get_map(struct kmem_cache *s, s= truct page *page) return object_map; } =20 -static void put_map(unsigned long *map) +static void put_map(unsigned long *map) __releases(&object_map_lock) { VM_BUG_ON(map !=3D object_map); lockdep_assert_held(&object_map_lock); --=20 2.24.1