From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC858C3B18F for ; Fri, 14 Feb 2020 04:21:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6B8382168B for ; Fri, 14 Feb 2020 04:21:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ek5FlmUJ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B8382168B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CEA836B05EB; Thu, 13 Feb 2020 23:21:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C9CD36B05ED; Thu, 13 Feb 2020 23:21:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB15E6B05EE; Thu, 13 Feb 2020 23:21:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0083.hostedemail.com [216.40.44.83]) by kanga.kvack.org (Postfix) with ESMTP id A01D16B05EB for ; Thu, 13 Feb 2020 23:21:43 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 4EE011F0A for ; Fri, 14 Feb 2020 04:21:43 +0000 (UTC) X-FDA: 76487434086.14.pin86_efbb8fd97e05 X-HE-Tag: pin86_efbb8fd97e05 X-Filterd-Recvd-Size: 2588 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Fri, 14 Feb 2020 04:21:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pJ62j82nIU2Zy2GDXfwdfrwos2PK4U7hpjBMCZD+BHU=; b=ek5FlmUJYVH7TpMGN0UDhdbdlP ZpmOzXocMxVA9d+jNFuPudLwDNy8swGrQKmqAV1aNIqgz+vUnuTGmNlYmgpVvtLBxVCCQf/xRgUQe aYNfvPrXmq2c9txws9vk9GMvkDWjdJajzfqJTNG4wpo2D6zNpxIMcEYsw/Uzmu6+fgNlhK+Z6xcqv U2oZdCKEAQQi7TpP6smp3l+MpsP/IBWp0Zr5Q7SQ0ag+jo6r6bu7CUU385j6YfQ+3UbG2m+R8CiIP hMY9ekNVlTY1SfacIa6TX8hjMg1KzbNePDpc9q0x1IrQoqCtQgquJiQia27l1b496aVFYOc5RO091 699nobpA==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2STx-0008Ig-7x; Fri, 14 Feb 2020 04:21:37 +0000 Date: Thu, 13 Feb 2020 20:21:37 -0800 From: Matthew Wilcox To: John Hubbard Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, ocfs2-devel@oss.oracle.com, linux-xfs@vger.kernel.org Subject: Re: [PATCH v5 01/13] mm: Fix the return type of __do_page_cache_readahead Message-ID: <20200214042137.GX7778@bombadil.infradead.org> References: <20200211010348.6872-1-willy@infradead.org> <20200211010348.6872-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 13, 2020 at 07:19:53PM -0800, John Hubbard wrote: > On 2/10/20 5:03 PM, Matthew Wilcox wrote: > > @@ -161,7 +161,7 @@ unsigned int __do_page_cache_readahead(struct address_space *mapping, > > unsigned long end_index; /* The last page we want to read */ > > LIST_HEAD(page_pool); > > int page_idx; > > > What about page_idx, too? It should also have the same data type as nr_pages, as long as > we're trying to be consistent on this point. > > Just want to ensure we're ready to handle those 2^33+ page readaheads... :) Nah, this is just a type used internally to the function. Getting the API right for the callers is the important part.