From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C683C35242 for ; Fri, 14 Feb 2020 05:41:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4A847217F4 for ; Fri, 14 Feb 2020 05:41:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="QPhY4Ax4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A847217F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E84656B05F7; Fri, 14 Feb 2020 00:41:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E3C746B05F9; Fri, 14 Feb 2020 00:41:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D49FD6B05FA; Fri, 14 Feb 2020 00:41:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id BB1F66B05F7 for ; Fri, 14 Feb 2020 00:41:12 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 433A2246E for ; Fri, 14 Feb 2020 05:41:12 +0000 (UTC) X-FDA: 76487634384.04.balls26_7ee32ab041d2e X-HE-Tag: balls26_7ee32ab041d2e X-Filterd-Recvd-Size: 1832 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Fri, 14 Feb 2020 05:41:11 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 31ABC2067D; Fri, 14 Feb 2020 05:41:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581658871; bh=8942/va+rO3hXTcvyrc4Jv5bl51pvILNPbmTxkFsLIE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QPhY4Ax43TuHqz74hiR/gmPsyhpAWHoKizZnf0cf+iDjtWRLvfgfbExV29P1OPY7q +CVG6XDxGLlNoxyuKWzGrkcfLDJI5LFaILqcLqxrreTC0uCpnkhvlg/lgwEXNs5ie9 pIKmn5t1J71w/OPupaZPV69EHm2wNzWALcYkVPuc= Date: Thu, 13 Feb 2020 21:41:10 -0800 From: Andrew Morton To: Matthew Wilcox Cc: linux-mm@kvack.org Subject: Re: [PATCH] include: Remove highmem.h from pagemap.h Message-Id: <20200213214110.b672811dc324c0f8a61225f8@linux-foundation.org> In-Reply-To: <20200213195643.31587-1-willy@infradead.org> References: <20200213195643.31587-1-willy@infradead.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 13 Feb 2020 11:56:43 -0800 Matthew Wilcox wrote: > pagemap.h doesn't need highmem.h itself. Only two dozen users were > relying on pagemap to pull in highmem (usually for kmap), so fix them > all up and we can remove this header file dependency. Three compilation errors in an x86_64 allnoconfig build. This one will need a lot more testing, please.