From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22A1EC2BA83 for ; Thu, 13 Feb 2020 16:36:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E251C24676 for ; Thu, 13 Feb 2020 16:36:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E251C24676 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7A94C6B056E; Thu, 13 Feb 2020 11:36:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 75A5A6B056F; Thu, 13 Feb 2020 11:36:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 647216B0570; Thu, 13 Feb 2020 11:36:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0212.hostedemail.com [216.40.44.212]) by kanga.kvack.org (Postfix) with ESMTP id 49A896B056E for ; Thu, 13 Feb 2020 11:36:41 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id F24A833CD for ; Thu, 13 Feb 2020 16:36:40 +0000 (UTC) X-FDA: 76485657360.27.berry35_74802926e8337 X-HE-Tag: berry35_74802926e8337 X-Filterd-Recvd-Size: 4293 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Thu, 13 Feb 2020 16:36:40 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id w12so7501238wrt.2 for ; Thu, 13 Feb 2020 08:36:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lmfQ+P5qqT40a5iQ7iRjjbaHXUizOe4fBlQ/eH9eBdY=; b=H4x29jKze97pesfVSIqa/f++5umddWiXW+4Bz9i+sfbLakUg+Egb3IxCk27trksNEP ae3io7Pc2n5NrhrGfqWcNVdbf9J4oF4p1CZmF+X7SAM+U+qJoVllLN9lP6TWwlB7y8tP gSpeLJgDB3Eotkyx7lxJThSi2cafd7Rub2YB5hCMvk1fNKYokBFcU8PtWiVKjFi4Hux7 d7VqPgVhzYh1p+KeldDrbZhPBDz0Ey/zMZID+GnGo7uGyX1ggE+y573F/nodMjwTfIxr 4r//7dM8CTkPDQSRReUOq9rEdwWNsbN50+rlZXBaQt0aNWX7z05XnOw20vhN+aInevZE tX8g== X-Gm-Message-State: APjAAAVgGkUFGrfYoVaazshUu86hTea6WosF1VGn7jadUsVnjpg2GuWU 8tet2ruUURhtV8di95FfUVk= X-Google-Smtp-Source: APXvYqx9OeOJFs7+oXJ+VHrtubnIYIroyeFz0+EmF8royFusQStAvQZ+cr2PQiveNWcbVmmpP2Nk5A== X-Received: by 2002:adf:c453:: with SMTP id a19mr22819198wrg.341.1581611799518; Thu, 13 Feb 2020 08:36:39 -0800 (PST) Received: from localhost (ip-37-188-133-87.eurotel.cz. [37.188.133.87]) by smtp.gmail.com with ESMTPSA id b11sm3567835wrx.89.2020.02.13.08.36.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Feb 2020 08:36:38 -0800 (PST) Date: Thu, 13 Feb 2020 17:36:36 +0100 From: Michal Hocko To: Tejun Heo Cc: Johannes Weiner , Andrew Morton , Roman Gushchin , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH v2 3/3] mm: memcontrol: recursive memory.low protection Message-ID: <20200213163636.GH31689@dhcp22.suse.cz> References: <20191219200718.15696-1-hannes@cmpxchg.org> <20191219200718.15696-4-hannes@cmpxchg.org> <20200130170020.GZ24244@dhcp22.suse.cz> <20200203215201.GD6380@cmpxchg.org> <20200211164753.GQ10636@dhcp22.suse.cz> <20200212170826.GC180867@cmpxchg.org> <20200213074049.GA31689@dhcp22.suse.cz> <20200213135348.GF88887@mtj.thefacebook.com> <20200213154731.GE31689@dhcp22.suse.cz> <20200213155249.GI88887@mtj.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200213155249.GI88887@mtj.thefacebook.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 13-02-20 10:52:49, Tejun Heo wrote: > Hello, > > On Thu, Feb 13, 2020 at 04:47:31PM +0100, Michal Hocko wrote: > > Well, I would tend to agree but I can see an existing cgroup hierarchy > > imposed by systemd and that is more about "logical" organization of > > processes based on their purpose than anything resembling resources. > > So what can we do about that to make it all work? > > systemd right now isn't configuring any resource control by default, > so I'm not sure why it is relevant in this discussion. AFAIK systemd already offers knobs to configure resource controls [1]. Besides that we are talking about memcg features which are available only unified hieararchy and that is what systemd is using already. > You gotta > change the layout to configure resource control no matter what and > it's pretty easy to do. systemd folks are planning to integrate higher > level resource control features, so my expectation is that the default > layout is gonna change as it develops. Do you have any pointers to those discussions? I am not really following systemd development. Anyway, I am skeptical that systemd can do anything much more clever than placing cgroups with a resource control under the root cgroup. At least not without some tagging which workloads are somehow related. That being said, I do not really blame systemd here. We are not making their life particularly easy TBH. [1] https://www.freedesktop.org/software/systemd/man/systemd.resource-control.html -- Michal Hocko SUSE Labs