From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10540C3F68F for ; Thu, 13 Feb 2020 00:48:06 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C536921734 for ; Thu, 13 Feb 2020 00:48:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=axtens.net header.i=@axtens.net header.b="gfQ7jmAP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C536921734 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=axtens.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 651766B04E9; Wed, 12 Feb 2020 19:48:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6048F6B04EB; Wed, 12 Feb 2020 19:48:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F04D6B04EC; Wed, 12 Feb 2020 19:48:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0237.hostedemail.com [216.40.44.237]) by kanga.kvack.org (Postfix) with ESMTP id 35C386B04E9 for ; Wed, 12 Feb 2020 19:48:05 -0500 (EST) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id EC8F7180AD80F for ; Thu, 13 Feb 2020 00:48:04 +0000 (UTC) X-FDA: 76483266888.29.beds83_80b3208aa3110 X-HE-Tag: beds83_80b3208aa3110 X-Filterd-Recvd-Size: 5884 Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Thu, 13 Feb 2020 00:48:04 +0000 (UTC) Received: by mail-pj1-f68.google.com with SMTP id n96so1598530pjc.3 for ; Wed, 12 Feb 2020 16:48:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axtens.net; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0eDFn39gIg7xtZfHp4ELa6UyXk2yfoJL9wFZ1T547PE=; b=gfQ7jmAPlbpmhzAIID5d2fNUOceU9hDBNozIWvphDvthQUJkhkpGjdeeaYh8jy4R4x 4HtWt4dB511vA2Zb1Jc3cFPJlscaf+e7+9qrqe6ss8ieF3GII/q2PmR4XfxPgZ8wKcBG X+aZYYMfZ8Gu9E7JiwEgOfnZRjGT75dizxn2Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0eDFn39gIg7xtZfHp4ELa6UyXk2yfoJL9wFZ1T547PE=; b=MbUaX1+aJLmCeWZLUgT5iJbJBunDSYAcX2lUyN8eiVqWj8nQIfWVSZSfh74Syij9/M QwPtgoPtNe7/L4JUWGR015Z09bH7Y4YhlCoOCvdUaYkCxv8ItFq+2JX1zGMDwK1iPurP j59l2yCEFybVoqPFi76J0ebfnbTI6fQMMjg/yDmBVyit3G4HqmEI3F5R6J0BF2kyM/3U c1TWThudTPngObtwHUbrXp7YY+PoecmVdxRVzNx+OrQxRS5rG51qdoggeHoAtAU490Tj Mi2weiF4QS1p2LEZ0HywrRyQhqLtDL82kEJXtEaSk4knhh/jq5Kk0cuZhglvyTcf/qFU Fw3Q== X-Gm-Message-State: APjAAAUQfEUcKV3JGGPmP9wqtILP4ME9Mx0G6qQniXVUUofO5jo+uOuX c1ijJQA7qkWtKBtPrCzpGY5FnQ== X-Google-Smtp-Source: APXvYqwHvAKcYhQDHC3QmWNmwB5k9zQRIpFARpkceN2Ky58cYo5dxd7faOt/H3zC22zwPKoclLvWVA== X-Received: by 2002:a17:902:9f98:: with SMTP id g24mr11134599plq.325.1581554883272; Wed, 12 Feb 2020 16:48:03 -0800 (PST) Received: from localhost (2001-44b8-1113-6700-f1ea-0ab5-027b-8841.static.ipv6.internode.on.net. [2001:44b8:1113:6700:f1ea:ab5:27b:8841]) by smtp.gmail.com with ESMTPSA id l29sm297624pgb.86.2020.02.12.16.48.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2020 16:48:02 -0800 (PST) From: Daniel Axtens To: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, kasan-dev@googlegroups.com, christophe.leroy@c-s.fr, aneesh.kumar@linux.ibm.com, bsingharora@gmail.com Cc: Daniel Axtens Subject: [PATCH v7 1/4] kasan: define and use MAX_PTRS_PER_* for early shadow tables Date: Thu, 13 Feb 2020 11:47:49 +1100 Message-Id: <20200213004752.11019-2-dja@axtens.net> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200213004752.11019-1-dja@axtens.net> References: <20200213004752.11019-1-dja@axtens.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: powerpc has a variable number of PTRS_PER_*, set at runtime based on the MMU that the kernel is booted under. This means the PTRS_PER_* are no longer constants, and therefore breaks the build. Define default MAX_PTRS_PER_*s in the same style as MAX_PTRS_PER_P4D. As KASAN is the only user at the moment, just define them in the kasan header, and have them default to PTRS_PER_* unless overridden in arch code. Suggested-by: Christophe Leroy Suggested-by: Balbir Singh Reviewed-by: Christophe Leroy Reviewed-by: Balbir Singh Signed-off-by: Daniel Axtens --- include/linux/kasan.h | 18 +++++++++++++++--- mm/kasan/init.c | 6 +++--- 2 files changed, 18 insertions(+), 6 deletions(-) diff --git a/include/linux/kasan.h b/include/linux/kasan.h index 5cde9e7c2664..b3a4500633f5 100644 --- a/include/linux/kasan.h +++ b/include/linux/kasan.h @@ -14,10 +14,22 @@ struct task_struct; #include #include =20 +#ifndef MAX_PTRS_PER_PTE +#define MAX_PTRS_PER_PTE PTRS_PER_PTE +#endif + +#ifndef MAX_PTRS_PER_PMD +#define MAX_PTRS_PER_PMD PTRS_PER_PMD +#endif + +#ifndef MAX_PTRS_PER_PUD +#define MAX_PTRS_PER_PUD PTRS_PER_PUD +#endif + extern unsigned char kasan_early_shadow_page[PAGE_SIZE]; -extern pte_t kasan_early_shadow_pte[PTRS_PER_PTE]; -extern pmd_t kasan_early_shadow_pmd[PTRS_PER_PMD]; -extern pud_t kasan_early_shadow_pud[PTRS_PER_PUD]; +extern pte_t kasan_early_shadow_pte[MAX_PTRS_PER_PTE]; +extern pmd_t kasan_early_shadow_pmd[MAX_PTRS_PER_PMD]; +extern pud_t kasan_early_shadow_pud[MAX_PTRS_PER_PUD]; extern p4d_t kasan_early_shadow_p4d[MAX_PTRS_PER_P4D]; =20 int kasan_populate_early_shadow(const void *shadow_start, diff --git a/mm/kasan/init.c b/mm/kasan/init.c index ce45c491ebcd..8b54a96d3b3e 100644 --- a/mm/kasan/init.c +++ b/mm/kasan/init.c @@ -46,7 +46,7 @@ static inline bool kasan_p4d_table(pgd_t pgd) } #endif #if CONFIG_PGTABLE_LEVELS > 3 -pud_t kasan_early_shadow_pud[PTRS_PER_PUD] __page_aligned_bss; +pud_t kasan_early_shadow_pud[MAX_PTRS_PER_PUD] __page_aligned_bss; static inline bool kasan_pud_table(p4d_t p4d) { return p4d_page(p4d) =3D=3D virt_to_page(lm_alias(kasan_early_shadow_pu= d)); @@ -58,7 +58,7 @@ static inline bool kasan_pud_table(p4d_t p4d) } #endif #if CONFIG_PGTABLE_LEVELS > 2 -pmd_t kasan_early_shadow_pmd[PTRS_PER_PMD] __page_aligned_bss; +pmd_t kasan_early_shadow_pmd[MAX_PTRS_PER_PMD] __page_aligned_bss; static inline bool kasan_pmd_table(pud_t pud) { return pud_page(pud) =3D=3D virt_to_page(lm_alias(kasan_early_shadow_pm= d)); @@ -69,7 +69,7 @@ static inline bool kasan_pmd_table(pud_t pud) return false; } #endif -pte_t kasan_early_shadow_pte[PTRS_PER_PTE] __page_aligned_bss; +pte_t kasan_early_shadow_pte[MAX_PTRS_PER_PTE] __page_aligned_bss; =20 static inline bool kasan_pte_table(pmd_t pmd) { --=20 2.20.1