From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37F07C3F68F for ; Wed, 12 Feb 2020 08:23:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0340224671 for ; Wed, 12 Feb 2020 08:23:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0340224671 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BA6616B0407; Wed, 12 Feb 2020 03:23:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B2FA16B0409; Wed, 12 Feb 2020 03:23:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1FB76B040A; Wed, 12 Feb 2020 03:23:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0223.hostedemail.com [216.40.44.223]) by kanga.kvack.org (Postfix) with ESMTP id 86C6A6B0407 for ; Wed, 12 Feb 2020 03:23:50 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 3178E2C34 for ; Wed, 12 Feb 2020 08:23:50 +0000 (UTC) X-FDA: 76480786620.13.stop44_78c067054a51e X-HE-Tag: stop44_78c067054a51e X-Filterd-Recvd-Size: 3389 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Feb 2020 08:23:49 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id m10so4105947wmc.0 for ; Wed, 12 Feb 2020 00:23:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=YcczKYnk8/5+6HzLwge2DmQ8UtE5/tLTf5uBW6rS0Uk=; b=kvJ0U+NkXkG4paP6gnRUrZdo+mlrAdQl+Enkn+M9rXASNDsZ8G6XXETS8pO8ow54Rm yFs7B7ACgMdzC6d2hoHrcT6vBcLD+Or770WpQO+g/Oz//wzQTWrjB/Wik56bgNcZlfYT ATAFn000TG2cBPZn6K6cmdtbWqm6+Rv8NnQnQNIkvUbGvJGA+n5kYswauo/vzhkntB8a CLevV5ORbC2yrIk+jFt+TiSQp/ZgRaqPVDVkrADV5RapAIGy8Ol5etmOjNKEG0f8Yxhr EGBcpEBKXmQTF0Th9OJbThkzUbGwoSOR9lHa6EPqSXnFArK8HkScTkp9FxLRdxzqwQ8L v58g== X-Gm-Message-State: APjAAAWntvgUN/6FgPYMpyCm8W3X8o26uJc72xPnCY2TE6B0lQ+f12rC AdMSSepcjSdXjP8GFet054o= X-Google-Smtp-Source: APXvYqy1qfDdcUtFvF0fcj80udazhBnOTDztB57fRDKuAaR71X00G5KYH2xzD6d/1Dl8WaV4JyT86Q== X-Received: by 2002:a7b:c5cd:: with SMTP id n13mr11239178wmk.172.1581495828521; Wed, 12 Feb 2020 00:23:48 -0800 (PST) Received: from localhost (ip-37-188-227-72.eurotel.cz. [37.188.227.72]) by smtp.gmail.com with ESMTPSA id o7sm7006577wmh.11.2020.02.12.00.23.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Feb 2020 00:23:47 -0800 (PST) Date: Wed, 12 Feb 2020 09:23:46 +0100 From: Michal Hocko To: Yang Shi Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm: vmpressure: use mem_cgroup_is_root API Message-ID: <20200212082346.GB11353@dhcp22.suse.cz> References: <1581398649-125989-1-git-send-email-yang.shi@linux.alibaba.com> <1581398649-125989-2-git-send-email-yang.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1581398649-125989-2-git-send-email-yang.shi@linux.alibaba.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 11-02-20 13:24:09, Yang Shi wrote: > Use mem_cgroup_is_root() API to check if memcg is root memcg instead of > open coding. Yes, the direct use outside of memcontrol.c should be really an exception. The only other similar case is cgwb_bdi_init and there is no easy way to replace - except for adding a helper which is not worth it. > Signed-off-by: Yang Shi Acked-by: Michal Hocko Thanks! > --- > mm/vmpressure.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/vmpressure.c b/mm/vmpressure.c > index 0590f00..d69019f 100644 > --- a/mm/vmpressure.c > +++ b/mm/vmpressure.c > @@ -280,7 +280,7 @@ void vmpressure(gfp_t gfp, struct mem_cgroup *memcg, bool tree, > enum vmpressure_levels level; > > /* For now, no users for root-level efficiency */ > - if (!memcg || memcg == root_mem_cgroup) > + if (!memcg || mem_cgroup_is_root(memcg)) > return; > > spin_lock(&vmpr->sr_lock); > -- > 1.8.3.1 > -- Michal Hocko SUSE Labs