From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 273C1C3B186 for ; Wed, 12 Feb 2020 07:50:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DE819206DB for ; Wed, 12 Feb 2020 07:50:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="oBuvATo3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE819206DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6DB916B03F7; Wed, 12 Feb 2020 02:50:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 68BD96B03F9; Wed, 12 Feb 2020 02:50:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5A1BD6B03FA; Wed, 12 Feb 2020 02:50:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0075.hostedemail.com [216.40.44.75]) by kanga.kvack.org (Postfix) with ESMTP id 3FB046B03F7 for ; Wed, 12 Feb 2020 02:50:08 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id E02AF2AAE for ; Wed, 12 Feb 2020 07:50:07 +0000 (UTC) X-FDA: 76480701654.19.guide12_75856454ddb59 X-HE-Tag: guide12_75856454ddb59 X-Filterd-Recvd-Size: 2753 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Wed, 12 Feb 2020 07:50:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1nVf4vn0jnrm81iZchVFMrYKYcdKsraT+ctD9FAeWIM=; b=oBuvATo3aKkkhrPnQLe1L0Tftm uv8E37LrW9Pl5sTQe1Wy9e7orifQHoglTYXc1w2y2d2PZRXnn1ZRJno6yb8bAtFrS23Nv1z6MlQu+ PCXcY/HGH3ZEKI9ys82yZFU16SWh4aUL+Ltr1XtAayHALsQDDUZpKB73BVDpjiAUQ0ZjerBY2w1Mo GR883VVdazQIFtoLPO8K5Bt64FAprxdqtw/wnu61fukHeF6YTmqaBbWqypLvggygw/EE0w4FECYp+ jYyLb0AkhqNUG0BO1EBsLvgUlCt/bsPoP/urbcQTA0wEZt6TMno2z4hGVRIfBRX2p0wcXE652oa1s FygXWy1w==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1mmc-0002Q8-Rr; Wed, 12 Feb 2020 07:50:06 +0000 Date: Tue, 11 Feb 2020 23:50:06 -0800 From: Christoph Hellwig To: Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, William Kucharski , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 25/25] mm: Align THP mappings for non-DAX Message-ID: <20200212075006.GJ7068@infradead.org> References: <20200212041845.25879-1-willy@infradead.org> <20200212041845.25879-26-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200212041845.25879-26-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index b52e007f0856..b8d9e0d76062 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -577,13 +577,10 @@ unsigned long thp_get_unmapped_area(struct file *filp, unsigned long addr, > unsigned long ret; > loff_t off = (loff_t)pgoff << PAGE_SHIFT; > > - if (!IS_DAX(filp->f_mapping->host) || !IS_ENABLED(CONFIG_FS_DAX_PMD)) > - goto out; > - > ret = __thp_get_unmapped_area(filp, addr, len, off, flags, PMD_SIZE); > if (ret) > return ret; > -out: > + > return current->mm->get_unmapped_area(filp, addr, len, pgoff, flags); > } > EXPORT_SYMBOL_GPL(thp_get_unmapped_area); There is no point in splitting thp_get_unmapped_area and __thp_get_unmapped_area with this applied (and arguably even before that). But we still have ext2 and ext4 that use thp_get_unmapped_area but only support huge page mappings for DAX, do we need to handle those somehow?