From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD36EC352A3 for ; Tue, 11 Feb 2020 14:01:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 80C1F20870 for ; Tue, 11 Feb 2020 14:01:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 80C1F20870 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 284C36B02D4; Tue, 11 Feb 2020 09:01:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2346D6B02D5; Tue, 11 Feb 2020 09:01:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14A8A6B02D6; Tue, 11 Feb 2020 09:01:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0119.hostedemail.com [216.40.44.119]) by kanga.kvack.org (Postfix) with ESMTP id F137A6B02D4 for ; Tue, 11 Feb 2020 09:01:51 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 80FBD824805A for ; Tue, 11 Feb 2020 14:01:51 +0000 (UTC) X-FDA: 76478009622.16.boats44_676b670c14b19 X-HE-Tag: boats44_676b670c14b19 X-Filterd-Recvd-Size: 3504 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Tue, 11 Feb 2020 14:01:50 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id m10so2348687wmc.0 for ; Tue, 11 Feb 2020 06:01:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BXiGmThdAH0Y+7szdJZvX90AmeQq3coTYvS9lSVqoHQ=; b=g/YhXt62VmzAx25jhSswkxPQ/s7EgNcLHo1kyZ6ow/jtUySm4vYKUsIf8azSVyqTLX uLqK7AkoOBP9rpW4saQ+8C4l+32K3dQfU4T4sIikQnLnQ4Ar5RNVrRzHD+z6evW064VJ odD9xjjzW8VUixkB87qlhUdQsS3Vuj0kzTqeAuPElOpOyYj0ogV+19hZEUGIhmVrAp/0 YHfeYB+2QtC9ywrYde+a4mdY9vVktmFQQDPUwt61zIfgv1Oo/tpNK7O+k82u2PtPsNbH pL32QtSI/ot/lysxTJCp4ZiZPwKcoEzwdTcGbVIWPWo/MRT1UJ5dVmVn1nKHrFZirAsP 1UVA== X-Gm-Message-State: APjAAAUOlpd/Opx0Zu2ZZWqHJAStBU5isRmHyyLNSJWagWyiw09k7h3L VGZLyx5L9KqbKJeUwmOa/EU= X-Google-Smtp-Source: APXvYqwMXtPDnxivXRo6fXhlbud5qAkmSVTJWSyOp2Z7gAqFF6wrFc0pyj1lKg+sO6AEpX6w7LtObQ== X-Received: by 2002:a1c:bb82:: with SMTP id l124mr5752300wmf.176.1581429709436; Tue, 11 Feb 2020 06:01:49 -0800 (PST) Received: from localhost (ip-37-188-227-72.eurotel.cz. [37.188.227.72]) by smtp.gmail.com with ESMTPSA id f8sm5383908wru.12.2020.02.11.06.01.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Feb 2020 06:01:48 -0800 (PST) Date: Tue, 11 Feb 2020 15:01:47 +0100 From: Michal Hocko To: Vasily Averin Cc: Johannes Weiner , Vladimir Davydov , Andrew Morton , Kirill Tkhai , cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] memcg: lost css_put in memcg_expand_shrinker_maps() Message-ID: <20200211135322.GO10636@dhcp22.suse.cz> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 11-02-20 14:20:10, Vasily Averin wrote: > for_each_mem_cgroup() increases css reference counter for memory cgroup > and requires to use mem_cgroup_iter_break() if the walk is cancelled. > > Cc: stable@vger.kernel.org > Fixes commit 0a4465d34028("mm, memcg: assign memcg-aware shrinkers bitmap to memcg") Fixes: 0a4465d34028("mm, memcg: assign memcg-aware shrinkers bitmap to memcg") Is the usual format. > Signed-off-by: Vasily Averin Acked-by: Michal Hocko Thanks! > --- > mm/memcontrol.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 6c83cf4..e2da615 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -409,8 +409,10 @@ int memcg_expand_shrinker_maps(int new_id) > if (mem_cgroup_is_root(memcg)) > continue; > ret = memcg_expand_one_shrinker_map(memcg, size, old_size); > - if (ret) > + if (ret) { > + mem_cgroup_iter_break(NULL, memcg); > goto unlock; > + } > } > unlock: > if (!ret) > -- > 1.8.3.1 -- Michal Hocko SUSE Labs