From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74D6FC35242 for ; Sun, 9 Feb 2020 01:12:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 444EB22464 for ; Sun, 9 Feb 2020 01:12:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="LxhvWw1f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 444EB22464 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E20126B0007; Sat, 8 Feb 2020 20:12:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DCF896B0008; Sat, 8 Feb 2020 20:12:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE5DA6B000A; Sat, 8 Feb 2020 20:12:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0022.hostedemail.com [216.40.44.22]) by kanga.kvack.org (Postfix) with ESMTP id B5A156B0007 for ; Sat, 8 Feb 2020 20:12:20 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 612878248047 for ; Sun, 9 Feb 2020 01:12:20 +0000 (UTC) X-FDA: 76468812840.06.bag78_6b9fdb75d5c2d X-HE-Tag: bag78_6b9fdb75d5c2d X-Filterd-Recvd-Size: 1999 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Sun, 9 Feb 2020 01:12:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Q4ikuhmtjxLN9EjTouScO7MsD5p4DN4mq3YG1aqhW2U=; b=LxhvWw1fVeLF2rg6VYQF9kVt0s txCvOE/GE+xF+ZFps0y9KKDAMGBq3bfKMNpYCXnKeIqYYOR8qz5CrccFLWJhfUYT9vsGu8Jc/1Jp/ Gop12l20EfpU3fmwcPFcouCTaCujb+afhKsXF0UaS1D6fpiI9QrghJaZWQe7jqqlXI+tWlto/2fxV bKy4LaGeNAjfJqmFhLPALFw+C6J1Qor2yVcOrD0nHP7xX6EO/y/BHIvLQ6DnNK2FEdfpO5A4veaUV 54cMI8jA0iPvE8HTgugYzXGKCRj6tQZuyB0x9pNTX6JPLk8rqFcaiwgx3Lm7xiDXkL6Xw6JWPOy0s zMxvcquw==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j0b8n-0001tT-M9; Sun, 09 Feb 2020 01:12:05 +0000 Date: Sat, 8 Feb 2020 17:12:05 -0800 From: Matthew Wilcox To: John Hubbard Cc: linux-mm@kvack.org, "Kirill A . Shutemov" Subject: Re: [PATCH] mm: Improve dump_page() for compound pages Message-ID: <20200209011205.GK8731@bombadil.infradead.org> References: <20200208044415.30012-1-willy@infradead.org> <20200208044808.GJ8731@bombadil.infradead.org> <91b9f33e-ee28-e41a-868c-72e8a1186221@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <91b9f33e-ee28-e41a-868c-72e8a1186221@nvidia.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 08, 2020 at 05:09:15PM -0800, John Hubbard wrote: > Got it, I've snarfed it into my series, thanks very much! Thank you! I found the current debugging inadequate, but I'd only hacked up what I needed for my own needs, and really debugging code should be useful for situations we've not encountered yet.