From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99D4EC35249 for ; Mon, 3 Feb 2020 21:55:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5B7732086A for ; Mon, 3 Feb 2020 21:55:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="DW4g/6/M" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B7732086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0634B6B0003; Mon, 3 Feb 2020 16:55:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F2FAF6B0005; Mon, 3 Feb 2020 16:55:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1E166B0006; Mon, 3 Feb 2020 16:55:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0099.hostedemail.com [216.40.44.99]) by kanga.kvack.org (Postfix) with ESMTP id C45BC6B0003 for ; Mon, 3 Feb 2020 16:55:43 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 623F0181AEF09 for ; Mon, 3 Feb 2020 21:55:43 +0000 (UTC) X-FDA: 76450173366.25.idea01_893896c226215 X-HE-Tag: idea01_893896c226215 X-Filterd-Recvd-Size: 4679 Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by imf48.hostedemail.com (Postfix) with ESMTP for ; Mon, 3 Feb 2020 21:55:42 +0000 (UTC) Received: by mail-lf1-f68.google.com with SMTP id r14so10803189lfm.5 for ; Mon, 03 Feb 2020 13:55:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=xJAkb73npUQtmUSyvboyg3nc2D2eMj/LRe7QTM0JtTw=; b=DW4g/6/MYnXF1LPe7/2RfS04IyD4h5v6Zw7F9g9HD0UoluTY5xl5rQH07HxoIfbmSL LbFPoisu/4Tf5fjpwS9AZkUc3Kpx3LfxRMz8B9pPJvkrCLA7ieUqNXTThuqVrogXnyXm YmQ06qGBkh/Fdsm2rVaRMS0Rnw0TP30W+hypvgpymsuhXKoHKFW7l3sqQWzs6Er7Z+aE hf88D1ebprJj+AYGaHcWnx0tNLJhNmcUm61BuHbDtb4G838UMGhHK90rGrVQ2upG1cZ/ o/zhxtnTwPa6UXPgEeMmNrNB7tYI4gWFHfxIfqHrrdDCxj+zCFGgWe5xu355ukz9kbT4 S7Hg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=xJAkb73npUQtmUSyvboyg3nc2D2eMj/LRe7QTM0JtTw=; b=XqRkNJVAwFsGzbNnz7gNZFldsfm4vCgMCBWzbCz+qbxmmnrhiK5f2kep/VIdk6hLLM EgCdBKCM/nU1i0cvErEeEqGO9gofIigKQRnDhREQFgSo6+MXw52hf49I2Hx5Jfivdkgi 3ggxbw9FxIMK6BEhGAYg3OnkvvCe/qJyyOEmrfAgChW/AxM/jtLwT+IvLuFhyenQGf/i uoi4vSoh87epOwrgyY/DNpJyIIYM2N+13YR5KnnOiYI61gnIVtUiBXsGruRznnxmcO9d v7PDDDKj1F34FFmCCoXEZ8ZQxNLHKbfpr7wUjlruLH6+8um7tD6T7Y9puQMpZo8Y+yJK RLCg== X-Gm-Message-State: APjAAAXfWDopGO8xpsadgV09KBRo30u6UbBpNs/T9LwX2/b2E5rI13jd tL5S8LONnfJKDZer3b8MQ/dmVg== X-Google-Smtp-Source: APXvYqzKhf8yy+VrDIH7P5bwPA/N4dISxyqqDNekLgToc6ApS5rJ2jA6asIx54ka9+WFODqsBDZ5WA== X-Received: by 2002:a19:9159:: with SMTP id y25mr13507738lfj.63.1580766941406; Mon, 03 Feb 2020 13:55:41 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id 144sm9700269lfi.67.2020.02.03.13.55.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2020 13:55:40 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id 86130100AF6; Tue, 4 Feb 2020 00:55:53 +0300 (+03) Date: Tue, 4 Feb 2020 00:55:53 +0300 From: "Kirill A. Shutemov" To: John Hubbard Cc: Andrew Morton , Al Viro , Christoph Hellwig , Dan Williams , Dave Chinner , Ira Weiny , Jan Kara , Jason Gunthorpe , Jonathan Corbet , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Michal Hocko , Mike Kravetz , Shuah Khan , Vlastimil Babka , Matthew Wilcox , linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, LKML Subject: Re: [PATCH v3 11/12] mm/gup_benchmark: support pin_user_pages() and related calls Message-ID: <20200203215553.q7zx6diprbby6ns5@box.shutemov.name> References: <20200201034029.4063170-1-jhubbard@nvidia.com> <20200201034029.4063170-12-jhubbard@nvidia.com> <20200203135845.ymfbghs7rf67awex@box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 03, 2020 at 01:17:40PM -0800, John Hubbard wrote: > On 2/3/20 5:58 AM, Kirill A. Shutemov wrote: > ... > >> @@ -19,6 +21,48 @@ struct gup_benchmark { > >> __u64 expansion[10]; /* For future use */ > >> }; > >> > >> +static void put_back_pages(unsigned int cmd, struct page **pages, > >> + unsigned long nr_pages) > >> +{ > >> + int i; > >> + > >> + switch (cmd) { > >> + case GUP_FAST_BENCHMARK: > >> + case GUP_LONGTERM_BENCHMARK: > >> + case GUP_BENCHMARK: > >> + for (i = 0; i < nr_pages; i++) > > > > 'i' is 'int' and 'nr_pages' is 'unsigned long'. > > There's space for trouble :P > > > > Yes, I've changed it to "unsigned int", thanks. I'm confused. If nr_pages is more than UINT_MAX, this is endless loop. Hm? -- Kirill A. Shutemov