From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B70B1C35249 for ; Mon, 3 Feb 2020 16:13:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7B1CC2086A for ; Mon, 3 Feb 2020 16:13:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="mFABLiRZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B1CC2086A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 189F26B068A; Mon, 3 Feb 2020 11:13:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 13ADF6B068B; Mon, 3 Feb 2020 11:13:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 04FD66B068C; Mon, 3 Feb 2020 11:13:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E5A7E6B068A for ; Mon, 3 Feb 2020 11:13:43 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A5E1381F3 for ; Mon, 3 Feb 2020 16:13:43 +0000 (UTC) X-FDA: 76449311526.19.meat66_3d80e2d4eec3c X-HE-Tag: meat66_3d80e2d4eec3c X-Filterd-Recvd-Size: 4362 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Mon, 3 Feb 2020 16:13:42 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id t13so11854247qto.3 for ; Mon, 03 Feb 2020 08:13:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=5ZPjQ9pyWegFq7ptB0Of0FuoHr1kyVa2z4FlXuSnJwU=; b=mFABLiRZqHMCt0JZs8/Rt/DmWcHMcqdBw8N/uq0D0YvB/GxaEgpyrz5As2bHwWTXcg HoUT2W956XCzqcOsNRC9CYjBV9AQ4jpXQw9DHxWeH393UFWJwPFPc2urzoyv/1v1IgN0 kRxR7qcK4KfpcTsQl6F4J95BKmAmSS4PEZpFtjD0fTirNC6zVPnwoCTFgBSbPPmd8FPh YU0jY5dQMjjVxRilvrXBNTPCTcS+8OKNw7peUyihgtkj1Ucg9WOQZWPgt1iMe7bJVFh7 C9nfuPz4Z73Z44YqJJizsoRkdx2juj5yx+z5mjUu8yrviZcBM8U4SLLW1g0IevhHjWZs fe6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5ZPjQ9pyWegFq7ptB0Of0FuoHr1kyVa2z4FlXuSnJwU=; b=X1uxWyGP85ZLQUzocdJrms4yJ6zN9FSqqgF+hNx9JjjBs6VHrjYEc8M3mbr4oowz/R sEP8b+dPS9vaiGaraOlEylwiUZiZ0LrWeMJY3KAUXvxcr3mTnCvfIcrzdy4z2xLWyNyt n85mHnu1XPkcD04ZG4kyAc2lh6QSdUTrQCwJi+8dwGgoKZWDubV4pJ5W6Iu3+4RatgxL x2AfcyCIOy57q7LzFbnVbb6mCljHvzn+MosFFb7GSC5EWFW60oBqZGR+okGcjhkGdn7e ReP6P9w4tZAA6618+XoDFJfKZ2+CPYvhkuhMKKp0jYAD7wWQptfu7Ikq+blspoRB5Vh+ mnNw== X-Gm-Message-State: APjAAAWfqAX0lqdXgrCTxC0/wcM/8LBeO9DNDTMQGhKOf8updT0yl/zg nwNkoy5dYSIF1UU6ELB5jwrkOg== X-Google-Smtp-Source: APXvYqwjdR9TVx4GU6B5klThIt/F+G0GrsNyifcGvXkPp7QKBRII6lMLqucHhw8EzGWEJEXGddLyLg== X-Received: by 2002:ac8:7952:: with SMTP id r18mr24493028qtt.251.1580746421743; Mon, 03 Feb 2020 08:13:41 -0800 (PST) Received: from localhost ([2620:10d:c091:500::3:c810]) by smtp.gmail.com with ESMTPSA id d25sm9333054qka.39.2020.02.03.08.13.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2020 08:13:41 -0800 (PST) Date: Mon, 3 Feb 2020 11:13:40 -0500 From: Johannes Weiner To: Roman Gushchin Cc: linux-mm@kvack.org, Andrew Morton , Michal Hocko , Shakeel Butt , Vladimir Davydov , linux-kernel@vger.kernel.org, kernel-team@fb.com, Bharata B Rao , Yafang Shao Subject: Re: [PATCH v2 09/28] mm: memcg/slab: rename __mod_lruvec_slab_state() into __mod_lruvec_obj_state() Message-ID: <20200203161340.GC1697@cmpxchg.org> References: <20200127173453.2089565-1-guro@fb.com> <20200127173453.2089565-10-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200127173453.2089565-10-guro@fb.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 27, 2020 at 09:34:34AM -0800, Roman Gushchin wrote: > Rename __mod_lruvec_slab_state() into __mod_lruvec_obj_state() > to unify it with mod_memcg_obj_state(). It better reflects the fact > that the passed object isn't necessary slab-backed. Makes sense to me. > @@ -1116,7 +1116,7 @@ static inline void mod_lruvec_page_state(struct page *page, > mod_node_page_state(page_pgdat(page), idx, val); > } > > -static inline void __mod_lruvec_slab_state(void *p, enum node_stat_item idx, > +static inline void __mod_lruvec_obj_state(void *p, enum node_stat_item idx, > int val) > { > struct page *page = virt_to_head_page(p); > @@ -1217,12 +1217,12 @@ static inline void __dec_lruvec_page_state(struct page *page, > > static inline void __inc_lruvec_slab_state(void *p, enum node_stat_item idx) > { > - __mod_lruvec_slab_state(p, idx, 1); > + __mod_lruvec_obj_state(p, idx, 1); > } > > static inline void __dec_lruvec_slab_state(void *p, enum node_stat_item idx) > { > - __mod_lruvec_slab_state(p, idx, -1); > + __mod_lruvec_obj_state(p, idx, -1); > } These should be renamed as well, no?