From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40AC3C35247 for ; Mon, 3 Feb 2020 13:23:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 04EC32086A for ; Mon, 3 Feb 2020 13:23:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=shutemov-name.20150623.gappssmtp.com header.i=@shutemov-name.20150623.gappssmtp.com header.b="FAiKXrOR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 04EC32086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shutemov.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 936A66B064E; Mon, 3 Feb 2020 08:23:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E6DE6B064F; Mon, 3 Feb 2020 08:23:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7ADF86B0650; Mon, 3 Feb 2020 08:23:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id 624446B064E for ; Mon, 3 Feb 2020 08:23:19 -0500 (EST) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0E24F180AD802 for ; Mon, 3 Feb 2020 13:23:19 +0000 (UTC) X-FDA: 76448882118.04.top61_1cdeb1846032b X-HE-Tag: top61_1cdeb1846032b X-Filterd-Recvd-Size: 5267 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Mon, 3 Feb 2020 13:23:18 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id q8so14614122ljb.2 for ; Mon, 03 Feb 2020 05:23:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov-name.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yciKij7aZ9IxqsUAs/104yOVBksVOCSAdlwEXkSdpoQ=; b=FAiKXrOR692VWEgWF88bI0DjGDu/Sjr0t06eV884FO+vVgwg4SO1uh7Qjl5zLD2Mnt 6dIaQ6GUVYMIRRdp6Zr3N4HwWQyUE9FJgr/ot760UXFb9ieeuh0y5ihna9xcf2NmLfCx ATq82Ac6zbqDRu4VKrwnxbU4xctjK9vueLdVmKNpS6KqzdJvtHV4CLOBxIiZkxMDg+qK ecH96G8OHeFmWugtvDrmtXQeUcEyqBTxR9to5bv4yN3DtqJmP2+Xwq+RSXlRUoI+6ri4 AUdjBjhCj/vULhTNfShatAWSXcd57f3QFCfh0lIhgZ0VEybpMYi20qW77bNE0IKdYCKt uSlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yciKij7aZ9IxqsUAs/104yOVBksVOCSAdlwEXkSdpoQ=; b=PcX56xdAuRS/roIavkEQwn7o9tTiGSlVedmxiVTJAYR3PiPM7U4V1J/ar2djU9RKs7 JDdH/97Rbta5SmCu4gEH4aygI2uwOdnwoHeglml2BgxCF7bBKnuBmzYy5cLe/SQ3Pm5V UgY9f12ScwHPk8Nnu0YeyzXKpKUW/kokcJI3TNu7LqQMNzBPpe7iyVsSllinHR81UPdz Kjt/Lkzd6Zi2dzdbvhtSAvmpoinaKBNixanplcJ1VOllZdganfNy1w3HgJbCo5XFvKSn /3j3madWCIcxle2NGhd5gZUsWslkgzfVp3J1TKAwrs7OKKNKwCS89UnXqSCn1jNoKnZ9 lmRw== X-Gm-Message-State: APjAAAUhBa2ejnHkIa/MHW4sGviCGtkdlJN95LT6jOSPxawRCb74tbHc rYy0mkQdCeu/p/Wvrzu4tPOuCA== X-Google-Smtp-Source: APXvYqz6+ASziVfzDtmIfqoBNJGqRDrKpccZCRWjuRMxtwAuDOff2v4nbarQjcGBTnjRDFxC1sKg0Q== X-Received: by 2002:a2e:b0e3:: with SMTP id h3mr13425116ljl.56.1580736196893; Mon, 03 Feb 2020 05:23:16 -0800 (PST) Received: from box.localdomain ([86.57.175.117]) by smtp.gmail.com with ESMTPSA id j7sm8959848lfh.25.2020.02.03.05.23.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Feb 2020 05:23:16 -0800 (PST) Received: by box.localdomain (Postfix, from userid 1000) id 1306D100DC8; Mon, 3 Feb 2020 16:23:29 +0300 (+03) Date: Mon, 3 Feb 2020 16:23:29 +0300 From: "Kirill A. Shutemov" To: John Hubbard Cc: Andrew Morton , Al Viro , Christoph Hellwig , Dan Williams , Dave Chinner , Ira Weiny , Jan Kara , Jason Gunthorpe , Jonathan Corbet , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Michal Hocko , Mike Kravetz , Shuah Khan , Vlastimil Babka , Matthew Wilcox , linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, LKML Subject: Re: [PATCH v3 04/12] mm: introduce page_ref_sub_return() Message-ID: <20200203132329.oj32h4ryna4gmkwh@box> References: <20200201034029.4063170-1-jhubbard@nvidia.com> <20200201034029.4063170-5-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200201034029.4063170-5-jhubbard@nvidia.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 31, 2020 at 07:40:21PM -0800, John Hubbard wrote: > An upcoming patch requires subtracting a large chunk of refcounts from > a page, and checking what the resulting refcount is. This is a little > different than the usual "check for zero refcount" that many of the > page ref functions already do. However, it is similar to a few other > routines that (like this one) are generally useful for things such as > 1-based refcounting. > > Add page_ref_sub_return(), that subtracts a chunk of refcounts > atomically, and returns an atomic snapshot of the result. > > Signed-off-by: John Hubbard > --- > include/linux/page_ref.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/linux/page_ref.h b/include/linux/page_ref.h > index 14d14beb1f7f..b9cbe553d1e7 100644 > --- a/include/linux/page_ref.h > +++ b/include/linux/page_ref.h > @@ -102,6 +102,16 @@ static inline void page_ref_sub(struct page *page, int nr) > __page_ref_mod(page, -nr); > } > > +static inline int page_ref_sub_return(struct page *page, int nr) > +{ > + int ret = atomic_sub_return(nr, &page->_refcount); > + > + if (page_ref_tracepoint_active(__tracepoint_page_ref_mod)) > + __page_ref_mod(page, -nr); Shouldn't it be __page_ref_mod_and_return() and relevant tracepoint? > + > + return ret; > +} > + > static inline void page_ref_inc(struct page *page) > { > atomic_inc(&page->_refcount); > -- > 2.25.0 > -- Kirill A. Shutemov