From: Peter Zijlstra <peterz@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kbuild test robot <lkp@intel.com>,
kbuild-all@lists.01.org,
"Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [linux-next:master 11821/11843] mm/mmu_gather.c:130:2: error: implicit declaration of function '__tlb_remove_table'; did you mean 'tlb_remove_table'?
Date: Fri, 31 Jan 2020 10:56:58 +0100 [thread overview]
Message-ID: <20200131095658.GA14914@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200130172123.547be0742cd8816c9c841d76@linux-foundation.org>
On Thu, Jan 30, 2020 at 05:21:23PM -0800, Andrew Morton wrote:
> On Fri, 31 Jan 2020 07:12:28 +0800 kbuild test robot <lkp@intel.com> wrote:
>
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head: eb9ebdceaadcab583114dd84f2a630603405e50f
> > commit: 47f9cd553915150ad3577556c253baf632e58207 [11821/11843] asm-generic/tlb: rename HAVE_RCU_TABLE_FREE
> > config: sparc64-allnoconfig (attached as .config)
> > compiler: sparc64-linux-gcc (GCC) 7.5.0
> > reproduce:
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > git checkout 47f9cd553915150ad3577556c253baf632e58207
> > # save the attached .config to linux build tree
> > GCC_VERSION=7.5.0 make.cross ARCH=sparc64
> >
> > If you fix the issue, kindly add following tag
> > Reported-by: kbuild test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> > mm/mmu_gather.c: In function 'tlb_remove_table_one':
> > >> mm/mmu_gather.c:130:2: error: implicit declaration of function '__tlb_remove_table'; did you mean 'tlb_remove_table'? [-Werror=implicit-function-declaration]
> > __tlb_remove_table(table);
> > ^~~~~~~~~~~~~~~~~~
>
> Well that took some hunting down. Thanks.
>
> --- a/arch/sparc/Kconfig~asm-generic-tlb-rename-have_rcu_table_free-fix
> +++ a/arch/sparc/Kconfig
> @@ -64,7 +64,7 @@ config SPARC64
> select HAVE_FUNCTION_GRAPH_TRACER
> select HAVE_KRETPROBES
> select HAVE_KPROBES
> - select MMU_GATHER_RCU_TABLE_FREE
> + select MMU_GATHER_RCU_TABLE_FREE if SMP
> select HAVE_MEMBLOCK_NODE_MAP
> select HAVE_ARCH_TRANSPARENT_HUGEPAGE
> select HAVE_DYNAMIC_FTRACE
Aneesh did send a patch for that:
https://lkml.kernel.org/r/87v9p9mhnr.fsf@linux.ibm.com
prev parent reply other threads:[~2020-01-31 9:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 23:12 kbuild test robot
2020-01-31 1:21 ` Andrew Morton
2020-01-31 9:56 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131095658.GA14914@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox