* [linux-next:master 11821/11843] mm/mmu_gather.c:130:2: error: implicit declaration of function '__tlb_remove_table'; did you mean 'tlb_remove_table'?
@ 2020-01-30 23:12 kbuild test robot
2020-01-31 1:21 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2020-01-30 23:12 UTC (permalink / raw)
To: Peter Zijlstra
Cc: kbuild-all, Aneesh Kumar K.V, Andrew Morton,
Linux Memory Management List
[-- Attachment #1: Type: text/plain, Size: 2643 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: eb9ebdceaadcab583114dd84f2a630603405e50f
commit: 47f9cd553915150ad3577556c253baf632e58207 [11821/11843] asm-generic/tlb: rename HAVE_RCU_TABLE_FREE
config: sparc64-allnoconfig (attached as .config)
compiler: sparc64-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 47f9cd553915150ad3577556c253baf632e58207
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=sparc64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
mm/mmu_gather.c: In function 'tlb_remove_table_one':
>> mm/mmu_gather.c:130:2: error: implicit declaration of function '__tlb_remove_table'; did you mean 'tlb_remove_table'? [-Werror=implicit-function-declaration]
__tlb_remove_table(table);
^~~~~~~~~~~~~~~~~~
tlb_remove_table
cc1: some warnings being treated as errors
vim +130 mm/mmu_gather.c
196d9d8bb71dea Peter Zijlstra 2018-09-03 119
196d9d8bb71dea Peter Zijlstra 2018-09-03 120 static void tlb_remove_table_one(void *table)
196d9d8bb71dea Peter Zijlstra 2018-09-03 121 {
196d9d8bb71dea Peter Zijlstra 2018-09-03 122 /*
196d9d8bb71dea Peter Zijlstra 2018-09-03 123 * This isn't an RCU grace period and hence the page-tables cannot be
196d9d8bb71dea Peter Zijlstra 2018-09-03 124 * assumed to be actually RCU-freed.
196d9d8bb71dea Peter Zijlstra 2018-09-03 125 *
196d9d8bb71dea Peter Zijlstra 2018-09-03 126 * It is however sufficient for software page-table walkers that rely on
196d9d8bb71dea Peter Zijlstra 2018-09-03 127 * IRQ disabling. See the comment near struct mmu_table_batch.
196d9d8bb71dea Peter Zijlstra 2018-09-03 128 */
196d9d8bb71dea Peter Zijlstra 2018-09-03 129 smp_call_function(tlb_remove_table_smp_sync, NULL, 1);
196d9d8bb71dea Peter Zijlstra 2018-09-03 @130 __tlb_remove_table(table);
196d9d8bb71dea Peter Zijlstra 2018-09-03 131 }
196d9d8bb71dea Peter Zijlstra 2018-09-03 132
:::::: The code at line 130 was first introduced by commit
:::::: 196d9d8bb71deaa2d1c7170c88a2f1a318363047 mm/memory: Move mmu_gather and TLB invalidation code into its own file
:::::: TO: Peter Zijlstra <peterz@infradead.org>
:::::: CC: Will Deacon <will.deacon@arm.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 5822 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [linux-next:master 11821/11843] mm/mmu_gather.c:130:2: error: implicit declaration of function '__tlb_remove_table'; did you mean 'tlb_remove_table'?
2020-01-30 23:12 [linux-next:master 11821/11843] mm/mmu_gather.c:130:2: error: implicit declaration of function '__tlb_remove_table'; did you mean 'tlb_remove_table'? kbuild test robot
@ 2020-01-31 1:21 ` Andrew Morton
2020-01-31 9:56 ` Peter Zijlstra
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2020-01-31 1:21 UTC (permalink / raw)
To: kbuild test robot
Cc: Peter Zijlstra, kbuild-all, Aneesh Kumar K.V,
Linux Memory Management List
On Fri, 31 Jan 2020 07:12:28 +0800 kbuild test robot <lkp@intel.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> head: eb9ebdceaadcab583114dd84f2a630603405e50f
> commit: 47f9cd553915150ad3577556c253baf632e58207 [11821/11843] asm-generic/tlb: rename HAVE_RCU_TABLE_FREE
> config: sparc64-allnoconfig (attached as .config)
> compiler: sparc64-linux-gcc (GCC) 7.5.0
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout 47f9cd553915150ad3577556c253baf632e58207
> # save the attached .config to linux build tree
> GCC_VERSION=7.5.0 make.cross ARCH=sparc64
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> mm/mmu_gather.c: In function 'tlb_remove_table_one':
> >> mm/mmu_gather.c:130:2: error: implicit declaration of function '__tlb_remove_table'; did you mean 'tlb_remove_table'? [-Werror=implicit-function-declaration]
> __tlb_remove_table(table);
> ^~~~~~~~~~~~~~~~~~
Well that took some hunting down. Thanks.
--- a/arch/sparc/Kconfig~asm-generic-tlb-rename-have_rcu_table_free-fix
+++ a/arch/sparc/Kconfig
@@ -64,7 +64,7 @@ config SPARC64
select HAVE_FUNCTION_GRAPH_TRACER
select HAVE_KRETPROBES
select HAVE_KPROBES
- select MMU_GATHER_RCU_TABLE_FREE
+ select MMU_GATHER_RCU_TABLE_FREE if SMP
select HAVE_MEMBLOCK_NODE_MAP
select HAVE_ARCH_TRANSPARENT_HUGEPAGE
select HAVE_DYNAMIC_FTRACE
_
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [linux-next:master 11821/11843] mm/mmu_gather.c:130:2: error: implicit declaration of function '__tlb_remove_table'; did you mean 'tlb_remove_table'?
2020-01-31 1:21 ` Andrew Morton
@ 2020-01-31 9:56 ` Peter Zijlstra
0 siblings, 0 replies; 3+ messages in thread
From: Peter Zijlstra @ 2020-01-31 9:56 UTC (permalink / raw)
To: Andrew Morton
Cc: kbuild test robot, kbuild-all, Aneesh Kumar K.V,
Linux Memory Management List
On Thu, Jan 30, 2020 at 05:21:23PM -0800, Andrew Morton wrote:
> On Fri, 31 Jan 2020 07:12:28 +0800 kbuild test robot <lkp@intel.com> wrote:
>
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head: eb9ebdceaadcab583114dd84f2a630603405e50f
> > commit: 47f9cd553915150ad3577556c253baf632e58207 [11821/11843] asm-generic/tlb: rename HAVE_RCU_TABLE_FREE
> > config: sparc64-allnoconfig (attached as .config)
> > compiler: sparc64-linux-gcc (GCC) 7.5.0
> > reproduce:
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > git checkout 47f9cd553915150ad3577556c253baf632e58207
> > # save the attached .config to linux build tree
> > GCC_VERSION=7.5.0 make.cross ARCH=sparc64
> >
> > If you fix the issue, kindly add following tag
> > Reported-by: kbuild test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>):
> >
> > mm/mmu_gather.c: In function 'tlb_remove_table_one':
> > >> mm/mmu_gather.c:130:2: error: implicit declaration of function '__tlb_remove_table'; did you mean 'tlb_remove_table'? [-Werror=implicit-function-declaration]
> > __tlb_remove_table(table);
> > ^~~~~~~~~~~~~~~~~~
>
> Well that took some hunting down. Thanks.
>
> --- a/arch/sparc/Kconfig~asm-generic-tlb-rename-have_rcu_table_free-fix
> +++ a/arch/sparc/Kconfig
> @@ -64,7 +64,7 @@ config SPARC64
> select HAVE_FUNCTION_GRAPH_TRACER
> select HAVE_KRETPROBES
> select HAVE_KPROBES
> - select MMU_GATHER_RCU_TABLE_FREE
> + select MMU_GATHER_RCU_TABLE_FREE if SMP
> select HAVE_MEMBLOCK_NODE_MAP
> select HAVE_ARCH_TRANSPARENT_HUGEPAGE
> select HAVE_DYNAMIC_FTRACE
Aneesh did send a patch for that:
https://lkml.kernel.org/r/87v9p9mhnr.fsf@linux.ibm.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-31 9:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-30 23:12 [linux-next:master 11821/11843] mm/mmu_gather.c:130:2: error: implicit declaration of function '__tlb_remove_table'; did you mean 'tlb_remove_table'? kbuild test robot
2020-01-31 1:21 ` Andrew Morton
2020-01-31 9:56 ` Peter Zijlstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox