From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46E0EC33C9E for ; Thu, 30 Jan 2020 07:49:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1D7F4206F0 for ; Thu, 30 Jan 2020 07:49:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D7F4206F0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A97FD6B0324; Thu, 30 Jan 2020 02:49:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A48AB6B0325; Thu, 30 Jan 2020 02:49:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 985866B0326; Thu, 30 Jan 2020 02:49:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id 8441B6B0324 for ; Thu, 30 Jan 2020 02:49:11 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 463EC4427 for ; Thu, 30 Jan 2020 07:49:11 +0000 (UTC) X-FDA: 76433524902.15.fifth39_502a509da1219 X-HE-Tag: fifth39_502a509da1219 X-Filterd-Recvd-Size: 1818 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Thu, 30 Jan 2020 07:49:10 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id D3A14B212; Thu, 30 Jan 2020 07:49:08 +0000 (UTC) Date: Thu, 30 Jan 2020 08:49:01 +0100 From: Michal Hocko To: Gavin Shan Cc: linux-mm@kvack.org, aarcange@redhat.com, akpm@linux-foundation.org Subject: Re: [PATCH 0/3] mm: Rework {enabled,defrag}_{show,store} Message-ID: <20200130074901.GR24244@dhcp22.suse.cz> References: <20200130022441.95488-1-gshan@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200130022441.95488-1-gshan@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 30-01-20 13:24:38, Gavin Shan wrote: > The inappropriate settings can be accepted by "enabled" and "defrag" > interface, as the following example shows. This series reworks the > related functions and fixes the issue by the way. Do we really care? This is a root only interface and we do expect root to know how to use the interface. > # cat /sys/kernel/mm/transparent_hugepage/enabled > always [madvise] never > # echo neveroff > /sys/kernel/mm/transparent_hugepage/enabled > # cat /sys/kernel/mm/transparent_hugepage/enabled > always madvise [never] > > Gavin Shan (3): > mm: Rework {enabled,defrag}_store() > mm: Rework {enabled,defrag}_show() > mm: Rework setup_transparent_hugepage() > > mm/huge_memory.c | 216 +++++++++++++++++++++++++++-------------------- > 1 file changed, 125 insertions(+), 91 deletions(-) > > -- > 2.23.0 > -- Michal Hocko SUSE Labs