From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 527B9C2D0DB for ; Wed, 29 Jan 2020 13:29:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 11FDD2070E for ; Wed, 29 Jan 2020 13:29:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11FDD2070E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 89EF76B0007; Wed, 29 Jan 2020 08:29:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 84F486B0008; Wed, 29 Jan 2020 08:29:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73E146B000A; Wed, 29 Jan 2020 08:29:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0021.hostedemail.com [216.40.44.21]) by kanga.kvack.org (Postfix) with ESMTP id 5F4716B0007 for ; Wed, 29 Jan 2020 08:29:54 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 10D9C181AEF09 for ; Wed, 29 Jan 2020 13:29:54 +0000 (UTC) X-FDA: 76430754708.16.way21_5665995744710 X-HE-Tag: way21_5665995744710 X-Filterd-Recvd-Size: 4279 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf28.hostedemail.com (Postfix) with ESMTP for ; Wed, 29 Jan 2020 13:29:53 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id z3so20215179wru.3 for ; Wed, 29 Jan 2020 05:29:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=prpS7rraPt/GjCivc8V6REqwcGP4nAyD1IPQ65+5P0g=; b=ljxcmLPu/6fspnRPJMESOV8mNkxTXXHSYFcrFPWHaskfq/z1+ymoqJmX+pS90NX/d3 ssz1qwgWiMCn2DxxezrO7mAVj1JvNdlv2dOHpYbgFzyVNkyiTlNnOLpb5nDmCcXMDfcz 7DLkOoiUNEuSev7/RMl7qrA+ZxCpQN2cAmB6qkeKKwJiBur8Zqg14LgYLE3RUbburEtd ETjeD6qP0IDc07GFf/ivz77xLo5HkgpAom0AV0wQHxrQ2LrKf3JnT0+y+Lu8bX+iSsA/ oJR9IVVFlnTqAJ7mJLlZXBkp9TvR5gWJ/BGz3SvqFTu7xD3uc/rgC7INlW/qUswj6PRG uvZg== X-Gm-Message-State: APjAAAV4MgZClrhHz1L+MrUfAAOuLnHbARSbwCqh+OYShZ7xNLWelzVk lACRTIdJDU7Rq+vENBQYJJw= X-Google-Smtp-Source: APXvYqwUgwcj23f6v0orkfDA43EGCM8GKFKUL1BSo+4dxdZTryjlU8NEkhX/qps/nQ25dswX65X1bQ== X-Received: by 2002:a5d:540f:: with SMTP id g15mr33967169wrv.86.1580304592326; Wed, 29 Jan 2020 05:29:52 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id y20sm2334628wmi.23.2020.01.29.05.29.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Jan 2020 05:29:51 -0800 (PST) Date: Wed, 29 Jan 2020 14:29:50 +0100 From: Michal Hocko To: Qian Cai Cc: akpm@linux-foundation.org, penguin-kernel@i-love.sakura.ne.jp, hannes@cmpxchg.org, elver@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, syzbot+f36cfe60b1006a94f9dc@syzkaller.appspotmail.com Subject: Re: [PATCH -next] mm/page_counter: annotate an intentional data race Message-ID: <20200129132950.GL24244@dhcp22.suse.cz> References: <20200129131242.4329-1-cai@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200129131242.4329-1-cai@lca.pw> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 29-01-20 08:12:42, Qian Cai wrote: > The commit 3e32cb2e0a12 ("mm: memcontrol: lockless page counters") could > had memcg->memsw->failcnt been accessed concurrently as reported by > KCSAN, > > BUG: KCSAN: data-race in page_counter_try_charge / page_counter_try_charge > > write to 0xffff88809bbf2158 of 8 bytes by task 11782 on cpu 0: > page_counter_try_charge+0x100/0x170 mm/page_counter.c:129 > try_charge+0x185/0xbf0 mm/memcontrol.c:2405 > __memcg_kmem_charge_memcg+0x4a/0xe0 mm/memcontrol.c:2837 > __memcg_kmem_charge+0xcf/0x1b0 mm/memcontrol.c:2877 > __alloc_pages_nodemask+0x26c/0x310 mm/page_alloc.c:4780 > > read to 0xffff88809bbf2158 of 8 bytes by task 11814 on cpu 1: > page_counter_try_charge+0xef/0x170 mm/page_counter.c:129 > try_charge+0x185/0xbf0 mm/memcontrol.c:2405 > __memcg_kmem_charge_memcg+0x4a/0xe0 mm/memcontrol.c:2837 > __memcg_kmem_charge+0xcf/0x1b0 mm/memcontrol.c:2877 > __alloc_pages_nodemask+0x26c/0x310 mm/page_alloc.c:4780 > > Since the "failcnt" counter is tolerant of some degree of inaccuracy and > is only used to report stats, a data race will not be harmful, thus mark > it as an intentional data races with the data_race() macro. > > Reported-by: syzbot+f36cfe60b1006a94f9dc@syzkaller.appspotmail.com > Signed-off-by: Qian Cai Acked-by: Michal Hocko > --- > mm/page_counter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/page_counter.c b/mm/page_counter.c > index a17841150906..7c82072cda25 100644 > --- a/mm/page_counter.c > +++ b/mm/page_counter.c > @@ -126,7 +126,7 @@ bool page_counter_try_charge(struct page_counter *counter, > * This is racy, but we can live with some > * inaccuracy in the failcnt. > */ > - c->failcnt++; > + data_race(c->failcnt++); > *fail = c; > goto failed; > } > -- > 2.21.0 (Apple Git-122.2) -- Michal Hocko SUSE Labs