From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E82FC2D0DB for ; Mon, 27 Jan 2020 13:03:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3EE87214D8 for ; Mon, 27 Jan 2020 13:03:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3EE87214D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ubuntu.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D042F6B0003; Mon, 27 Jan 2020 08:03:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CB5216B0006; Mon, 27 Jan 2020 08:03:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BCC666B0007; Mon, 27 Jan 2020 08:03:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id A7D9F6B0003 for ; Mon, 27 Jan 2020 08:03:08 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 55DDE2C89 for ; Mon, 27 Jan 2020 13:03:08 +0000 (UTC) X-FDA: 76423429656.06.hour09_1b53fcf548338 X-HE-Tag: hour09_1b53fcf548338 X-Filterd-Recvd-Size: 3620 Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Mon, 27 Jan 2020 13:03:07 +0000 (UTC) Received: from ip5f5bd665.dynamic.kabel-deutschland.de ([95.91.214.101] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iw42e-0001Yk-8w; Mon, 27 Jan 2020 13:03:00 +0000 Date: Mon, 27 Jan 2020 14:02:59 +0100 From: Christian Brauner To: Dave Chinner Cc: Mike Christie , Shakeel Butt , Andrew Morton , linux-api@vger.kernel.org, idryomov@gmail.com, Michal Hocko , Linux MM , LKML , linux-scsi@vger.kernel.org, linux-fsdevel , linux-block@vger.kernel.org, martin@urbackup.org, Damien.LeMoal@wdc.com, Michal Hocko , Masato Suzuki Subject: Re: [PATCH] Add prctl support for controlling mem reclaim V4 Message-ID: <20200127130258.2bknkl3mwpkfyml4@wittgenstein> References: <20191112001900.9206-1-mchristi@redhat.com> <5E2B19C9.6080907@redhat.com> <20200124211642.GB7216@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200124211642.GB7216@dread.disaster.area> User-Agent: NeoMutt/20180716 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Jan 25, 2020 at 08:16:42AM +1100, Dave Chinner wrote: > On Fri, Jan 24, 2020 at 10:22:33AM -0600, Mike Christie wrote: > > On 12/05/2019 04:43 PM, Shakeel Butt wrote: > > > On Mon, Nov 11, 2019 at 4:19 PM Mike Christie wrote: > > >> This patch adds a new prctl command that daemons can use after they have > > >> done their initial setup, and before they start to do allocations that > > >> are in the IO path. It sets the PF_MEMALLOC_NOIO and PF_LESS_THROTTLE > > >> flags so both userspace block and FS threads can use it to avoid the > > >> allocation recursion and try to prevent from being throttled while > > >> writing out data to free up memory. > > >> > > >> Signed-off-by: Mike Christie > > >> Acked-by: Michal Hocko > > >> Tested-by: Masato Suzuki > > >> Reviewed-by: Damien Le Moal > > > > > > I suppose this patch should be routed through MM tree, so, CCing Andrew. > > > > > > > Andrew and other mm/storage developers, > > > > Do I need to handle anything else for this patch, or are there any other > > concerns? Is this maybe something we want to talk about at a quick LSF > > session? > > > > I have retested it with Linus's current tree. It still applies cleanly > > (just some offsets), and fixes the problem described above we have been > > hitting. > > I must have missed this version being posted (just looked it up on > lore.kernel.org). As far as I'm concerned this is good to go and it > is absolutely necessary for userspace IO stacks to function > correctly. > > Reviewed-by: Dave Chinner > > If no manintainer picks it up before the next merge window, then I Since prctl() is thread-management and fs people seem to be happy and have acked it I can pick this up too if noone objects and send this along with the rest of process management. Christian