From: Christian Brauner <christian.brauner@ubuntu.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Mike Christie <mchristi@redhat.com>,
Shakeel Butt <shakeelb@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-api@vger.kernel.org, idryomov@gmail.com,
Michal Hocko <mhocko@kernel.org>, Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-scsi@vger.kernel.org,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-block@vger.kernel.org, martin@urbackup.org,
Damien.LeMoal@wdc.com, Michal Hocko <mhocko@suse.com>,
Masato Suzuki <masato.suzuki@wdc.com>
Subject: Re: [PATCH] Add prctl support for controlling mem reclaim V4
Date: Mon, 27 Jan 2020 14:02:59 +0100 [thread overview]
Message-ID: <20200127130258.2bknkl3mwpkfyml4@wittgenstein> (raw)
In-Reply-To: <20200124211642.GB7216@dread.disaster.area>
On Sat, Jan 25, 2020 at 08:16:42AM +1100, Dave Chinner wrote:
> On Fri, Jan 24, 2020 at 10:22:33AM -0600, Mike Christie wrote:
> > On 12/05/2019 04:43 PM, Shakeel Butt wrote:
> > > On Mon, Nov 11, 2019 at 4:19 PM Mike Christie <mchristi@redhat.com> wrote:
> > >> This patch adds a new prctl command that daemons can use after they have
> > >> done their initial setup, and before they start to do allocations that
> > >> are in the IO path. It sets the PF_MEMALLOC_NOIO and PF_LESS_THROTTLE
> > >> flags so both userspace block and FS threads can use it to avoid the
> > >> allocation recursion and try to prevent from being throttled while
> > >> writing out data to free up memory.
> > >>
> > >> Signed-off-by: Mike Christie <mchristi@redhat.com>
> > >> Acked-by: Michal Hocko <mhocko@suse.com>
> > >> Tested-by: Masato Suzuki <masato.suzuki@wdc.com>
> > >> Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
> > >
> > > I suppose this patch should be routed through MM tree, so, CCing Andrew.
> > >
> >
> > Andrew and other mm/storage developers,
> >
> > Do I need to handle anything else for this patch, or are there any other
> > concerns? Is this maybe something we want to talk about at a quick LSF
> > session?
> >
> > I have retested it with Linus's current tree. It still applies cleanly
> > (just some offsets), and fixes the problem described above we have been
> > hitting.
>
> I must have missed this version being posted (just looked it up on
> lore.kernel.org). As far as I'm concerned this is good to go and it
> is absolutely necessary for userspace IO stacks to function
> correctly.
>
> Reviewed-by: Dave Chinner <dchinner@redhat.com>
>
> If no manintainer picks it up before the next merge window, then I
Since prctl() is thread-management and fs people seem to be happy and
have acked it I can pick this up too if noone objects and send this
along with the rest of process management.
Christian
next prev parent reply other threads:[~2020-01-27 13:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 0:19 Mike Christie
2019-11-27 18:07 ` Bart Van Assche
2019-12-05 22:43 ` Shakeel Butt
2020-01-24 16:22 ` Mike Christie
2020-01-24 21:16 ` Dave Chinner
2020-01-27 13:02 ` Christian Brauner [this message]
2020-01-30 14:08 ` Christian Brauner
2020-01-24 22:09 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200127130258.2bknkl3mwpkfyml4@wittgenstein \
--to=christian.brauner@ubuntu.com \
--cc=Damien.LeMoal@wdc.com \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=idryomov@gmail.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin@urbackup.org \
--cc=masato.suzuki@wdc.com \
--cc=mchristi@redhat.com \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=shakeelb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox