From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5C7CC33CB1 for ; Mon, 27 Jan 2020 10:55:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 95BE224658 for ; Mon, 27 Jan 2020 10:55:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ZGqXRv/b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95BE224658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1A75B6B0003; Mon, 27 Jan 2020 05:55:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 157776B0006; Mon, 27 Jan 2020 05:55:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 029926B0007; Mon, 27 Jan 2020 05:55:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0031.hostedemail.com [216.40.44.31]) by kanga.kvack.org (Postfix) with ESMTP id DC7C66B0003 for ; Mon, 27 Jan 2020 05:55:39 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 9EE7A181AEF07 for ; Mon, 27 Jan 2020 10:55:39 +0000 (UTC) X-FDA: 76423108398.19.party19_4e76edd671e09 X-HE-Tag: party19_4e76edd671e09 X-Filterd-Recvd-Size: 4889 Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Mon, 27 Jan 2020 10:55:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580122538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=blPxBDCpyTg8CtnOxgXgFCP3B7KBAzbg43rc9rf9c4g=; b=ZGqXRv/bXciSba6y0+E1LKrGT83eakJUncwsy9hPozfmMcZPVOgR++joQUEwnk+ozfb/kM Is9IEPwVZTfTCsqUnwpe+0TmZuwGMNOvaRS3+byP1GtGWTjV8yFaY5NyElpDNAXMA38yTV 0yFTudbc2o/kUD1YlbMSJTkyMsX3hs4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-54-7Vh1zNO3MGuS5K74ZF6Ohg-1; Mon, 27 Jan 2020 05:55:36 -0500 Received: by mail-wr1-f70.google.com with SMTP id j4so5889627wrs.13 for ; Mon, 27 Jan 2020 02:55:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=C5GoHU21tITOeLGcgSeI5DCMeKnGmZHyFA/f49KFvg0=; b=ozbvD8Ol5WImbdwoPBjR/3GVwTe11QW7/f4eX0GLb1G0csEg3ZGoaNCJT+FS3C04zU MyVsIMJz67h/9DjmthqI58EtX7p7svWQR0bbL1pp6ZQwWnkxw3RvG+bnjPGiOprYcHaV c4ML5Mp3OOubRFf788a/2ka+PxFZaHqBOwvq1ROu6kkU1G5cey/Hf7C/W1V8v41guivD h0ET6dIS8nht+9iWdsQhr/78oHo1PEXkEzFw6erd5BM+n+H3KKdYWBuGaogqkHbMInlc CvcEt0XmtlXbOqeyfBqer2mUgOrXq9DX3XNaZi3Y0IZ2Dm/YyzYmbBI0wPN+CfjJIocB JNNw== X-Gm-Message-State: APjAAAWUFQ0qY+QCeMZOUOft5zQ7uivAhZhUFjBmCqSbL87C9STKikuj gLQ1kFdr+njVAa5OJIlrXRU5U9DgpX+RsPaBd98dnz0tM5Mk7n1PYUsHKZV/W+/WGLjo4co+1X6 +9I3W2zAsSA== X-Received: by 2002:adf:e58d:: with SMTP id l13mr21065274wrm.135.1580122535307; Mon, 27 Jan 2020 02:55:35 -0800 (PST) X-Google-Smtp-Source: APXvYqxmXHDECwNyV4sc/J2dESQugTCA1QujhGGSTGYrOTm4ABN+g+mCYs8AGc58vXWnshCbjImijQ== X-Received: by 2002:adf:e58d:: with SMTP id l13mr21065242wrm.135.1580122535083; Mon, 27 Jan 2020 02:55:35 -0800 (PST) Received: from localhost (cpc111743-lutn13-2-0-cust844.9-3.cable.virginm.net. [82.17.115.77]) by smtp.gmail.com with ESMTPSA id x14sm18076625wmj.42.2020.01.27.02.55.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jan 2020 02:55:34 -0800 (PST) Date: Mon, 27 Jan 2020 10:55:33 +0000 From: Aaron Tomlin To: Tetsuo Handa Cc: Grzegorz Halat , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, ssaner@redhat.com, oleksandr@redhat.com, vbendel@redhat.com, kirill@shutemov.name, khlebnikov@yandex-team.ru, borntraeger@de.ibm.com, Andrew Morton , Iurii Zaikin , Kees Cook , Luis Chamberlain , Jonathan Corbet Subject: Re: [PATCH 1/1] mm: sysctl: add panic_on_mm_error sysctl Message-ID: <20200127105533.azrlz2ff73vrhg6n@atomlin.usersys.com> References: <20200127101100.92588-1-ghalat@redhat.com> <063e702f-dc5f-b0ca-fe26-508a9f1e8e9a@I-love.SAKURA.ne.jp> MIME-Version: 1.0 In-Reply-To: <063e702f-dc5f-b0ca-fe26-508a9f1e8e9a@I-love.SAKURA.ne.jp> X-PGP-Key: http://pgp.mit.edu/pks/lookup?search=atomlin%40redhat.com X-PGP-Fingerprint: 7906 84EB FA8A 9638 8D1E 6E9B E2DE 9658 19CC 77D6 User-Agent: NeoMutt/20180716-1637-ee8449 X-MC-Unique: 7Vh1zNO3MGuS5K74ZF6Ohg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 2020-01-27 19:42 +0900, Tetsuo Handa wrote: > On 2020/01/27 19:11, Grzegorz Halat wrote: > > diff --git a/Documentation/admin-guide/sysctl/kernel.rst b/Documentatio= n/admin-guide/sysctl/kernel.rst > > index def074807cee..2fecd6b2547e 100644 > > --- a/Documentation/admin-guide/sysctl/kernel.rst > > +++ b/Documentation/admin-guide/sysctl/kernel.rst > > @@ -61,6 +61,7 @@ show up in /proc/sys/kernel: > > - overflowgid > > - overflowuid > > - panic > > +- panic_on_mm_error >=20 > Maybe panic_on_inconsistent_mm is better, for an MM error sounds too gene= ric > (e.g. is page allocation failure an error, is OOM killer an error, > is NULL pointer dereference an error, is use-after-free access an error) = ? Fair enough; 'panic_on_inconsistent_mm' is more concise. --=20 Aaron Tomlin