From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DA04C2D0DB for ; Fri, 24 Jan 2020 21:16:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3D9302072C for ; Fri, 24 Jan 2020 21:16:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3D9302072C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=fromorbit.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A0BDD6B0005; Fri, 24 Jan 2020 16:16:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BB696B0006; Fri, 24 Jan 2020 16:16:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D1C06B0007; Fri, 24 Jan 2020 16:16:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0191.hostedemail.com [216.40.44.191]) by kanga.kvack.org (Postfix) with ESMTP id 7401C6B0005 for ; Fri, 24 Jan 2020 16:16:49 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 20F364DC0 for ; Fri, 24 Jan 2020 21:16:49 +0000 (UTC) X-FDA: 76413787338.27.pets41_58918083ad75c X-HE-Tag: pets41_58918083ad75c X-Filterd-Recvd-Size: 3849 Received: from mail104.syd.optusnet.com.au (mail104.syd.optusnet.com.au [211.29.132.246]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Fri, 24 Jan 2020 21:16:48 +0000 (UTC) Received: from dread.disaster.area (pa49-195-162-125.pa.nsw.optusnet.com.au [49.195.162.125]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 991D1820C75; Sat, 25 Jan 2020 08:16:44 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1iv6Jm-00079w-Ii; Sat, 25 Jan 2020 08:16:42 +1100 Date: Sat, 25 Jan 2020 08:16:42 +1100 From: Dave Chinner To: Mike Christie Cc: Shakeel Butt , Andrew Morton , linux-api@vger.kernel.org, idryomov@gmail.com, Michal Hocko , Linux MM , LKML , linux-scsi@vger.kernel.org, linux-fsdevel , linux-block@vger.kernel.org, martin@urbackup.org, Damien.LeMoal@wdc.com, Michal Hocko , Masato Suzuki Subject: Re: [PATCH] Add prctl support for controlling mem reclaim V4 Message-ID: <20200124211642.GB7216@dread.disaster.area> References: <20191112001900.9206-1-mchristi@redhat.com> <5E2B19C9.6080907@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5E2B19C9.6080907@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=LYdCFQXi c=1 sm=1 tr=0 a=eqEhQ2W7mF93FbYHClaXRw==:117 a=eqEhQ2W7mF93FbYHClaXRw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=Jdjhy38mL1oA:10 a=20KFwNOVAAAA:8 a=iox4zFpeAAAA:8 a=JF9118EUAAAA:8 a=VwQbUJbxAAAA:8 a=7-415B0cAAAA:8 a=3XgbrJ93Oiw9jx1WlK8A:9 a=CjuIK1q_8ugA:10 a=WzC6qhA0u3u7Ye7llzcV:22 a=xVlTc564ipvMDusKsbsT:22 a=AjGcO6oz07-iQ99wixmX:22 a=biEYGPWJfzWAr4FL6Ov7:22 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jan 24, 2020 at 10:22:33AM -0600, Mike Christie wrote: > On 12/05/2019 04:43 PM, Shakeel Butt wrote: > > On Mon, Nov 11, 2019 at 4:19 PM Mike Christie wrote: > >> This patch adds a new prctl command that daemons can use after they have > >> done their initial setup, and before they start to do allocations that > >> are in the IO path. It sets the PF_MEMALLOC_NOIO and PF_LESS_THROTTLE > >> flags so both userspace block and FS threads can use it to avoid the > >> allocation recursion and try to prevent from being throttled while > >> writing out data to free up memory. > >> > >> Signed-off-by: Mike Christie > >> Acked-by: Michal Hocko > >> Tested-by: Masato Suzuki > >> Reviewed-by: Damien Le Moal > > > > I suppose this patch should be routed through MM tree, so, CCing Andrew. > > > > Andrew and other mm/storage developers, > > Do I need to handle anything else for this patch, or are there any other > concerns? Is this maybe something we want to talk about at a quick LSF > session? > > I have retested it with Linus's current tree. It still applies cleanly > (just some offsets), and fixes the problem described above we have been > hitting. I must have missed this version being posted (just looked it up on lore.kernel.org). As far as I'm concerned this is good to go and it is absolutely necessary for userspace IO stacks to function correctly. Reviewed-by: Dave Chinner If no manintainer picks it up before the next merge window, then I recommend resending the latest version to Linus asking him to merge it. Cheers, Dave. -- Dave Chinner david@fromorbit.com