From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE986C35242 for ; Fri, 24 Jan 2020 12:45:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 808BF2075D for ; Fri, 24 Jan 2020 12:45:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 808BF2075D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D378F6B0270; Fri, 24 Jan 2020 07:45:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CE91C6B0271; Fri, 24 Jan 2020 07:45:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFE026B0272; Fri, 24 Jan 2020 07:45:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0189.hostedemail.com [216.40.44.189]) by kanga.kvack.org (Postfix) with ESMTP id ABA9B6B0270 for ; Fri, 24 Jan 2020 07:45:15 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 679B4181AEF1D for ; Fri, 24 Jan 2020 12:45:15 +0000 (UTC) X-FDA: 76412498190.30.way29_852185bcddf47 X-HE-Tag: way29_852185bcddf47 X-Filterd-Recvd-Size: 3683 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Fri, 24 Jan 2020 12:45:14 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id t23so1557565wmi.1 for ; Fri, 24 Jan 2020 04:45:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=j+mBBTpQJ4wbg8K52L8M4km/ID9qCvpn337om+dHJcg=; b=jkGHFKzEynWw4yy7O3f4qs0fe0w6/iuXIupb8MFz1rC77Y7uvyzcldwhZTidTRzye2 yjgTWbe7/n1I8XXofNwO4H34pHIFQA0zYObadToqVi0QBEflHkcx4IpRHJiyXDvO++EO K0a1exVazPBgAQ7/lLjMhS9B6r9YBfCGivZg0XhvVz2nhcQCAPd5zr1Z9aydTyQT2y48 b3iQLxbDomtuFjGDCmJhKt7bdFhy/5ni0v9D2VrxG503UUXlbuKulch9BILU5jrU45cm Hz4jLxG2x+Bo7/4yisu+Jw1KMvQxSzLQkSh+mlkJzpANFmqVNauGl9yY4JI0B2Rt0Bq2 4ybA== X-Gm-Message-State: APjAAAVodz39FhafJHaTW8QxqKwc7gO2epi9j+K1420XJu0eJqAN70gi z0cRtXRurmhQ1wurx2LfCw4= X-Google-Smtp-Source: APXvYqw48IZitTegCDEqW/DRYA1NjgNNLdiLHQ9/3fjlhxhOgsQMrqFvY7FUdFcstQQHzviWIpDW8Q== X-Received: by 2002:a1c:bc08:: with SMTP id m8mr2654997wmf.189.1579869913658; Fri, 24 Jan 2020 04:45:13 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id g25sm14465121wmh.3.2020.01.24.04.45.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jan 2020 04:45:12 -0800 (PST) Date: Fri, 24 Jan 2020 13:45:12 +0100 From: Michal Hocko To: Dan Williams Cc: David Hildenbrand , Andrew Morton , stable , Vishal Verma , Pavel Tatashin , Dave Hansen , Linux MM , Linux Kernel Mailing List Subject: Re: [PATCH] mm/memory_hotplug: Fix remove_memory() lockdep splat Message-ID: <20200124124512.GT29276@dhcp22.suse.cz> References: <4d0334e2-c4e7-6d3f-99ba-2ca0495e1549@redhat.com> <64902066-51dd-9693-53fc-4a5975c58409@redhat.com> <516aa930-9b64-b377-557c-5413ed9fe336@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 10-01-20 13:27:24, Dan Williams wrote: > On Fri, Jan 10, 2020 at 9:42 AM David Hildenbrand wrote: [...] > > For your reference (roughly 5 months ago, so not that old) > > > > https://lkml.kernel.org/r/20190724143017.12841-1-david@redhat.com > > Oh, now I see the problem. You need to add that lock so far away from > the __add_memory() to avoid lock inversion problems with the > acpi_scan_lock. The organization I was envisioning would not work > without deeper refactoring. Sorry to come back to this late. Has this been resolved? -- Michal Hocko SUSE Labs