From: Matthew Wilcox <willy@infradead.org>
To: Qian Cai <cai@lca.pw>
Cc: Peter Zijlstra <peterz@infradead.org>,
mingo@redhat.com, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
paulmck@kernel.org, tglx@linutronix.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
Matt Turner <mattst88@gmail.com>,
linux-parisc@vger.kernel.org, Helge Deller <deller@gmx.de>
Subject: Re: [PATCH v2] sched/core: fix illegal RCU from offline CPUs
Date: Thu, 23 Jan 2020 21:02:02 -0800 [thread overview]
Message-ID: <20200124050202.GJ4675@bombadil.infradead.org> (raw)
In-Reply-To: <A72A7F42-A166-4403-B12C-32B2D7A662C4@lca.pw>
On Thu, Jan 23, 2020 at 11:21:35PM -0500, Qian Cai wrote:
> > On Jan 21, 2020, at 5:35 AM, Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > Something like this; except you'll need to go audit archs to make sure
> > they all call idle_task_exit() and/or put in comments on why they don't
> > have to (perhaps their bringup switches them to &init_mm unconditionally
> > and the switch_mm() is not required).
>
> Damn, I am having a hard time to motivate myself to learn all about those two “dead“ arches from scratch. I suppose the first step we could put a dummy finish_cpu() for alpha and parisc if they don’t call idle_task_exit() in the first place anyway, so if it is a bug there it is another issue that could be dealt with in a separate patch later?
Or you could consult the maintainers of those architectures? There are regular pull requests for parisc still, and alpha still gets odd fixes.
It would have helped had you not trimmed the context so aggressively.
For those seeing this thread for the first time, try:
https://lore.kernel.org/linux-mm/A72A7F42-A166-4403-B12C-32B2D7A662C4@lca.pw/T/#t
next prev parent reply other threads:[~2020-01-24 5:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 19:03 Qian Cai
2020-01-20 10:16 ` Peter Zijlstra
2020-01-20 20:35 ` Qian Cai
2020-01-21 10:35 ` Peter Zijlstra
2020-01-24 4:21 ` Qian Cai
2020-01-24 5:02 ` Matthew Wilcox [this message]
2020-03-30 2:42 ` Qian Cai
2020-04-01 21:05 ` Qian Cai
2020-04-01 21:40 Qian Cai
2020-04-02 11:24 ` Michael Ellerman
2020-04-02 14:00 ` Qian Cai
2020-04-02 15:54 ` Paul E. McKenney
2020-04-02 16:19 ` Qian Cai
2020-04-02 16:57 ` Paul E. McKenney
2020-04-17 13:26 ` Qian Cai
2020-04-21 13:56 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200124050202.GJ4675@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=bsegall@google.com \
--cc=cai@lca.pw \
--cc=deller@gmx.de \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=mattst88@gmail.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox