From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=CHARSET_FARAWAY_HEADER, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D88FC35240 for ; Fri, 24 Jan 2020 02:36:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1923E2087E for ; Fri, 24 Jan 2020 02:36:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=necglobal.onmicrosoft.com header.i=@necglobal.onmicrosoft.com header.b="JHmoEiQK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1923E2087E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=nec.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A1ED86B026F; Thu, 23 Jan 2020 21:36:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CD776B02A2; Thu, 23 Jan 2020 21:36:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 895B46B02A3; Thu, 23 Jan 2020 21:36:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0043.hostedemail.com [216.40.44.43]) by kanga.kvack.org (Postfix) with ESMTP id 758806B026F for ; Thu, 23 Jan 2020 21:36:15 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 28D104833 for ; Fri, 24 Jan 2020 02:36:15 +0000 (UTC) X-FDA: 76410963510.22.north46_366a23971c351 X-HE-Tag: north46_366a23971c351 X-Filterd-Recvd-Size: 7404 Received: from JPN01-TY1-obe.outbound.protection.outlook.com (mail-eopbgr1400087.outbound.protection.outlook.com [40.107.140.87]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Fri, 24 Jan 2020 02:36:13 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H67ors4BLl/vjes3k2RMm0WA+Oacau6UAmJiYJIqpdSMpu89B6Oa9mF/7N10Wnm3CMfG1xxmcWifMkLVhdSAAqV3rusqcqaAs5h2fiADgRtGd+wTeCRVVmMAXlwoeWp4QzrU8Cfp8DH5/nWhLuV8HsfYfU63WciQ/+yZf1zcwpJZ5GQag9i8au7pdxclu1RKs+K23itKSiJtqBDOY+5kwVZt/kLUrL24EaiZEzNBe1nZ8iWODaS83ynN8ijEqP7vmXELFLJ5QRbyP85qN3d9iZ1BRvIrTuJB04nO/nuANYb69/CFfpfKO3lH0yYUKtn480tN3yx/XSZZvPRDYpqArQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ySBTTWy1gW1ldPHYuCZpKPJbzrxyDsqksp7NeCpgMRw=; b=itjVOjlXX2SZFnfe7PJkq3Ss+upEsU7JSdatVE0TIIeOKc9JrdQ4P5020iSFmokvVjjoHZT+zAabsisuSiCMHYP2KcwSTV94MHL+QHZYjCDlgjSqmDKrKKqLfVKGNz+HFmzHnWWoynvwaut4UZRrPnQvUy4Qi1FO3A1Maj+XSRwwZmEQ27YSEwoOXT+VaUe+cNfC7p9gWQJWrk4rbge2oktkjirK43wEE1kcSmRt2c8TOJwZ872d/K+UmtQXfFeUpdnDYTljA21SQezsjuNAVletd7RmvNP1yR0L7a6VfkpgQQ95rmnl5S9NLU+45/tcGVRjsYBpvMMyKbAqWpdhZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nec.com; dmarc=pass action=none header.from=nec.com; dkim=pass header.d=nec.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=necglobal.onmicrosoft.com; s=selector1-necglobal-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ySBTTWy1gW1ldPHYuCZpKPJbzrxyDsqksp7NeCpgMRw=; b=JHmoEiQK7AQk1J0JtqJeQkcpCB6FNixSqPdYD4dUgAs1LI27QzzeI+GmvJ8k0sTgfqlEO+MSn+V27rOYWXVBCtpgUX3tGP/UrsG61mrJtxoQQbd2cQwGqHPRDU8B260EURbRDHGpJFz0/x8ZxJnG0+WBlhFnoPv+zlzsA6XHZB8= Received: from OSBPR01MB1752.jpnprd01.prod.outlook.com (52.134.227.11) by OSBPR01MB4663.jpnprd01.prod.outlook.com (20.179.181.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2644.23; Fri, 24 Jan 2020 02:36:07 +0000 Received: from OSBPR01MB1752.jpnprd01.prod.outlook.com ([fe80::2de4:5005:518e:7f64]) by OSBPR01MB1752.jpnprd01.prod.outlook.com ([fe80::2de4:5005:518e:7f64%3]) with mapi id 15.20.2644.028; Fri, 24 Jan 2020 02:36:07 +0000 From: =?iso-2022-jp?B?SE9SSUdVQ0hJIE5BT1lBKBskQktZOH0hIUQ+TGkbKEIp?= To: Li Xinhai CC: "linux-mm@kvack.org" , "akpm@linux-foundation.org" , Michal Hocko , Mike Kravetz , Anshuman Khandual , Naoya Horiguchi Subject: Re: [PATCH v5] mm/mempolicy: Checking hugepage migration is supported by arch in vma_migratable Thread-Topic: [PATCH v5] mm/mempolicy: Checking hugepage migration is supported by arch in vma_migratable Thread-Index: AQHV0fF06vAZFOFJdkKjD85UJfpWYKf5GisA Date: Fri, 24 Jan 2020 02:36:07 +0000 Message-ID: <20200124023606.GA16701@hori.linux.bs1.fc.nec.co.jp> References: <1579786179-30633-1-git-send-email-lixinhai.lxh@gmail.com> In-Reply-To: <1579786179-30633-1-git-send-email-lixinhai.lxh@gmail.com> Accept-Language: ja-JP, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=naoya.horiguchi@nec.com; x-originating-ip: [165.225.110.211] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 97722ad3-b6e1-4cfd-270e-08d7a0762a67 x-ms-traffictypediagnostic: OSBPR01MB4663: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 02929ECF07 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(39860400002)(346002)(376002)(136003)(396003)(366004)(189003)(199004)(64756008)(66446008)(81166006)(66476007)(91956017)(76116006)(66556008)(86362001)(55236004)(66946007)(186003)(33656002)(9686003)(6506007)(8936002)(6512007)(71200400001)(6486002)(85182001)(26005)(81156014)(316002)(6916009)(8676002)(478600001)(54906003)(1076003)(5660300002)(4326008)(2906002);DIR:OUT;SFP:1101;SCL:1;SRVR:OSBPR01MB4663;H:OSBPR01MB1752.jpnprd01.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: nec.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: w+eUwPCmwuEfTwzv4vgjWJlzOSdtZc3/XO7XnI7KJLqxOFQsTr4Lti0h3TavDAL+LXqdtQCxYzdSNDaRFrM1cuLjISoGJYnOTWSuQkJkkWLvIS+sJuzWPT9U4VB79wOazYdG1X18IBAvB5lxZw+DrEt5a7l0sT15B98yl8SB84ReeOslNSbNUA4vLvJ8B05aLgwN3u1/YWyO2TZSKY2gN3BJbMY162DZHvfjfXrqt8yPQlLxWP7vVZBxIszu6URU6oDWnT3kRZeSVc2CJ7F1JumP3BpEp1GwZ5b/WUtJ7bmjicjnmvD/UGxqVog9rKf8A2LXklypFbVJ+xIlgx/LZ8H8MJDn/6/uWwZWUx3K7vNrpdnUoZyLNZdE3jQrD5I/RJmCQrPeiDxVpK1hOwJ2Pww9O0WHTbq09QlV8n5RmG2c2SLHjJc6naw7GgBV6l5i Content-Type: text/plain; charset="iso-2022-jp" Content-ID: <2560A31503C16C409D8961E6124E8620@jpnprd01.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nec.com X-MS-Exchange-CrossTenant-Network-Message-Id: 97722ad3-b6e1-4cfd-270e-08d7a0762a67 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jan 2020 02:36:07.3043 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: e67df547-9d0d-4f4d-9161-51c6ed1f7d11 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wjwAMN4ERhu+krLrQZKzcbayzIVqtt+ccZA1wmFop9Lu6wWhYL8fMznOl+8ANbEoc1NBBe5doZf8NCt35wR1ZA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSBPR01MB4663 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 23, 2020 at 01:29:39PM +0000, Li Xinhai wrote: > vma_migratable() is called to check if pages in vma can be migrated > before go ahead to further actions. Currently it is used in below code > path: > - task_numa_work > - mbind > - move_pages >=20 > For hugetlb mapping, whether vma is migratable or not is determined by: > - CONFIG_ARCH_ENABLE_HUGEPAGE_MIGRATION > - arch_hugetlb_migration_supported >=20 > Issue: current code only checks for CONFIG_ARCH_ENABLE_HUGEPAGE_MIGRATION > alone, and no code should use it directly. (note that current code in > vma_migratable don't cause failure or bug because > unmap_and_move_huge_page() will catch unsupported hugepage and handle it > properly) >=20 > This patch checks the two factors by hugepage_migration_supported for > impoving code logic and robustness. It will enable early bail out of > hugepage migration procedure, but because currently all architecture > supporting hugepage migration is able to support all page size, we would > not see performance gain with this patch applied. >=20 > vma_migratable() is moved to mm/mempolicy.c, because of the circular > reference of mempolicy.h and hugetlb.h cause defining it as inline not > feasible. >=20 > Signed-off-by: Li Xinhai > Cc: Michal Hocko > Cc: Mike Kravetz > Cc: Anshuman Khandual > Cc: Naoya Horiguchi Reviewed-by: Naoya Horiguchi =