From: Michal Hocko <mhocko@kernel.org>
To: David Rientjes <rientjes@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Wei Yang <richardw.yang@linux.intel.com>,
hannes@cmpxchg.org, vdavydov.dev@gmail.com, ktkhai@virtuozzo.com,
kirill.shutemov@linux.intel.com, yang.shi@linux.alibaba.com,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, alexander.duyck@gmail.com,
stable@vger.kernel.org
Subject: Re: [Patch v4] mm: thp: remove the defer list related code since this will not happen
Date: Mon, 20 Jan 2020 22:27:26 +0100 [thread overview]
Message-ID: <20200120212726.GB29276@dhcp22.suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.21.2001201307520.259466@chino.kir.corp.google.com>
On Mon 20-01-20 13:10:56, David Rientjes wrote:
> On Mon, 20 Jan 2020, Michal Hocko wrote:
>
> > > When migrating memcg charges of thp memory, there are two possibilities:
> > >
> > > (1) The underlying compound page is mapped by a pmd and thus does is not
> > > on a deferred split queue (it's mapped), or
> > >
> > > (2) The compound page is not mapped by a pmd and is awaiting split on a
> > > deferred split queue.
> > >
> > > The current charge migration implementation does *not* migrate charges for
> > > thp memory on the deferred split queue, it only migrates charges for pages
> > > that are mapped by a pmd.
> > >
> > > Thus, to migrate charges, the underlying compound page cannot be on a
> > > deferred split queue; no list manipulation needs to be done in
> > > mem_cgroup_move_account().
> > >
> > > With the current code, the underlying compound page is moved to the
> > > deferred split queue of the memcg its memory is not charged to, so
> > > susbequent reclaim will consider these pages for the wrong memcg. Remove
> > > the deferred split queue handling in mem_cgroup_move_account() entirely.
> >
> > I believe this still doesn't describe the underlying problem to the full
> > extent. What happens with the page on the deferred list when it
> > shouldn't be there in fact? Unless I am missing something deferred_split_scan
> > will simply split that huge page. Which is a bit unfortunate but nothing
> > really critical. This should be mentioned in the changelog.
> >
>
> Are you referring to a compound page on the deferred split queue before a
> task is moved? I'm not sure this is within the scope of Wei's patch..
> this is simply preventing a page from being moved to the deferred split
> queue of a memcg that it is not charged to. Is there a concern about why
> this code can be removed or a suggestion on something else it should be
> doing instead?
No, I do not have any concern about the patch itslef. It is that the
changelog doesn't decribe the user visible effect. All I am saying is
that the current code splits THPs of moved pages under memory pressure
even if that is not needed. And that is a clear bug.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-01-20 21:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 23:38 Wei Yang
2020-01-18 0:57 ` Yang Shi
2020-01-18 5:30 ` Yang Shi
2020-01-18 22:54 ` Andrew Morton
2020-01-18 23:36 ` David Rientjes
2020-01-19 2:24 ` Wei Yang
2020-01-20 7:22 ` Michal Hocko
2020-01-20 8:17 ` Wei Yang
2020-01-20 21:10 ` David Rientjes
2020-01-20 21:27 ` Michal Hocko [this message]
2020-01-21 23:08 ` David Rientjes
2020-01-22 8:14 ` Michal Hocko
2020-01-22 23:39 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120212726.GB29276@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.duyck@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=ktkhai@virtuozzo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richardw.yang@linux.intel.com \
--cc=rientjes@google.com \
--cc=stable@vger.kernel.org \
--cc=vdavydov.dev@gmail.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox