From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77CF1C2D0DB for ; Mon, 20 Jan 2020 10:03:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 43BC420882 for ; Mon, 20 Jan 2020 10:03:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 43BC420882 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D7AEC6B0622; Mon, 20 Jan 2020 05:03:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D2AB06B0623; Mon, 20 Jan 2020 05:03:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF3546B0624; Mon, 20 Jan 2020 05:03:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0137.hostedemail.com [216.40.44.137]) by kanga.kvack.org (Postfix) with ESMTP id A4D0A6B0622 for ; Mon, 20 Jan 2020 05:03:31 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 4F0E2181AC9B6 for ; Mon, 20 Jan 2020 10:03:31 +0000 (UTC) X-FDA: 76397575422.07.cows87_58e5b78366e09 X-HE-Tag: cows87_58e5b78366e09 X-Filterd-Recvd-Size: 4268 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Jan 2020 10:03:30 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id d16so28841827wre.10 for ; Mon, 20 Jan 2020 02:03:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Cu8cSR4Bnec+tkaO+g7MgIEFj+2elstBE2vN31ryndg=; b=Z3Vd8nYKYKvr1D8v5QY9goEQoaKTdnNG9IqUBh6aQ/ATHbvyj+XDuMYnrNQdHCXc03 AjoiWMmqsASFWkMPptOul1i2/kQD+6mkDq4hsK5XL+GebLqh5gK+jfPnF2sEJKHYkbxX J6HCaTDNQ+yNBH5U/j7jjJjNx1DOdLxL1BXcJuilUYDH5KAiN+F2uznwhAMxi4tOscE2 aaFkQpVl7eKTvRPgiMApTn3dFI3dWxALNDpmCEQosmfiSf5y4LiX+HyXw9HpLRp6gAaw ZDVOSkXgMsaIb5pNWvTKCXX+lmJ5SlmtSBd/Q/noG9Pa8LG4suiYEiePfUmfegsPe/mo ZBiw== X-Gm-Message-State: APjAAAV2iYsmX8K/cBpvaI6rN0fGCBLQ17KWeu1y8owwHFabzX3/N+0F A4X/8APGVdz+C69b1qsm2fM= X-Google-Smtp-Source: APXvYqyeM74K8SE2MiQArXPNtrR2i6KIc9h5W4nRAi55aZJhvwJKkUh14I86FL6zXu60sfokmBKNUg== X-Received: by 2002:a5d:4e90:: with SMTP id e16mr17068286wru.318.1579514609772; Mon, 20 Jan 2020 02:03:29 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id i11sm48193424wrs.10.2020.01.20.02.03.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2020 02:03:29 -0800 (PST) Date: Mon, 20 Jan 2020 11:03:28 +0100 From: Michal Hocko To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yang.shi@linux.alibaba.com Subject: Re: [PATCH 8/8] mm/migrate.c: use break instead of goto out_flush Message-ID: <20200120100328.GS18451@dhcp22.suse.cz> References: <20200119030636.11899-1-richardw.yang@linux.intel.com> <20200119030636.11899-9-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200119030636.11899-9-richardw.yang@linux.intel.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun 19-01-20 11:06:36, Wei Yang wrote: > Label out_flush is just outside the loop, so break the loop is enough. I find the explicit label easier to follow than breaking out of the loop. Especially when there is another break out of the loop with a different label. While the patch is correct I find the resulting code worse readable. > Signed-off-by: Wei Yang > --- > mm/migrate.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 2a857fec65b6..59bfae11b9d6 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1621,22 +1621,22 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, > > err = -EFAULT; > if (get_user(p, pages + i)) > - goto out_flush; > + break; > if (get_user(node, nodes + i)) > - goto out_flush; > + break; > addr = (unsigned long)untagged_addr(p); > > /* Check node if it is not checked. */ > if (current_node == NUMA_NO_NODE || node != current_node) { > err = -ENODEV; > if (node < 0 || node >= MAX_NUMNODES) > - goto out_flush; > + break; > if (!node_state(node, N_MEMORY)) > - goto out_flush; > + break; > > err = -EACCES; > if (!node_isset(node, task_nodes)) > - goto out_flush; > + break; > } > > if (current_node == NUMA_NO_NODE) { > @@ -1676,9 +1676,9 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, > */ > err = store_status(status, i, err ? : current_node, 1); > if (err) > - goto out_flush; > + break; > } > -out_flush: > + > /* Make sure we do not overwrite the existing error */ > err1 = move_pages_and_store_status(mm, current_node, &pagelist, > status, start, i - start - need_move); > -- > 2.17.1 -- Michal Hocko SUSE Labs