From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30D6CC33CA1 for ; Mon, 20 Jan 2020 09:52:20 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E52BF20684 for ; Mon, 20 Jan 2020 09:52:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E52BF20684 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 93CF76B061C; Mon, 20 Jan 2020 04:52:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8ED616B061D; Mon, 20 Jan 2020 04:52:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8040A6B061E; Mon, 20 Jan 2020 04:52:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id 6B4CD6B061C for ; Mon, 20 Jan 2020 04:52:19 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 15473824805A for ; Mon, 20 Jan 2020 09:52:19 +0000 (UTC) X-FDA: 76397547198.15.roof39_88996a6db4110 X-HE-Tag: roof39_88996a6db4110 X-Filterd-Recvd-Size: 3876 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Jan 2020 09:52:18 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id c9so28796016wrw.8 for ; Mon, 20 Jan 2020 01:52:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/XDRKRWs/7afQD8wftzTNmMDKMYFRM/TiFXtp/+Eay0=; b=n01w5f6qkrhpcShCqYmB+mzDqq2rQF5xr3GCI1rHu1PyDpYF4cLBNeeG4FLh8gXUzR SaoGXN4OwxAasz0r2YdO8QkP6ba733RFYMYvAF2WGTo2XbBzPbg/d1z+iNpGYKpAs8nw a+ju8bqF9I6PZDxwp8ja6KvspLmVV5wHwS1XiLMPql6oVjlATk78yN4uEG8M8HNQd1Be KQD4gX13j8wZhc1Gc4R4GGkpkpWY4EbKyOkD5HpprcPMOtRT4I1GK6j6az5lUE2KDVkn EmlcHeOA49ta79ZoDS7Ksb1fNpSvGoGJygtbr5iM31P39my0qeVFq6zyqVsH3q9G+LCr vRMA== X-Gm-Message-State: APjAAAUlRUkSvsqCEy5CQzOid9/S9ehnhApNh6kdBsXyk+z35Hthk25m E42LIVT+QlchQH4Q+LGq5WI= X-Google-Smtp-Source: APXvYqxcymRyPNKMjpoBPkn7wtt/4tzG9Vd2FIC7TiSSQy4znwuHN2D83WbqjiVME/MbH0fsPNHlEQ== X-Received: by 2002:adf:fc08:: with SMTP id i8mr16992217wrr.82.1579513937580; Mon, 20 Jan 2020 01:52:17 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id h2sm47742726wrv.66.2020.01.20.01.52.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2020 01:52:16 -0800 (PST) Date: Mon, 20 Jan 2020 10:52:16 +0100 From: Michal Hocko To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yang.shi@linux.alibaba.com Subject: Re: [PATCH 5/8] mm/migrate.c: check pagelist in move_pages_and_store_status() Message-ID: <20200120095216.GP18451@dhcp22.suse.cz> References: <20200119030636.11899-1-richardw.yang@linux.intel.com> <20200119030636.11899-6-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200119030636.11899-6-richardw.yang@linux.intel.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun 19-01-20 11:06:33, Wei Yang wrote: > When pagelist is empty, it is not necessary to do the move and store. > Also it consolidate the empty list check in one place. OK looks good to me. > Signed-off-by: Wei Yang Acked-by: Michal Hocko > --- > mm/migrate.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index dec147d3a4dd..46a5697b7fc6 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1499,9 +1499,6 @@ static int do_move_pages_to_node(struct mm_struct *mm, > { > int err; > > - if (list_empty(pagelist)) > - return 0; > - > err = migrate_pages(pagelist, alloc_new_node_page, NULL, node, > MIGRATE_SYNC, MR_SYSCALL); > if (err) > @@ -1589,6 +1586,9 @@ static int move_pages_and_store_status(struct mm_struct *mm, int node, > { > int err; > > + if (list_empty(pagelist)) > + return 0; > + > err = do_move_pages_to_node(mm, pagelist, node); > if (err) > return err; > @@ -1679,9 +1679,6 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, > current_node = NUMA_NO_NODE; > } > out_flush: > - if (list_empty(&pagelist)) > - return err; > - > /* Make sure we do not overwrite the existing error */ > err1 = move_pages_and_store_status(mm, current_node, &pagelist, > status, start, i - start); > -- > 2.17.1 > -- Michal Hocko SUSE Labs