From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02988C33CA1 for ; Mon, 20 Jan 2020 09:46:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BAA0E207E0 for ; Mon, 20 Jan 2020 09:46:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAA0E207E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6D0CD6B0618; Mon, 20 Jan 2020 04:46:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 659F56B0619; Mon, 20 Jan 2020 04:46:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 522896B061A; Mon, 20 Jan 2020 04:46:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0208.hostedemail.com [216.40.44.208]) by kanga.kvack.org (Postfix) with ESMTP id 391B96B0618 for ; Mon, 20 Jan 2020 04:46:11 -0500 (EST) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id D58F7181AC9C6 for ; Mon, 20 Jan 2020 09:46:10 +0000 (UTC) X-FDA: 76397531700.15.wave69_52fff5b611a07 X-HE-Tag: wave69_52fff5b611a07 X-Filterd-Recvd-Size: 3577 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Mon, 20 Jan 2020 09:46:10 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id p17so14011164wmb.0 for ; Mon, 20 Jan 2020 01:46:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7VdZ/NoDHGeQH6szStgVZMI/Om0YjW5KDW+nhhNOKoM=; b=K23Xj3e4rj+QtgL3/XSLoq/n1SAdDPwjEeTimJDYNceJfHN+Ic3EHB3IC35Xbd+PE5 QK3WGH5gvMp5e64RciYZMbDJk9lT/GRtvmh42p7PUE94p77Umvkeo0fcq17UamTA6UJI dh0s+n07BKCwkuc5AZhbu+PJdmGYPojpTE8qrm4CxhnTo3KbNyRS5VAFstKvXnhBPCek 4Ex+Iqpwyw9dbGqG5tKgK9oRRkmJW15ybu8nKeGlhY8CsaFeJKdR0sdv1Hlu08qZgDeU KNZ32LEtMgwtsmma9iogXZAVv41vBOl4z85F2zazwSv5A0UbfGqjkij7ofHNYNe63C2b xGRw== X-Gm-Message-State: APjAAAW4GPCpAxEio4U4it7JwnO3838UmV+IJrd1+18Z39WelNBw2nxy tj6ElS9AnheUmJBHXqx8pQo= X-Google-Smtp-Source: APXvYqxM7jP8cdx1zoiU5qPY6FvD+Yg/kKa29PNdtbxeY1ZUp9dV3R2HEWwOH0P9oVr8F5kiUj16vg== X-Received: by 2002:a05:600c:24d1:: with SMTP id 17mr17967184wmu.188.1579513569343; Mon, 20 Jan 2020 01:46:09 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id j12sm50668940wrw.54.2020.01.20.01.46.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jan 2020 01:46:08 -0800 (PST) Date: Mon, 20 Jan 2020 10:46:08 +0100 From: Michal Hocko To: Wei Yang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yang.shi@linux.alibaba.com Subject: Re: [PATCH 3/8] mm/migrate.c: reform the last call on do_move_pages_to_node() Message-ID: <20200120094608.GN18451@dhcp22.suse.cz> References: <20200119030636.11899-1-richardw.yang@linux.intel.com> <20200119030636.11899-4-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200119030636.11899-4-richardw.yang@linux.intel.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun 19-01-20 11:06:31, Wei Yang wrote: > No functional change, just reform it to make it as the same shape as > other calls on do_move_pages_to_node(). > > This is a preparation for further cleanup. > > Signed-off-by: Wei Yang > --- > mm/migrate.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index c3ef70de5876..4a63fb8fbb6d 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1675,8 +1675,12 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes, > > /* Make sure we do not overwrite the existing error */ > err1 = do_move_pages_to_node(mm, &pagelist, current_node); > - if (!err1) > - err1 = store_status(status, start, current_node, i - start); > + if (err1) { > + if (err >= 0) > + err = err1; > + goto out; > + } > + err1 = store_status(status, start, current_node, i - start); Please don't. This just makes the code harder to follow. The current err and err1 is already quite ugly so do not make it more so. > if (err >= 0) > err = err1; > out: > -- > 2.17.1 -- Michal Hocko SUSE Labs