From: Michal Hocko <mhocko@kernel.org>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, yang.shi@linux.alibaba.com
Subject: Re: [PATCH 2/8] mm/migrate.c: not necessary to check start and i
Date: Mon, 20 Jan 2020 10:45:03 +0100 [thread overview]
Message-ID: <20200120094503.GM18451@dhcp22.suse.cz> (raw)
In-Reply-To: <20200119030636.11899-3-richardw.yang@linux.intel.com>
On Sun 19-01-20 11:06:30, Wei Yang wrote:
> Till here, i must no less than start. And if i equals to start,
> store_status() would always return 0.
>
> Remove some unnecessary check to make it easy to read and prepare for
> further cleanup.
You are right. This is likely a left over from the development.
i >= start because the former is the actual iterator and start is the
first index with the cached node.
Dropping the check improves readability because one might indeed wonder
why this is the only place to do the check and the overal iteration is
complex enough to add more questions on top.
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Thanks!
> ---
> mm/migrate.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/mm/migrate.c b/mm/migrate.c
> index ba7cf4fa43a0..c3ef70de5876 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -1664,11 +1664,9 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes,
> err = do_move_pages_to_node(mm, &pagelist, current_node);
> if (err)
> goto out;
> - if (i > start) {
> - err = store_status(status, start, current_node, i - start);
> - if (err)
> - goto out;
> - }
> + err = store_status(status, start, current_node, i - start);
> + if (err)
> + goto out;
> current_node = NUMA_NO_NODE;
> }
> out_flush:
> --
> 2.17.1
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-01-20 9:45 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 3:06 [PATCH 0/8] mm/migrate.c: cleanup on do_pages_move() Wei Yang
2020-01-19 3:06 ` [PATCH 1/8] mm/migrate.c: skip node check if done in last round Wei Yang
2020-01-20 9:36 ` Michal Hocko
2020-01-20 22:25 ` Wei Yang
2020-01-21 8:42 ` Michal Hocko
2020-01-22 0:36 ` Wei Yang
2020-01-22 8:16 ` Michal Hocko
2020-01-19 3:06 ` [PATCH 2/8] mm/migrate.c: not necessary to check start and i Wei Yang
2020-01-19 22:14 ` David Rientjes
2020-01-20 0:31 ` Wei Yang
2020-01-20 9:45 ` Michal Hocko [this message]
2020-01-19 3:06 ` [PATCH 3/8] mm/migrate.c: reform the last call on do_move_pages_to_node() Wei Yang
2020-01-20 9:46 ` Michal Hocko
2020-01-20 22:27 ` Wei Yang
2020-01-19 3:06 ` [PATCH 4/8] mm/migrate.c: wrap do_move_pages_to_node() and store_status() Wei Yang
2020-01-20 9:49 ` Michal Hocko
2020-01-19 3:06 ` [PATCH 5/8] mm/migrate.c: check pagelist in move_pages_and_store_status() Wei Yang
2020-01-20 9:52 ` Michal Hocko
2020-01-19 3:06 ` [PATCH 6/8] mm/migrate.c: handle same node and add failure in the same way Wei Yang
2020-01-20 10:01 ` Michal Hocko
2020-01-19 3:06 ` [PATCH 7/8] mm/migrate.c: move page on next iteration Wei Yang
2020-01-20 10:02 ` Michal Hocko
2020-01-21 1:22 ` Wei Yang
2020-01-21 8:43 ` Michal Hocko
2020-01-22 0:40 ` Wei Yang
2020-01-22 8:17 ` Michal Hocko
2020-01-19 3:06 ` [PATCH 8/8] mm/migrate.c: use break instead of goto out_flush Wei Yang
2020-01-20 10:03 ` Michal Hocko
2020-01-21 1:22 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200120094503.GM18451@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=richardw.yang@linux.intel.com \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox