From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4484C32771 for ; Sun, 19 Jan 2020 00:07:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8A889246AF for ; Sun, 19 Jan 2020 00:07:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="USnbHbj2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A889246AF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 36BC66B053E; Sat, 18 Jan 2020 19:07:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 31CB46B053F; Sat, 18 Jan 2020 19:07:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 231E56B0540; Sat, 18 Jan 2020 19:07:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0094.hostedemail.com [216.40.44.94]) by kanga.kvack.org (Postfix) with ESMTP id 0CA266B053E for ; Sat, 18 Jan 2020 19:07:06 -0500 (EST) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9919240F0 for ; Sun, 19 Jan 2020 00:07:05 +0000 (UTC) X-FDA: 76392443610.01.stamp55_3de286a2d6f43 X-HE-Tag: stamp55_3de286a2d6f43 X-Filterd-Recvd-Size: 2132 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Sun, 19 Jan 2020 00:07:05 +0000 (UTC) Received: from X1 (nat-ab2241.sltdut.senawave.net [162.218.216.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 19248246A0; Sun, 19 Jan 2020 00:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579392424; bh=R4Rj5xaCoD2cEU5RSlC8uqyGpOVoasee2i1njuPxRzo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=USnbHbj2WKtlIKa3Q8m5QRuMgWm/DDI3Mgbe8AdM/BBF8SOpvuA3WaNVkSXu2+lv7 A6SNy2Eu6pUu5ATmAEQHCuthhYOf3QVldTIe2hjJfLrDCGKeaPptsOVoYrlYfgq9bv f/Gd5ggeVnhBoxQ73NqYfDqqCBm4UaGjWtLfrj6Y= Date: Sat, 18 Jan 2020 16:07:02 -0800 From: Andrew Morton To: Wei Yang Cc: dan.j.williams@intel.com, aneesh.kumar@linux.ibm.com, kirill@shutemov.name, yang.shi@linux.alibaba.com, thellstrom@vmware.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 0/5] mm/mremap.c: cleanup move_page_tables() a little Message-Id: <20200118160702.9e5cc9f44ef855c070036331@linux-foundation.org> In-Reply-To: <20200117232254.2792-1-richardw.yang@linux.intel.com> References: <20200117232254.2792-1-richardw.yang@linux.intel.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, 18 Jan 2020 07:22:49 +0800 Wei Yang wrote: > move_page_tables() tries to move page table by PMD or PTE. > > The root reason is if it tries to move PMD, both old and new range should > be PMD aligned. But current code calculate old range and new range > separately. This leads to some redundant check and calculation. > > This cleanup tries to consolidate the range check in one place to reduce > some extra range handling. Thanks, I grabbed these, aimed at 5.7-rc1.