From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32289C33CB1 for ; Fri, 17 Jan 2020 15:47:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id F1E812072E for ; Fri, 17 Jan 2020 15:47:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1E812072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7B9996B04BB; Fri, 17 Jan 2020 10:47:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 76A506B04BC; Fri, 17 Jan 2020 10:47:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 681876B04BD; Fri, 17 Jan 2020 10:47:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0066.hostedemail.com [216.40.44.66]) by kanga.kvack.org (Postfix) with ESMTP id 518836B04BB for ; Fri, 17 Jan 2020 10:47:01 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id F2F68180AD802 for ; Fri, 17 Jan 2020 15:47:00 +0000 (UTC) X-FDA: 76387554642.03.clam14_2fa35f8cf52d X-HE-Tag: clam14_2fa35f8cf52d X-Filterd-Recvd-Size: 3285 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Fri, 17 Jan 2020 15:47:00 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id u2so8092851wmc.3 for ; Fri, 17 Jan 2020 07:47:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3Bj0wpfeG4WUbynTokfuhSk08I/UsNl1uvGCOq3jYT0=; b=amBUVTuFMUHrRQz7djF1fLO8Q2czoyIBSLyPuvj93+iM5M0Gs2nvbb54A+xq/SYH7o zH8W3a8DJN5cZT7Wpw1EXnDsQXouUxBWBYJWB/LO0QoqeY+kVHwpahc32N2Dl4s6GUXj rvDYbZHHqiGUwwEisEel37C9ilmhLWnC4YzVV4A0CGdMEukO3XcMVcXSeBVjk6e0JGB6 ThAt3wYPx9aukgd42b06+9GQIBQH3RpLb+xlodwsrDTH0aSwHhCBFciKBuHGJpEeT0yr EVuRWOOuJmxmQVw1c+UfecwOBE+uPDnXGt/D/yKD81LcIEWIffarqMIbNSR3mynT0e21 LD/Q== X-Gm-Message-State: APjAAAXG+ld3EiKyQJZV7hRSwhunk80ahjJx4nHzE3wsFO0l4zfjPdaC ebWD/oxCGl5qDyC+7OPrzCg= X-Google-Smtp-Source: APXvYqxvFy2I3vgmVlD3PjVc6nrcUsOWbf3nQbihKUYrVjXoA2ms3aHznTtU5u1TdPGXx8upDvD4lg== X-Received: by 2002:a1c:f218:: with SMTP id s24mr5462989wmc.128.1579276019240; Fri, 17 Jan 2020 07:46:59 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id s128sm10370683wme.39.2020.01.17.07.46.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2020 07:46:58 -0800 (PST) Date: Fri, 17 Jan 2020 16:46:57 +0100 From: Michal Hocko To: Qian Cai Cc: akpm@linux-foundation.org, sergey.senozhatsky.work@gmail.com, pmladek@suse.com, rostedt@goodmis.org, peterz@infradead.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next v4] mm/hotplug: silence a lockdep splat with printk() Message-ID: <20200117154657.GL19428@dhcp22.suse.cz> References: <20200117143905.GZ19428@dhcp22.suse.cz> <3B7490FB-E915-4DC7-8739-01EDC023E22E@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3B7490FB-E915-4DC7-8739-01EDC023E22E@lca.pw> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.002361, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 17-01-20 10:05:12, Qian Cai wrote: > > > > On Jan 17, 2020, at 9:39 AM, Michal Hocko wrote: > > > > Thanks a lot. Having it in a separate patch would be great. > > I was thinking about removing that WARN together in this v5 patch, > so there is less churn to touch the same function again. However, I > am fine either way, so just shout out if you feel strongly towards a > separate patch. I hope you meant moving rather than removing ;). The warning is useful because we shouldn't see unmovable pages in the movable zone. And a separate patch makes more sense because the justification is slightly different. We do not want to have a way for userspace to trigger the warning from userspace - even though it shouldn't be possible, but still. Only the offlining path should complain. -- Michal Hocko SUSE Labs