From: Michal Hocko <mhocko@kernel.org>
To: David Hildenbrand <david@redhat.com>
Cc: Qian Cai <cai@lca.pw>,
akpm@linux-foundation.org, sergey.senozhatsky.work@gmail.com,
pmladek@suse.com, rostedt@goodmis.org, peterz@infradead.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next v4] mm/hotplug: silence a lockdep splat with printk()
Date: Fri, 17 Jan 2020 16:26:31 +0100 [thread overview]
Message-ID: <20200117152631.GJ19428@dhcp22.suse.cz> (raw)
In-Reply-To: <0e9b9357-1982-edd3-dbfe-5350c8d6d0eb@redhat.com>
On Fri 17-01-20 15:43:58, David Hildenbrand wrote:
> On 17.01.20 15:42, Michal Hocko wrote:
> > On Fri 17-01-20 07:40:15, Qian Cai wrote:
> >>
> >>
> >>> On Jan 17, 2020, at 3:51 AM, David Hildenbrand <david@redhat.com> wrote:
> >>>
> >>> -> you are accessing the pageblock without the zone lock. It could
> >>> change to "isolate" again in the meantime if I am not wrong!
> >>
> >> Since we are just dumping the state for debugging, it should be fine
> >> to accept a bit inaccuracy here due to racing. I could put a bit
> >> comments over there.
> >
> > Sorry, I could have been more specific. The race I was talking about is
> > not about accuracy. The current code is racy in that sense already
> > because you are looking at a struct page you do not own so its state can
> > change at any time. Please note that the zone->lock doesn't really
>
> The pageblock state cannot change with the zone->lock. That's what I was
> referring to here. (this specific check)
CMA pages tend to have a stable pageblock state. More importantly this
is not the most important information from my experience. It is usually
reference count and page flags that are of interest. Or details about
what kind of filesystem is owning the page and it doesn't want to
release it.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2020-01-17 15:26 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 2:21 Qian Cai
2020-01-17 2:49 ` Sergey Senozhatsky
2020-01-17 8:51 ` David Hildenbrand
2020-01-17 8:59 ` Michal Hocko
2020-01-17 9:25 ` David Hildenbrand
2020-01-17 9:40 ` Michal Hocko
2020-01-17 9:42 ` David Hildenbrand
2020-01-17 10:17 ` Michal Hocko
2020-01-17 10:18 ` David Hildenbrand
2020-01-17 12:40 ` Qian Cai
2020-01-17 12:53 ` David Hildenbrand
2020-01-17 13:30 ` Qian Cai
2020-01-17 13:42 ` David Hildenbrand
2020-01-17 14:42 ` Michal Hocko
2020-01-17 14:43 ` David Hildenbrand
2020-01-17 15:26 ` Michal Hocko [this message]
2020-01-17 8:59 ` Michal Hocko
2020-01-17 12:32 ` Qian Cai
2020-01-17 14:39 ` Michal Hocko
2020-01-17 15:05 ` Qian Cai
2020-01-17 15:46 ` Michal Hocko
2020-01-17 18:49 ` Qian Cai
2020-01-17 19:15 ` David Hildenbrand
2020-01-17 19:42 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117152631.GJ19428@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox