From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA8F8C33CB1 for ; Fri, 17 Jan 2020 11:52:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9FC782083E for ; Fri, 17 Jan 2020 11:52:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9FC782083E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 02E5A6B0361; Fri, 17 Jan 2020 06:52:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F20C26B0362; Fri, 17 Jan 2020 06:52:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E36BA6B0363; Fri, 17 Jan 2020 06:52:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0079.hostedemail.com [216.40.44.79]) by kanga.kvack.org (Postfix) with ESMTP id CBCCC6B0361 for ; Fri, 17 Jan 2020 06:52:28 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with SMTP id 75E8933C4 for ; Fri, 17 Jan 2020 11:52:28 +0000 (UTC) X-FDA: 76386963576.05.rate56_89f66cccf4953 X-HE-Tag: rate56_89f66cccf4953 X-Filterd-Recvd-Size: 5190 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Fri, 17 Jan 2020 11:52:27 +0000 (UTC) Received: by mail-wr1-f68.google.com with SMTP id z7so22374266wrl.13 for ; Fri, 17 Jan 2020 03:52:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CfaMrw+TYdEFJRwNODCdrVm4OOMZyFpQ0nkjoCPs5oc=; b=mBHEhvOHtb6e+vmcq4PGEqgXzbyDzZbBR3ecy1oopVO8MVBXqVxzqy+QZCXUIuccp4 10108tPgYbaSrVgHKLojZKH0EbXdf+k5JXZ5p4MbK2l/aizwMKaYlhoXvPSuW+3jRQKR hpf7noE1W1UDkPF5cQq1DMnLmYBRstKsQeNayFFNwZL/IyCES04ZM7/b7a88OW0gmYJp pCThlgRlHCUxQxkSEZtW2YmqVJ9Y4c9UkOauFmRENw7rXbQVeAZbaMWAD+MA568lVwJt C1J+IDpz4XU/2g8lb1m6JQhddkU4swZ67EK25UbyMvNUjefMp08R/mErb2PjQoS89z7c kJ4Q== X-Gm-Message-State: APjAAAV4cn8kliWKAO+CPRVykJ7/cdhALjMwaaNhfc+LHUxAAmPMcv+S r4rpIY0DwQu21jU5zQXdYkM= X-Google-Smtp-Source: APXvYqyFPhokZ7VGCqtGBvrGiYujSUt2mcWg7TDf/fiD867pU8zDvypUZ/CFGECXxUvRKPCo1tfbgw== X-Received: by 2002:a5d:6a83:: with SMTP id s3mr2496048wru.99.1579261946860; Fri, 17 Jan 2020 03:52:26 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id k13sm33558283wrx.59.2020.01.17.03.52.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2020 03:52:26 -0800 (PST) Date: Fri, 17 Jan 2020 12:52:25 +0100 From: Michal Hocko To: Minchan Kim Cc: Andrew Morton , LKML , linux-mm , linux-api@vger.kernel.org, oleksandr@redhat.com, Suren Baghdasaryan , Tim Murray , Daniel Colascione , Sandeep Patil , Sonny Rao , Brian Geffon , Johannes Weiner , Shakeel Butt , John Dias , ktkhai@virtuozzo.com, christian.brauner@ubuntu.com, sjpark@amazon.de Subject: Re: [PATCH v2 2/5] mm: introduce external memory hinting API Message-ID: <20200117115225.GV19428@dhcp22.suse.cz> References: <20200116235953.163318-1-minchan@kernel.org> <20200116235953.163318-3-minchan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200116235953.163318-3-minchan@kernel.org> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 16-01-20 15:59:50, Minchan Kim wrote: > There is usecase that System Management Software(SMS) want to give > a memory hint like MADV_[COLD|PAGEEOUT] to other processes and > in the case of Android, it is the ActivityManagerService. > > It's similar in spirit to madvise(MADV_WONTNEED), but the information > required to make the reclaim decision is not known to the app. Instead, > it is known to the centralized userspace daemon(ActivityManagerService), > and that daemon must be able to initiate reclaim on its own without > any app involvement. > > To solve the issue, this patch introduces new syscall process_madvise(2). > It uses pidfd of an external processs to give the hint. > > int process_madvise(int pidfd, void *addr, size_t length, int advise, > unsigned long flag); > > Since it could affect other process's address range, only privileged > process(CAP_SYS_PTRACE) or something else(e.g., being the same UID) > gives it the right to ptrace the process could use it successfully. > The flag argument is reserved for future use if we need to extend the > API. > > I think supporting all hints madvise has/will supported/support to > process_madvise is rather risky. Because we are not sure all hints make > sense from external process and implementation for the hint may rely on > the caller being in the current context so it could be error-prone. > Thus, I just limited hints as MADV_[COLD|PAGEOUT] in this patch. > > If someone want to add other hints, we could hear hear the usecase and > review it for each hint. It's more safe for maintainace rather than > introducing a buggy syscall but hard to fix it later. I have brought this up when we discussed this in the past but there is no reflection on that here so let me bring that up again. I believe that the interface has an inherent problem that it is racy. The external entity needs to know the address space layout of the target process to do anyhing useful on it. The address space is however under the full control of the target process though and the external entity has no means to find out that the layout has changed. So time-to-check-time-to-act is an inherent problem. This is a serious design flaw and it should be explained why it doesn't matter or how to use the interface properly to prevent that problem. -- Michal Hocko SUSE Labs