From: Wei Yang <richardw.yang@linux.intel.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Wei Yang <richardw.yang@linux.intel.com>
Subject: [PATCH] mm/migrate.c: also overwrite error when it is bigger than zero
Date: Fri, 17 Jan 2020 15:45:34 +0800 [thread overview]
Message-ID: <20200117074534.25324-1-richardw.yang@linux.intel.com> (raw)
If we get here after successfully adding page to list, err would be
the number of pages in the list.
Current code has two problems:
* on success, 0 is not returned
* on error, the real error code is not returned
Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
---
mm/migrate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index 557da996b936..c3ef70de5876 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1677,7 +1677,7 @@ static int do_pages_move(struct mm_struct *mm, nodemask_t task_nodes,
err1 = do_move_pages_to_node(mm, &pagelist, current_node);
if (!err1)
err1 = store_status(status, start, current_node, i - start);
- if (!err)
+ if (err >= 0)
err = err1;
out:
return err;
--
2.17.1
next reply other threads:[~2020-01-17 7:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 7:45 Wei Yang [this message]
2020-01-17 22:27 ` Wei Yang
2020-01-17 23:30 ` Yang Shi
2020-01-17 23:48 ` Wei Yang
2020-01-18 1:38 ` Mike Kravetz
2020-01-19 2:17 ` Wei Yang
2020-01-18 4:56 ` Yang Shi
2020-01-19 2:41 ` Wei Yang
2020-01-19 5:54 ` Yang Shi
2020-01-18 5:32 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117074534.25324-1-richardw.yang@linux.intel.com \
--to=richardw.yang@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox