From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Qian Cai <cai@lca.pw>
Cc: akpm@linux-foundation.org, mhocko@kernel.org,
sergey.senozhatsky.work@gmail.com, pmladek@suse.com,
rostedt@goodmis.org, peterz@infradead.org, david@redhat.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH -next v4] mm/hotplug: silence a lockdep splat with printk()
Date: Fri, 17 Jan 2020 11:49:57 +0900 [thread overview]
Message-ID: <20200117024957.GA7372@google.com> (raw)
In-Reply-To: <20200117022111.18807-1-cai@lca.pw>
On (20/01/16 21:21), Qian Cai wrote:
> It is not that hard to trigger lockdep splats by calling printk from
> under zone->lock. Most of them are false positives caused by lock chains
> introduced early in the boot process and they do not cause any real
> problems (although some of the early boot lock dependencies could
> happenn after boot as well). There are some console drivers which do
> allocate from the printk context as well and those should be fixed. In
> any case false positives are not that trivial to workaround and it is
> far from optimal to lose lockdep functionality for something that is a
> non-issue.
[..]
>
> Acked-by: Michal Hocko <mhocko@suse.com>
> Signed-off-by: Qian Cai <cai@lca.pw>
FWIW,
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
next prev parent reply other threads:[~2020-01-17 2:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 2:21 Qian Cai
2020-01-17 2:49 ` Sergey Senozhatsky [this message]
2020-01-17 8:51 ` David Hildenbrand
2020-01-17 8:59 ` Michal Hocko
2020-01-17 9:25 ` David Hildenbrand
2020-01-17 9:40 ` Michal Hocko
2020-01-17 9:42 ` David Hildenbrand
2020-01-17 10:17 ` Michal Hocko
2020-01-17 10:18 ` David Hildenbrand
2020-01-17 12:40 ` Qian Cai
2020-01-17 12:53 ` David Hildenbrand
2020-01-17 13:30 ` Qian Cai
2020-01-17 13:42 ` David Hildenbrand
2020-01-17 14:42 ` Michal Hocko
2020-01-17 14:43 ` David Hildenbrand
2020-01-17 15:26 ` Michal Hocko
2020-01-17 8:59 ` Michal Hocko
2020-01-17 12:32 ` Qian Cai
2020-01-17 14:39 ` Michal Hocko
2020-01-17 15:05 ` Qian Cai
2020-01-17 15:46 ` Michal Hocko
2020-01-17 18:49 ` Qian Cai
2020-01-17 19:15 ` David Hildenbrand
2020-01-17 19:42 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200117024957.GA7372@google.com \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cai@lca.pw \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mhocko@suse.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox