From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50FB2C33CB6 for ; Thu, 16 Jan 2020 17:30:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 16F4724729 for ; Thu, 16 Jan 2020 17:30:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cmpxchg-org.20150623.gappssmtp.com header.i=@cmpxchg-org.20150623.gappssmtp.com header.b="FHy404mC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 16F4724729 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cmpxchg.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A6D408E003F; Thu, 16 Jan 2020 12:30:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A1BFE8E0089; Thu, 16 Jan 2020 12:30:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 914408E003F; Thu, 16 Jan 2020 12:30:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0143.hostedemail.com [216.40.44.143]) by kanga.kvack.org (Postfix) with ESMTP id 77D078E003F for ; Thu, 16 Jan 2020 12:30:06 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id 32770180AD815 for ; Thu, 16 Jan 2020 17:30:06 +0000 (UTC) X-FDA: 76384185612.08.skirt24_7532bda338944 X-HE-Tag: skirt24_7532bda338944 X-Filterd-Recvd-Size: 3698 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Thu, 16 Jan 2020 17:30:05 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id v25so19506927qto.7 for ; Thu, 16 Jan 2020 09:30:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nXB1QQ2IuOraqyyfUU+xQ4aQQGOF9c/16KgO75ZTWiU=; b=FHy404mC4DAy7avamv6rP/tsX7uXrpLtoSjPwiMjoZ0SqcGxITSnPNJZVBXFcW/T81 uouPRPMh0bW+Ls5KLmYmvhW3LD+wuD0GUeJkGYdhuUWqETB8A+IcdMx0euMvDy3eOrGC Q9bmG6NpVDsBPG5GuzJewaoG8pHLTriec/oHOSKxP49MnAf4o6tycXpj0zOocC35I3lE vo6ZZ/lU+AUJ5Z5ZcIIpDHVzS1qrb+pyJE5Ymrr4libH2/npms2xZiCp5JfKd6fWsvuW wPU5z6ht6cLg6Rldc4fnq+WLuYaN5tP/nI0fxujCyhsFWLp+Ywn+/pudirlk/JIf7RTz 5dIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nXB1QQ2IuOraqyyfUU+xQ4aQQGOF9c/16KgO75ZTWiU=; b=m0yzWM3NxEnOnZ7UekAAn6ar82yUBgH3/nST4ASc03nxYMKSva2MDk8zVtYsdKQ4EA L2iskeGEGnzX2/kSKlQ6mjtX6iCgEGl8qq04iZvyP02aadmhvbk2SGDUChKC5EuOxCND /yJEOpwDOPUrkMr1rlBu6P5Z5U1McrZj1XSNqTM2hCqq2UgEsGpXS9/Z7E1DSRIc22i7 NLRsoMNIUmUESIwyJnShVMOEieuJljqTXSjalfuXYQ1Qv05/F1sRnwxoPysgYoqprANF FXGi2leFoD84DBzz/WgXNpNtQXPCGMAaNI+J+sy6sCxCFAtcH08Zqk1saVZuXwwthS73 +XOQ== X-Gm-Message-State: APjAAAU8WXs04eSgdljFe8WM4rBXwZEDl3Lfk5DD+6dOe3qW1IQb/se1 wnD2JCEdy9DKS/YV0XCV6fhOhQ== X-Google-Smtp-Source: APXvYqzJz9SHhVW/QFhyuUBUHinkJx7R7n44cFOVCqZgDzLe2eqyGEJJj5CjHH9aHKqLRdmShIbdgQ== X-Received: by 2002:ac8:2f03:: with SMTP id j3mr3537882qta.180.1579195804411; Thu, 16 Jan 2020 09:30:04 -0800 (PST) Received: from localhost ([2620:10d:c091:500::ae73]) by smtp.gmail.com with ESMTPSA id k4sm10398554qki.35.2020.01.16.09.30.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Jan 2020 09:30:03 -0800 (PST) Date: Thu, 16 Jan 2020 12:30:02 -0500 From: Johannes Weiner To: Roman Gushchin Cc: linux-mm@kvack.org, Andrew Morton , Michal Hocko , Shakeel Butt , Vladimir Davydov , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH v2 6/6] mm: kmem: rename (__)memcg_kmem_(un)charge_memcg() to __memcg_kmem_(un)charge() Message-ID: <20200116173002.GF57074@cmpxchg.org> References: <20200109202659.752357-1-guro@fb.com> <20200109202659.752357-7-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200109202659.752357-7-guro@fb.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 09, 2020 at 12:26:59PM -0800, Roman Gushchin wrote: > Drop the _memcg suffix from (__)memcg_kmem_(un)charge functions. > It's shorter and more obvious. > > These are the most basic functions which are just (un)charging the > given cgroup with the given amount of pages. > > Also fix up the corresponding comments. > > Signed-off-by: Roman Gushchin This looks good to me. I also appreciate the grouping of the functions by layer (first charge/uncharge, then charge_page/uncharge_page). Acked-by: Johannes Weiner