From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=uWr4=3F=kvack.org=owner-linux-mm@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 67EB3C33CB6
	for <linux-mm@archiver.kernel.org>; Thu, 16 Jan 2020 10:07:59 +0000 (UTC)
Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17])
	by mail.kernel.org (Postfix) with ESMTP id 4438A207E0
	for <linux-mm@archiver.kernel.org>; Thu, 16 Jan 2020 10:07:59 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4438A207E0
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de
Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix)
	id C30DC8E005F; Thu, 16 Jan 2020 05:07:58 -0500 (EST)
Received: by kanga.kvack.org (Postfix, from userid 40)
	id C096F8E003F; Thu, 16 Jan 2020 05:07:58 -0500 (EST)
X-Delivered-To: int-list-linux-mm@kvack.org
Received: by kanga.kvack.org (Postfix, from userid 63042)
	id AF8D68E005F; Thu, 16 Jan 2020 05:07:58 -0500 (EST)
X-Delivered-To: linux-mm@kvack.org
Received: from forelay.hostedemail.com (smtprelay0211.hostedemail.com [216.40.44.211])
	by kanga.kvack.org (Postfix) with ESMTP id 9BD948E003F
	for <linux-mm@kvack.org>; Thu, 16 Jan 2020 05:07:58 -0500 (EST)
Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251])
	by forelay02.hostedemail.com (Postfix) with SMTP id 3DDB634A4
	for <linux-mm@kvack.org>; Thu, 16 Jan 2020 10:07:58 +0000 (UTC)
X-FDA: 76383071436.09.steel81_286d2f8921a00
X-HE-Tag: steel81_286d2f8921a00
X-Filterd-Recvd-Size: 1403
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
	by imf40.hostedemail.com (Postfix) with ESMTP
	for <linux-mm@kvack.org>; Thu, 16 Jan 2020 10:07:57 +0000 (UTC)
Received: by verein.lst.de (Postfix, from userid 2407)
	id B6DD468BE1; Thu, 16 Jan 2020 11:07:54 +0100 (CET)
Date: Thu, 16 Jan 2020 11:07:54 +0100
From: Christoph Hellwig <hch@lst.de>
To: Ralph Campbell <rcampbell@nvidia.com>
Cc: linux-rdma@vger.kernel.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org,
	linux-kselftest@vger.kernel.org, Jerome Glisse <jglisse@redhat.com>,
	John Hubbard <jhubbard@nvidia.com>, Christoph Hellwig <hch@lst.de>,
	Jason Gunthorpe <jgg@mellanox.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ben Skeggs <bskeggs@redhat.com>, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH v6 1/6] mm/mmu_notifier: add
 mmu_interval_notifier_insert_safe()
Message-ID: <20200116100754.GA16347@lst.de>
References: <20200113224703.5917-1-rcampbell@nvidia.com> <20200113224703.5917-2-rcampbell@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200113224703.5917-2-rcampbell@nvidia.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4
Sender: owner-linux-mm@kvack.org
Precedence: bulk
X-Loop: owner-majordomo@kvack.org
List-ID: <linux-mm.kvack.org>

The name is weird, normally we call functions like this _locked.

Additionally it will need a lockdep_assert_held to ensure the caller
actually holds the lock.