From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFD1BC33CB1 for ; Thu, 16 Jan 2020 09:26:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 74D282075B for ; Thu, 16 Jan 2020 09:26:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="qw5TJ5Gy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74D282075B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0B5F38E0059; Thu, 16 Jan 2020 04:26:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 066FC8E003F; Thu, 16 Jan 2020 04:26:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBFEE8E0059; Thu, 16 Jan 2020 04:26:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id D592E8E003F for ; Thu, 16 Jan 2020 04:26:22 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 78EA0815A for ; Thu, 16 Jan 2020 09:26:22 +0000 (UTC) X-FDA: 76382966604.10.wall15_71cfd3c35d21c X-HE-Tag: wall15_71cfd3c35d21c X-Filterd-Recvd-Size: 3830 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Thu, 16 Jan 2020 09:26:21 +0000 (UTC) Received: from localhost (static-140-208-78-212.thenetworkfactory.nl [212.78.208.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A79A1207FF; Thu, 16 Jan 2020 09:26:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579166781; bh=/rVgZuyW/YvassNaphB2Q9wK9rEiwLvqe2rtv2zQpMY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qw5TJ5GyLidNA6mr3nKuxn8zYn2QmuNYTg8wdzGdwnZ8o8zsBoYiSNVNa6QH1xnDm +0LrxAOGncWKaIAWPkbQ+cfHVz+SoS7YBtW1MepwYL4DDyGwxIQWUCHBWSCeoDy/mJ N0DE51B23eOBKrwGDYN3S5qFE/cGRkkeeaawn2vM= Date: Thu, 16 Jan 2020 10:26:18 +0100 From: Greg Kroah-Hartman To: David Hildenbrand Cc: stable@vger.kernel.org, linux-mm@kvack.org, Oscar Salvador , Michal Hocko , "Aneesh Kumar K . V" , Dan Williams , Andrew Morton , Laurent Vivier , Baoquan He Subject: Re: [PATCH for 4.19-stable 00/25] mm/memory_hotplug: backport of pending stable fixes Message-ID: <20200116092618.GA84509@kroah.com> References: <20200115153339.36409-1-david@redhat.com> <20200115153927.GC3881751@kroah.com> <4a09f161-e2f1-b506-f0fd-2d6c4ea1437c@redhat.com> <20200116083407.GB2359@kroah.com> <20200116085455.GA27815@kroah.com> <55fe2656-c044-cbc5-6062-b9cba0354a8f@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55fe2656-c044-cbc5-6062-b9cba0354a8f@redhat.com> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jan 16, 2020 at 09:59:44AM +0100, David Hildenbrand wrote: > On 16.01.20 09:54, Greg Kroah-Hartman wrote: > > On Thu, Jan 16, 2020 at 09:42:51AM +0100, David Hildenbrand wrote: > >> On 16.01.20 09:34, Greg Kroah-Hartman wrote: > >>> On Wed, Jan 15, 2020 at 04:54:59PM +0100, David Hildenbrand wrote: > >>>>> > >>>>> And why would 4.9 and 4.4 care about them? > >>>> > >>>> The crashes can be trigger under 4.9 and 4.4. If we decide that we do > >>>> not care, then this series can be dropped. > >>> > >>> Do we have users of memory hotplug that are somehow stuck at those old > >>> versions that can not upgrade? Obviously this didn't work previously > >>> for them, so moving to a modern kernel might be a good reason to get > >>> this new feature :) > >> > >> That's a good point - but usually when you experience a crash it's too > >> late for you to realize that you have to move to a newer release :) It > >> used to work before 4.4 IIRC. > >> > >> (one case I am concerned with is when memory onlining after memory > >> hotplug failed (e.g., because the was an OOM event happening > >> concurrently) - then memory hotunplug will crash your system.) > >> > >> But yeah, I am not aware of a report where somebody actually hit any of > >> these issues on a stable kernel. > > Just to clarify: I can reproduce them of course :) > > > > > Ok, let's start with 4.19 and 4.14 for these for now. Should make > > things easier, right? > > What do you mean with "start with"? Drop this series and not do the > backport, meaning people should switch to a stable kernel > 4.19 if they > don't want surprises on memory unplug? No, I'm saying I want to take this for 4.19, and 4.14 if you have it. But your original series you sent needs to be fixed up, I can't take it as-is for the authorship reasons. thanks, greg k-h