From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF902C3F68F for ; Wed, 15 Jan 2020 14:46:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8001724671 for ; Wed, 15 Jan 2020 14:46:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8001724671 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 052EE8E0006; Wed, 15 Jan 2020 09:46:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0036B8E0003; Wed, 15 Jan 2020 09:46:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E33758E0006; Wed, 15 Jan 2020 09:46:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0105.hostedemail.com [216.40.44.105]) by kanga.kvack.org (Postfix) with ESMTP id CC6608E0003 for ; Wed, 15 Jan 2020 09:46:33 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 7CC308248047 for ; Wed, 15 Jan 2020 14:46:33 +0000 (UTC) X-FDA: 76380144666.05.pain88_564866ba15c20 X-HE-Tag: pain88_564866ba15c20 X-Filterd-Recvd-Size: 3156 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Jan 2020 14:46:32 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id t14so102992wmi.5 for ; Wed, 15 Jan 2020 06:46:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=1ihlJxSMXD6WCn9ytjlwpvSulRqTRbie1gLYg4oqfak=; b=XYDWhjKxFCxLChWDU+u+3uZhi5C+DM0jBYEGihKuYFHrcJQFBj/mBUbE/bx5EoKj/w PsDk/SXFHE93E44Jea99HISP4Sk/m1uDGppepXo0Chcqb5YSOlEruCl8sCIRUZHLCGSw ZMjDVFTs/Be5y2zL5yeONkkraIEGoDvltE4b3mmyfWM/8GXNZfmKdxhZFwOI51VGaKy0 SqlwqdQ1M6mjIMknioeWmuHzTe31O1+ZmbUprf9LUVUegr5IPQCBG5EGiColo1eBEvAv PqAslcBZjxGoy4DEta6qpO3hP6iCZE8qGo0oI1bcPjjHwpRM2DqaYLIXtH/d7hqFqS0c xXrg== X-Gm-Message-State: APjAAAU5gfYcfdKoJhdfj7MIUSbMFKj59sXbcCXX9zqozFbBx9A2s6yw 5YpBph5RXbAxUOYI4YDxR7k= X-Google-Smtp-Source: APXvYqx3h4N9YUl0YcYyI4yYQlqoeuwjUK+bi8ae7B9X1eP0yz0+lcAoIkTIqhEDDcTnz4LfX/U+xg== X-Received: by 2002:a1c:3c89:: with SMTP id j131mr146422wma.34.1579099591698; Wed, 15 Jan 2020 06:46:31 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id a1sm39823wmj.40.2020.01.15.06.46.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2020 06:46:30 -0800 (PST) Date: Wed, 15 Jan 2020 15:46:29 +0100 From: Michal Hocko To: Qian Cai Cc: akpm@linux-foundation.org, sergey.senozhatsky.work@gmail.com, pmladek@suse.com, rostedt@goodmis.org, peterz@infradead.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Mike Kravetz Subject: Re: [PATCH -next v2] mm/hotplug: silence a lockdep splat with printk() Message-ID: <20200115144629.GG19428@dhcp22.suse.cz> References: <20200115092221.GX19428@dhcp22.suse.cz> <39D75B58-A5CE-4837-BCD3-8026E2C88861@lca.pw> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <39D75B58-A5CE-4837-BCD3-8026E2C88861@lca.pw> User-Agent: Mutt/1.12.2 (2019-09-21) Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000549, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 15-01-20 07:35:45, Qian Cai wrote: >=20 >=20 > > On Jan 15, 2020, at 4:22 AM, Michal Hocko wrote: > >=20 > > Is this correct? CMA pages cannot be comound? >=20 > I never saw a CMA page also a compound page. Also, in > alloc_contig_range(), it calls migrate_pages()=E2=80=94> > unmap_and_move_huge_page() which will free the old huge page, so I > think that will clear pageCompound. This sounds like the implementation detail. I do not think you want to depend on that. Anyway, see my other response. If you rebase on top of Vlastimil's patch you do not really have to care. --=20 Michal Hocko SUSE Labs