From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25242C33CB1 for ; Wed, 15 Jan 2020 09:24:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E2C02207E0 for ; Wed, 15 Jan 2020 09:24:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2C02207E0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8BEA28E000A; Wed, 15 Jan 2020 04:24:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 86FEE8E0003; Wed, 15 Jan 2020 04:24:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 786CF8E000A; Wed, 15 Jan 2020 04:24:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0114.hostedemail.com [216.40.44.114]) by kanga.kvack.org (Postfix) with ESMTP id 607CC8E0003 for ; Wed, 15 Jan 2020 04:24:20 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id 06D668248D7C for ; Wed, 15 Jan 2020 09:24:20 +0000 (UTC) X-FDA: 76379332680.27.earth64_25cb4d20b230d X-HE-Tag: earth64_25cb4d20b230d X-Filterd-Recvd-Size: 3315 Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by imf30.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Jan 2020 09:24:19 +0000 (UTC) Received: by mail-wm1-f68.google.com with SMTP id u2so16928994wmc.3 for ; Wed, 15 Jan 2020 01:24:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=tNU1cdwWt6cMZU4GfnwesKU3UK3hagQzMWT49N8oX9c=; b=CDzF0q2RvBO4cNvc/TNtyucVGwnYO9bMDzexPwKAk0XI22K4XyqX13DeiniN+f27c6 0e7Qk1cOa6qBOV+GhFBAmMqrwMrBP2Z/jHq1kfWwp53tZmv249jWwHbp41ZqCrcOKJXO 7G+FIDzZ9U/CFCQfa6ew8N7hB5ku4FIItAyWw+VHrk8Lx7C9KRXUC/PCd8BLnKGf5JmT 5xnKH6HZ/c1Dvf1/JkKFMJjZg5s46RZir3KnOFSfNKk59MVclDojngEyQYj/lTt1Sk7U 794mwO5q1D7douSI/mLYdUEUU5Xn2EeBJ7ppkpMi04Bhh2Ay6aMZ11X8FD3e1K0gmj1S YtOg== X-Gm-Message-State: APjAAAUKjMQXsy7MsCPGjz/D3dHB9I0p8uCsapnOYx75A8Tqz5wDYXGq tG1hVSoLerSC+9/RZqr6Bho= X-Google-Smtp-Source: APXvYqzSl9fmAOaDZX3rSje+dh2SD0i/D/kj5x0Qr2JFd/bsHgU/welAYEaSe2RTcTtHz+oAyrfUiQ== X-Received: by 2002:a05:600c:24d1:: with SMTP id 17mr31702639wmu.136.1579080258590; Wed, 15 Jan 2020 01:24:18 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id j12sm23908802wrt.55.2020.01.15.01.24.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2020 01:24:17 -0800 (PST) Date: Wed, 15 Jan 2020 10:24:17 +0100 From: Michal Hocko To: Qian Cai Cc: akpm@linux-foundation.org, sergey.senozhatsky.work@gmail.com, pmladek@suse.com, rostedt@goodmis.org, peterz@infradead.org, david@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next v2] mm/hotplug: silence a lockdep splat with printk() Message-ID: <20200115092417.GY19428@dhcp22.suse.cz> References: <20200115053130.15490-1-cai@lca.pw> <20200115092221.GX19428@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200115092221.GX19428@dhcp22.suse.cz> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 15-01-20 10:22:24, Michal Hocko wrote: [...] > > @@ -74,9 +75,9 @@ void __dump_page(struct page *page, const char *reason) > > page->mapping, page_to_pgoff(page), > > compound_mapcount(page)); > > else > > - pr_warn("page:%px refcount:%d mapcount:%d mapping:%px index:%#lx\n", > > + pr_warn("page:%px refcount:%d mapcount:%d mapping:%px index:%#lx cma:%d\n", > > page, page_ref_count(page), mapcount, > > - page->mapping, page_to_pgoff(page)); > > + page->mapping, page_to_pgoff(page), page_cma); > > Is this correct? CMA pages cannot be comound? Btw. I would simply do > > pr_warn("page:%px refcount:%d mapcount:%d mapping:%px index:%#lx%s\n", > ...., page_cmap ? "CMA": ""); Btw. if you rebased on top of http://lkml.kernel.org/r/9f884d5c-ca60-dc7b-219c-c081c755fab6@suse.cz then the whole thing would be easier AFAICS. -- Michal Hocko SUSE Labs