From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 841B5C33CB1 for ; Wed, 15 Jan 2020 08:29:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2A5CD24655 for ; Wed, 15 Jan 2020 08:29:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="lctX+OwE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A5CD24655 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7FD328E0005; Wed, 15 Jan 2020 03:29:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7ADEB8E0003; Wed, 15 Jan 2020 03:29:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 676088E0005; Wed, 15 Jan 2020 03:29:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0223.hostedemail.com [216.40.44.223]) by kanga.kvack.org (Postfix) with ESMTP id 4F7448E0003 for ; Wed, 15 Jan 2020 03:29:51 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 0A4CF34A3 for ; Wed, 15 Jan 2020 08:29:51 +0000 (UTC) X-FDA: 76379195382.14.verse86_9024865903f1f X-HE-Tag: verse86_9024865903f1f X-Filterd-Recvd-Size: 2442 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Wed, 15 Jan 2020 08:29:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=MPafXeu0m8CczGY2euGxOZpo2GzuA/fsBdgtbBJiLfk=; b=lctX+OwEGdd61wKz2mFk+BrFX z1zAF5aRwydgJ07mE8siK0MMh5sA7VNV/avjC2d0XcNCySywROV7Lje83cMelqBDUDd11TM+MHV02 fulUsZoepN5Jtt8+F7oLK5R4yM5Ozc/ywn9NFz1jFv5Qf6d0NnMzTnkv2fYSqbFePl5knkt5pXes6 4Tde+9H/h/vy3HmNrOC2f+gFId6cFcQMFTqI6WAU48YSShptPLJ5+v3Yh9giC91N9Tc0HssIuqjtu dCZjB3Ds+Ze8S1PiKozXS0qwDh784Q5jdTcEPBohptC0S2F39UmHNNiQIpbB9QnKcJxP0Yv9fF4th TdHpITBAA==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ire3f-0005fN-Jm; Wed, 15 Jan 2020 08:29:47 +0000 Date: Wed, 15 Jan 2020 00:29:47 -0800 From: Christoph Hellwig To: Qian Cai Cc: Alex Shi , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/vmscan: remove prefetch_prev_lru_page Message-ID: <20200115082947.GA21018@infradead.org> References: <1579006500-127143-1-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Bogosity: Ham, tests=bogofilter, spamicity=0.000895, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 14, 2020 at 08:46:21AM -0500, Qian Cai wrote: > > > > On Jan 14, 2020, at 7:55 AM, Alex Shi wrote: > > > > This macro are never used in git history. So better to remove. > > When removing unused thingy, it is important to figure out which commit introduced it in the first place and Cc the relevant people in that commit. No, it isn't. It is at best nice to have, but for a trivial macro really doesn't matter.