From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F410BC33CB1 for ; Tue, 14 Jan 2020 11:32:34 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C090B24676 for ; Tue, 14 Jan 2020 11:32:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C090B24676 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 51D718E0005; Tue, 14 Jan 2020 06:32:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A6E68E0003; Tue, 14 Jan 2020 06:32:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36EAE8E0005; Tue, 14 Jan 2020 06:32:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0172.hostedemail.com [216.40.44.172]) by kanga.kvack.org (Postfix) with ESMTP id 1C6B78E0003 for ; Tue, 14 Jan 2020 06:32:34 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with SMTP id B74AE180AD817 for ; Tue, 14 Jan 2020 11:32:33 +0000 (UTC) X-FDA: 76376026986.17.balls78_508253923960c X-HE-Tag: balls78_508253923960c X-Filterd-Recvd-Size: 5226 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Jan 2020 11:32:33 +0000 (UTC) Received: by mail-wm1-f67.google.com with SMTP id b19so13321444wmj.4 for ; Tue, 14 Jan 2020 03:32:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pNR3NFApkzwBRWUY1yWsS3r7ps19YeFIKgoV6SnxNc8=; b=qMq1G2hHjP8AvKXWQFKIrb6cJkvaSe2GPq3UJntgykfYbUd7qL28fv9OvTPrb4ZjnG boJCkbTY/qcK5sw2gxsIHnfjt88gZrd8ZGCAjbqZ/i6vl+f+nCgBvZITL6S3Gqg1sMuR 7D/Y7X+4sZOyp1H78XjVgMzAq/BaPYH7Uk8JKNcDHz5qT4v/j+x1E1N6irgfuhoxpxlw pCj7yydh1TAapb9GSGQzyWK7EUPAkZCAMiLW8kfVviB2dtM4m0BtWpaHZTy20L5qbSjn AWc9v7WWYuJsZ34Q0+Nxf/Q+Fdq9KNi+eaXXODHcP2EMKHKorOgdiwwWgR/+0PZ7r7kg /QZA== X-Gm-Message-State: APjAAAVGyj8wYAzPU5D7mxZgI/Qr2qBYkrTW0SSYLiC/2qo8gVBWm2ZR cv3mpo97VmxVfvivmCz10LM= X-Google-Smtp-Source: APXvYqzMygljDOCWMN+Awr2DOrnrV+6E4eJIgx4LYtBx2oLAFvTdD/Hh+4vOZ4XSMGuAOORRG836ow== X-Received: by 2002:a7b:c936:: with SMTP id h22mr25570568wml.115.1579001552048; Tue, 14 Jan 2020 03:32:32 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id i11sm19629688wrs.10.2020.01.14.03.32.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2020 03:32:30 -0800 (PST) Date: Tue, 14 Jan 2020 12:32:30 +0100 From: Michal Hocko To: Vlastimil Babka Cc: Anshuman Khandual , David Hildenbrand , Qian Cai , linux-mm@kvack.org, Andrew Morton , Oscar Salvador , Mel Gorman , Mike Rapoport , Dan Williams , Pavel Tatashin , linux-kernel@vger.kernel.org, Ralph Campbell Subject: Re: [PATCH] mm/page_alloc: Add a reason for reserved pages in has_unmovable_pages() Message-ID: <20200114113230.GM19428@dhcp22.suse.cz> References: <49fa7dea-00ac-155f-e7b7-eeca206556b5@arm.com> <6A58E80B-7A5F-4CAD-ACF1-89BCCBE4D3B1@lca.pw> <20200114091013.GD19428@dhcp22.suse.cz> <1f3ff7fc-2f6b-d8e5-85a5-078f0e1a0daf@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1f3ff7fc-2f6b-d8e5-85a5-078f0e1a0daf@suse.cz> User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue 14-01-20 11:23:52, Vlastimil Babka wrote: > On 1/14/20 10:10 AM, Michal Hocko wrote: > > [Cc Ralph] > >> The reason is dump_page() does not print page->flags universally > >> and only does so for KSM, Anon and File pages while excluding > >> reserved pages at boot. Wondering should not we make printing > >> page->flags universal ? > > > > We used to do that and this caught me as a surprise when looking again. > > This is a result of 76a1850e4572 ("mm/debug.c: __dump_page() prints an > > extra line") which is a cleanup patch and I suspect this result was not > > anticipated. > > > > The following will do the trick but I cannot really say I like the code > > duplication. pr_cont in this case sounds like a much cleaner solution to > > me. > > How about this then? Yes makes sense as well. > diff --git mm/debug.c mm/debug.c > index 0461df1207cb..6a52316af839 100644 > --- mm/debug.c > +++ mm/debug.c > @@ -47,6 +47,7 @@ void __dump_page(struct page *page, const char *reason) > struct address_space *mapping; > bool page_poisoned = PagePoisoned(page); > int mapcount; > + char *type = ""; > > /* > * If struct page is poisoned don't access Page*() functions as that > @@ -78,9 +79,9 @@ void __dump_page(struct page *page, const char *reason) > page, page_ref_count(page), mapcount, > page->mapping, page_to_pgoff(page)); > if (PageKsm(page)) > - pr_warn("ksm flags: %#lx(%pGp)\n", page->flags, &page->flags); > + type = "ksm "; > else if (PageAnon(page)) > - pr_warn("anon flags: %#lx(%pGp)\n", page->flags, &page->flags); > + type = "anon "; > else if (mapping) { > if (mapping->host && mapping->host->i_dentry.first) { > struct dentry *dentry; > @@ -88,10 +89,11 @@ void __dump_page(struct page *page, const char *reason) > pr_warn("%ps name:\"%pd\"\n", mapping->a_ops, dentry); > } else > pr_warn("%ps\n", mapping->a_ops); > - pr_warn("flags: %#lx(%pGp)\n", page->flags, &page->flags); > } > BUILD_BUG_ON(ARRAY_SIZE(pageflag_names) != __NR_PAGEFLAGS + 1); > > + pr_warn("%sflags: %#lx(%pGp)\n", type, page->flags, &page->flags); > + > hex_only: > print_hex_dump(KERN_WARNING, "raw: ", DUMP_PREFIX_NONE, 32, > sizeof(unsigned long), page, > -- Michal Hocko SUSE Labs