From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4033EC33CB2 for ; Tue, 14 Jan 2020 09:51:02 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E675924677 for ; Tue, 14 Jan 2020 09:51:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E675924677 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5B70A8E0005; Tue, 14 Jan 2020 04:51:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 567348E0003; Tue, 14 Jan 2020 04:51:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 455968E0005; Tue, 14 Jan 2020 04:51:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0055.hostedemail.com [216.40.44.55]) by kanga.kvack.org (Postfix) with ESMTP id 2E5228E0003 for ; Tue, 14 Jan 2020 04:51:01 -0500 (EST) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id D6AE6181AC9BF for ; Tue, 14 Jan 2020 09:51:00 +0000 (UTC) X-FDA: 76375771080.18.woman66_42ff7cf920938 X-HE-Tag: woman66_42ff7cf920938 X-Filterd-Recvd-Size: 3963 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Tue, 14 Jan 2020 09:51:00 +0000 (UTC) Received: by mail-wr1-f66.google.com with SMTP id q10so11459429wrm.11 for ; Tue, 14 Jan 2020 01:51:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=pEjFsFpCypBmbTAAbsMBZocao2aRdb0v8F3qtUDClnU=; b=L8vXy6wvWtPmHt/v0phU+RNuPxGWNGCV3R5WSxXyWIjVH6X+v1gn+uslroLBUCyF2h 8xeBgS4VOQncOKQpHaudDQTYLVowd0Oc2OqBUxkKZZPUR+qii2hh3fGH2PA2srMBW5c0 kmQxXPrR+CsOv/dUBdYnmCWuw41csj5UYCZ19zS6siYtltCixFiH6GUfCIY+A1/LqzjZ WsyJOAWvtIQilDx/zDpX8d6+Ugh0M4i4RhfsQv1Qs/YOy+XWAKrEzTcKjTviYwbB08rC 1PJLxxNZzftvA36YBPbvCmS7CRxiGUgEacBDpQdIycNR8MfjAo12hVn4xHeQKxunw5oG Odbg== X-Gm-Message-State: APjAAAW3J05N9bGbDYUXdtrQN+t5x/fdFW45sX7i2lXkAKMpf6PW5Xu/ FtPiTgkR84SgEDj0vEWvIOQ= X-Google-Smtp-Source: APXvYqzcd9TQA5n6FKsfqJRldrVd7OL4sZZDEncBCpJwnaTi+pv49H3QMRWm9zPqXoTATkShHQWBlg== X-Received: by 2002:adf:a746:: with SMTP id e6mr24863095wrd.329.1578995459210; Tue, 14 Jan 2020 01:50:59 -0800 (PST) Received: from localhost (prg-ext-pat.suse.com. [213.151.95.130]) by smtp.gmail.com with ESMTPSA id b10sm19428113wrt.90.2020.01.14.01.50.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jan 2020 01:50:58 -0800 (PST) Date: Tue, 14 Jan 2020 10:50:57 +0100 From: Michal Hocko To: Tianyu Lan Cc: David Hildenbrand , "lantianyu1986@gmail.com" , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , "sashal@kernel.org" , "akpm@linux-foundation.org" , Michael Kelley , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , vkuznets , "eric.devolder@oracle.com" , "vbabka@suse.cz" , "osalvador@suse.de" , Pasha Tatashin , "rppt@linux.ibm.com" Subject: Re: [EXTERNAL] Re: [RFC PATCH V2 2/10] mm: expose is_mem_section_removable() symbol Message-ID: <20200114095057.GK19428@dhcp22.suse.cz> References: <20200107130950.2983-1-Tianyu.Lan@microsoft.com> <20200107130950.2983-3-Tianyu.Lan@microsoft.com> <20200107133623.GJ32178@dhcp22.suse.cz> <99a6db0c-6d73-d982-58b3-7a0172748ae4@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.2 (2019-09-21) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 13-01-20 14:49:38, Tianyu Lan wrote: > Hi David & Michal: > Thanks for your review. Some memory blocks are not suitable for hot-plug. > If not check memory block's removable, offline_pages() will report some failure error > e.g, "failed due to memory holes" and "failure to isolate range". I think the check maybe > added into offline_and_remove_memory()? This may help to not create/expose a new > interface to do such check in module. Why is a log message a problem in the first place. The operation has failed afterall. Does the driver try to offline an arbitrary memory? Could you describe your usecase in more details please? -- Michal Hocko SUSE Labs